mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[GH-ISSUE #5441] disable-sys.inc #2996
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#2996
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rusty-snake on GitHub (Oct 30, 2022).
Original GitHub issue: https://github.com/netblue30/firejail/issues/5441
Is your feature request related to a problem? Please describe.
/sysexposes a lot information about Kernel and Devices.Describe the solution you'd like
disable-sys.incinclude that disables files/dirs in/systhat are rarely needed by programs that do not interact with devices directly.@topimiettinen commented on GitHub (Nov 1, 2022):
For example serial numbers:
@rusty-snake commented on GitHub (Nov 1, 2022):
d8a5f385bf/src/firejail/fs.c (L743-L752)Are already blacklisted, this leaves
/sys/block,/sys/bus,/sys/class,/sys/dev,/sys/devicesand/sys/kernel. nNevertheless blacklisting in/sys/fsand/sys/moduleis needed as well for programs that need parts of them.@kmk3 commented on GitHub (Nov 4, 2022):
@topimiettinen commented on Nov 1:
Blocking this sounds good; how about adding something like
disable-hardware-ids.inc?
I'm not sure about the full extent of what /sys provides and what could be
broken by blocking things in it, but I think that hardware identifiers is a
fairly commonly known concept and that hardly any program would actually need
them (and so most profiles could probably safely block them).
As an example, it might be helpful to have access to MAC addresses in
Wireshark, but hardly so in web browsers.
@rusty-snake commented on GitHub (Nov 4, 2022):
My Firefox runs fine with only
58264c8a67/firejail/firefox.local (L16-L24)and I wouldn't say Firefox has low requirements.
@kmk3 commented on GitHub (Nov 4, 2022):
@rusty-snake commented on Nov 4:
That's good to know and to be clear I don't think that both options would be
mutually exclusive.
My point was more about the debuggability/visibility of it as a user.
If a program breaks because all/most of /sys is blocked and I don't know the
full scope of /sys and how legitimate is the program's need to access it, I
would first assume that the problem is in firejail blocking too much of /sys.
That is, it would more likely to result in
ignore include disable-sys.inc.If a program breaks specifically because it cannot access hardware
idenfitifers, that seems rather sketchy, so I'd be more inclined to try to
debug it and/or try to find an alternative program.