github-starred/firejail
2
0
Fork 0
mirror of https://github.com/netblue30/firejail.git synced 2026-05-15 14:16:14 -06:00
Code Issues 531 Projects Packages Wiki Activity Actions 6

[GH-ISSUE #5337] bleachbit: cannot securely delete the Trash #2962

New issue
Closed
opened 2026-05-05 09:37:37 -06:00 by gitea-mirror · 5 comments
gitea-mirror commented 2026-05-05 09:37:37 -06:00
Owner
Copy link

Originally created by @ghost on GitHub (Aug 23, 2022).
Original GitHub issue: https://github.com/netblue30/firejail/issues/5337

Is your feature request related to a problem? Please describe.

Problem 1:
Bleachbit is used to permanently delete files by overwriting the memory. So the most popular feature of Bleachbit is emptying the Trash.

But bleachbit.profile includes disable-common.inc which blacklists ${HOME}/.local/share/Trash so it's not possible to empty the trash with Bleachbit.

Problem 2:
Bleachbit has access to $HOME dir. I don't think it makes sense to deny it access to Trash dir but allow it to home dir. It would make more sense to be the other way around.

Describe the solution you'd like

Improvement 1 to bleachbit.profile:

Add this line:

noblacklist ${HOME}/.local/share/Trash

or if you think it should be blacklisted by default even though it's the most popular use case for Bleachbit, then add these comments:

# Uncomment this line to allow emptying trash (or add to bleachbit.local):
# noblacklist ${HOME}/.local/share/Trash

Improvement 2:

blacklist ${HOME}/Desktop
blacklist ${HOME}/Documents
blacklist ${HOME}/Downloads
blacklist ${HOME}/Music
blacklist ${HOME}/Pictures
blacklist ${HOME}/Public
blacklist ${HOME}/Templates
blacklist ${HOME}/Videos

Describe alternatives you've considered

I have made this improvements in bleachbit.local and it works great.

Something that made me confused at first after using Bleachbit to empty Trash, is that the files in ${HOME}/.local/share/Trash were gone as they are supposed to be, but browsing Trash directory through a file manager shows that the files are still there, but it also says the files don't exist if you try to delete them without Bleachbit. I spent some time searching for answers about this, but then I restarted my file manager and then the non-existant files were really gone.

Additional context

Just want to help out with this improvement and contribute. I think it's easier to post this as a feature request instead of making a pull request since it's just a simple profile improvement.

Originally created by @ghost on GitHub (Aug 23, 2022). Original GitHub issue: https://github.com/netblue30/firejail/issues/5337 ### Is your feature request related to a problem? Please describe. Problem 1: Bleachbit is used to permanently delete files by overwriting the memory. So the most popular feature of Bleachbit is emptying the Trash. But bleachbit.profile includes disable-common.inc which blacklists `${HOME}/.local/share/Trash` so it's not possible to empty the trash with Bleachbit. Problem 2: Bleachbit has access to $HOME dir. I don't think it makes sense to deny it access to Trash dir but allow it to home dir. It would make more sense to be the other way around. ### Describe the solution you'd like Improvement 1 to bleachbit.profile: Add this line: ``` noblacklist ${HOME}/.local/share/Trash ``` or if you think it should be blacklisted by default even though it's the most popular use case for Bleachbit, then add these comments: ``` # Uncomment this line to allow emptying trash (or add to bleachbit.local): # noblacklist ${HOME}/.local/share/Trash ``` Improvement 2: ``` blacklist ${HOME}/Desktop blacklist ${HOME}/Documents blacklist ${HOME}/Downloads blacklist ${HOME}/Music blacklist ${HOME}/Pictures blacklist ${HOME}/Public blacklist ${HOME}/Templates blacklist ${HOME}/Videos ``` ### Describe alternatives you've considered I have made this improvements in bleachbit.local and it works great. Something that made me confused at first after using Bleachbit to empty Trash, is that the files in `${HOME}/.local/share/Trash` were gone as they are supposed to be, but browsing Trash directory through a file manager shows that the files are still there, but it also says the files don't exist if you try to delete them without Bleachbit. I spent some time searching for answers about this, but then I restarted my file manager and then the non-existant files were really gone. ### Additional context Just want to help out with this improvement and contribute. I think it's easier to post this as a feature request instead of making a pull request since it's just a simple profile improvement.
gitea-mirror 2026-05-05 09:37:37 -06:00
  • closed this issue
  • added the
    bug
         label
gitea-mirror commented 2026-05-05 09:37:40 -06:00
Author
Owner
Copy link

@kmk3 commented on GitHub (Aug 25, 2022):

@ydididodat commented on Aug 23:

Is your feature request related to a problem? Please describe.

Problem 1: Bleachbit is used to permanently delete files by overwriting the
memory. So the most popular feature of Bleachbit is emptying the Trash.

But bleachbit.profile includes disable-common.inc which blacklists
${HOME}/.local/share/Trash so it's not possible to empty the trash with
Bleachbit.

Problem 2: Bleachbit has access to $HOME dir. I don't think it makes sense to
deny it access to Trash dir but allow it to home dir. It would make more
sense to be the other way around.

Describe the solution you'd like

Improvement 1 to bleachbit.profile:

Add this line:

noblacklist ${HOME}/.local/share/Trash

We could add these commands to the profile:

noblacklist ${HOME}/.local/share/Trash
include disable-xdg.inc

Besides that, do you know all the paths that the program generally needs to
access in the home directory? Such as configuration and cache files.

The security of the profile could be much improved by using whitelisting
commands to only allow access to specific paths. Blacklisting commands can
currently only block access to paths that already exist. That is, the program
is free to create ${HOME}/.foorc if it does not already exist, even if
blacklist ${HOME}/.foorc is used.

Describe alternatives you've considered

I have made this improvements in bleachbit.local and it works great.

Something that made me confused at first after using Bleachbit to empty
Trash, is that the files in ${HOME}/.local/share/Trash were gone as they are
supposed to be, but browsing Trash directory through a file manager shows
that the files are still there, but it also says the files don't exist if you
try to delete them without Bleachbit. I spent some time searching for answers
about this, but then I restarted my file manager and then the non-existant
files were really gone.

That indeed sounds strange.

Did this happen with or without noblacklist ${HOME}/.local/share/Trash?

What version of firejail and OS did you use?

Additional context

Just want to help out with this improvement and contribute.

That's great to hear; thanks for the report.

I think it's easier to post this as a feature request instead of making a
pull request since it's just a simple profile improvement.

I get what you mean and having a dedicated issue is usually good for extended
discussion, but feel free to also open a pull request if you want. I think
that generally pull requests are welcome, especially when the changes are
straightforward and the commits are self-explanatory (for example, see
https://chris.beams.io/posts/git-commit/).

<!-- gh-comment-id:1227176069 --> @kmk3 commented on GitHub (Aug 25, 2022): @ydididodat commented [on Aug 23](https://github.com/netblue30/firejail/issues/5337#issue-1348218365): > ### Is your feature request related to a problem? Please describe. > > Problem 1: Bleachbit is used to permanently delete files by overwriting the > memory. So the most popular feature of Bleachbit is emptying the Trash. > > But bleachbit.profile includes disable-common.inc which blacklists > `${HOME}/.local/share/Trash` so it's not possible to empty the trash with > Bleachbit. > > Problem 2: Bleachbit has access to $HOME dir. I don't think it makes sense to > deny it access to Trash dir but allow it to home dir. It would make more > sense to be the other way around. > > ### Describe the solution you'd like > > Improvement 1 to bleachbit.profile: > > Add this line: > > ``` > noblacklist ${HOME}/.local/share/Trash > ``` We could add these commands to the profile: ```firejail noblacklist ${HOME}/.local/share/Trash include disable-xdg.inc ``` Besides that, do you know all the paths that the program generally needs to access in the home directory? Such as configuration and cache files. The security of the profile could be much improved by using whitelisting commands to only allow access to specific paths. Blacklisting commands can currently only block access to paths that already exist. That is, the program is free to create `${HOME}/.foorc` if it does not already exist, even if `blacklist ${HOME}/.foorc` is used. > ### Describe alternatives you've considered > > I have made this improvements in bleachbit.local and it works great. > > Something that made me confused at first after using Bleachbit to empty > Trash, is that the files in ${HOME}/.local/share/Trash were gone as they are > supposed to be, but browsing Trash directory through a file manager shows > that the files are still there, but it also says the files don't exist if you > try to delete them without Bleachbit. I spent some time searching for answers > about this, but then I restarted my file manager and then the non-existant > files were really gone. That indeed sounds strange. Did this happen with or without `noblacklist ${HOME}/.local/share/Trash`? What version of firejail and OS did you use? > ### Additional context > > Just want to help out with this improvement and contribute. That's great to hear; thanks for the report. > I think it's easier to post this as a feature request instead of making a > pull request since it's just a simple profile improvement. I get what you mean and having a dedicated issue is usually good for extended discussion, but feel free to also open a pull request if you want. I think that generally pull requests are welcome, especially when the changes are straightforward and the commits are self-explanatory (for example, see <https://chris.beams.io/posts/git-commit/>).
gitea-mirror commented 2026-05-05 09:37:41 -06:00
Author
Owner
Copy link

@ghost commented on GitHub (Aug 27, 2022):

We could add these commands to the profile:

noblacklist ${HOME}/.local/share/Trash
include disable-xdg.inc

Besides that, do you know all the paths that the program generally needs to access in the home directory? Such as configuration and cache files.

The security of the profile could be much improved by using whitelisting commands to only allow access to specific paths. Blacklisting commands can currently only block access to paths that already exist. That is, the program is free to create ${HOME}/.foorc if it does not already exist, even if blacklist ${HOME}/.foorc is used.

sorry, don't know. I think it can be found out by monitoring the app without restrictions while testing the features you want. But I'm still a n00b and have lots to learn and too little time.

That indeed sounds strange.

Did this happen with or without noblacklist ${HOME}/.local/share/Trash?

What version of firejail and OS did you use?

Happened with noblacklist, if you don't have the noblacklist then it won't delete anything at all.

But I think it's normal behavior because I noticed later that if I delete (aka move to trash) things on other disks than the one my OS is on, and then I actually delete them in ${HOME}/.local/share/Trash then I look in the hidden Trash dir on the other disk which the files were in before I moved them to trash, and the files are still there even though they're deleted. If I try to delete them again it says they don't exist. So then I restart the file manager and the files are gone. So it seems like normal behavior.

That's great to hear; thanks for the report.

I think it's easier to post this as a feature request instead of making a
pull request since it's just a simple profile improvement.

I get what you mean and having a dedicated issue is usually good for extended discussion, but feel free to also open a pull request if you want. I think that generally pull requests are welcome, especially when the changes are straightforward and the commits are self-explanatory (for example, see https://chris.beams.io/posts/git-commit/).

I'm still new and learning and trying to setup my computers the way I like. So I'm just not ready to start doing pull requests yet. Currently I browse github in Whonix. I guess it should be fine to install git on it. I guess maybe I would use file sharing to move the project from the Whonix VM to my host and do the work (changes) there, then file share it back to Whonix VM and use git to make a pull request. Or maybe there are better/easier ways to use git with TOR.

Have to be careful when using Github because if you are working on a project which is currently legal, but in the future it becomes illegal, then you can be banned from Github and go to prison for it. That's what happened to the dev of Tornado Cash. Crazy!

<!-- gh-comment-id:1229228378 --> @ghost commented on GitHub (Aug 27, 2022): > We could add these commands to the profile: > > ``` > noblacklist ${HOME}/.local/share/Trash > include disable-xdg.inc > ``` > > Besides that, do you know all the paths that the program generally needs to access in the home directory? Such as configuration and cache files. > > The security of the profile could be much improved by using whitelisting commands to only allow access to specific paths. Blacklisting commands can currently only block access to paths that already exist. That is, the program is free to create `${HOME}/.foorc` if it does not already exist, even if `blacklist ${HOME}/.foorc` is used. sorry, don't know. I think it can be found out by monitoring the app without restrictions while testing the features you want. But I'm still a n00b and have lots to learn and too little time. > That indeed sounds strange. > > Did this happen with or without `noblacklist ${HOME}/.local/share/Trash`? > > What version of firejail and OS did you use? > Happened with noblacklist, if you don't have the noblacklist then it won't delete anything at all. But I think it's normal behavior because I noticed later that if I delete (aka move to trash) things on other disks than the one my OS is on, and then I actually delete them in ${HOME}/.local/share/Trash then I look in the hidden Trash dir on the other disk which the files were in before I moved them to trash, and the files are still there even though they're deleted. If I try to delete them again it says they don't exist. So then I restart the file manager and the files are gone. So it seems like normal behavior. > That's great to hear; thanks for the report. > > > I think it's easier to post this as a feature request instead of making a > > pull request since it's just a simple profile improvement. > > I get what you mean and having a dedicated issue is usually good for extended discussion, but feel free to also open a pull request if you want. I think that generally pull requests are welcome, especially when the changes are straightforward and the commits are self-explanatory (for example, see https://chris.beams.io/posts/git-commit/). I'm still new and learning and trying to setup my computers the way I like. So I'm just not ready to start doing pull requests yet. Currently I browse github in Whonix. I guess it should be fine to install git on it. I guess maybe I would use file sharing to move the project from the Whonix VM to my host and do the work (changes) there, then file share it back to Whonix VM and use git to make a pull request. Or maybe there are better/easier ways to use git with TOR. Have to be careful when using Github because if you are working on a project which is currently legal, but in the future it becomes illegal, then you can be banned from Github and go to prison for it. That's what happened to the dev of Tornado Cash. Crazy!
gitea-mirror commented 2026-05-05 09:37:42 -06:00
Author
Owner
Copy link

@rusty-snake commented on GitHub (Aug 28, 2022):

Improvement 1: Open a PR.
Improvement 2: No. Localization, ...

Whitdlisting: Will be a lot work (maybe the source code of blechbit contains a list) but if somebody wants to do this go for it.
While I'm not sure if we should make it the default we would at least include it as an opt-in commend.

[github usage]

For single file edits the github editor works good.

<!-- gh-comment-id:1229504845 --> @rusty-snake commented on GitHub (Aug 28, 2022): Improvement 1: Open a PR. Improvement 2: No. Localization, ... Whitdlisting: Will be a lot work (maybe the source code of blechbit contains a list) but if somebody wants to do this go for it. While I'm not sure if we should make it the default we would at least include it as an opt-in commend. > [github usage] For single file edits the github editor works good.
gitea-mirror commented 2026-05-05 09:37:43 -06:00
Author
Owner
Copy link

@kmk3 commented on GitHub (Jul 16, 2023):

Bleachbit is used to permanently delete files by overwriting the memory. So
the most popular feature of Bleachbit is emptying the Trash.

Improvement 2:

blacklist ${HOME}/Desktop
blacklist ${HOME}/Documents
blacklist ${HOME}/Downloads
blacklist ${HOME}/Music
blacklist ${HOME}/Pictures
blacklist ${HOME}/Public
blacklist ${HOME}/Templates
blacklist ${HOME}/Videos

This overwriting feature could also be useful to use in these other
directories, so blacklisting them (and/or using whitelisting in ${HOME})
might get in the way of that.

That is, since it works kind of like a file manager, blocking access to common
directories by default might be counter-productive, especially if files are
deleted directly instead of using the Trash directory (which is more likely to
be the case when using a WM instead of a DE).

@rusty-snake Thoughts?

<!-- gh-comment-id:1637064308 --> @kmk3 commented on GitHub (Jul 16, 2023): > Bleachbit is used to permanently delete files by overwriting the memory. So > the most popular feature of Bleachbit is emptying the Trash. > Improvement 2: > > ``` > blacklist ${HOME}/Desktop > blacklist ${HOME}/Documents > blacklist ${HOME}/Downloads > blacklist ${HOME}/Music > blacklist ${HOME}/Pictures > blacklist ${HOME}/Public > blacklist ${HOME}/Templates > blacklist ${HOME}/Videos > ``` This overwriting feature could also be useful to use in these other directories, so blacklisting them (and/or using whitelisting in `${HOME}`) might get in the way of that. That is, since it works kind of like a file manager, blocking access to common directories by default might be counter-productive, especially if files are deleted directly instead of using the Trash directory (which is more likely to be the case when using a WM instead of a DE). @rusty-snake Thoughts?
gitea-mirror commented 2026-05-05 09:37:44 -06:00
Author
Owner
Copy link

@kmk3 commented on GitHub (Aug 23, 2024):

Improvement 1 to bleachbit.profile:

Add this line:

noblacklist ${HOME}/.local/share/Trash

Added on commit 154ffadef ("bleachbit.profile: allow erasing Trash contents",
2023-07-15) / PR #5902.

Improvement 2:

blacklist ${HOME}/Desktop
blacklist ${HOME}/Documents
blacklist ${HOME}/Downloads
blacklist ${HOME}/Music
blacklist ${HOME}/Pictures
blacklist ${HOME}/Public
blacklist ${HOME}/Templates
blacklist ${HOME}/Videos

It needs access to these directories in order to overwrite the files in them as
well; wontfix.

Closing as resolved.

<!-- gh-comment-id:2307534202 --> @kmk3 commented on GitHub (Aug 23, 2024): > Improvement 1 to bleachbit.profile: > > Add this line: > > ``` > noblacklist ${HOME}/.local/share/Trash > ``` Added on commit 154ffadef ("bleachbit.profile: allow erasing Trash contents", 2023-07-15) / PR #5902. > Improvement 2: > > ``` > blacklist ${HOME}/Desktop > blacklist ${HOME}/Documents > blacklist ${HOME}/Downloads > blacklist ${HOME}/Music > blacklist ${HOME}/Pictures > blacklist ${HOME}/Public > blacklist ${HOME}/Templates > blacklist ${HOME}/Videos > ``` It needs access to these directories in order to overwrite the files in them as well; wontfix. Closing as resolved.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
serialize_remounts_v2
landlock_v4
landlock
release-0.9.64
release-0.9.62
gitlab_ci
LTSbase
fred_ctests
docs
0.9.80
0.9.80-rc1
0.9.78
0.9.76
0.9.76-rc4
0.9.76-rc3
0.9.76-rc2
0.9.76-rc1
0.9.74
landlock-split
0.9.72
0.9.72rc1
0.9.70
0.9.68
0.9.68rc1
0.9.66
0.9.66rc1
0.9.64.4
0.9.64.2
0.9.64
0.9.64rc1
0.9.62.4
0.9.62.2
0.9.62
0.9.56.2-LTS
0.9.60
0.9.60-rc1
0.9.58.2
0.9.58
0.9.58-rc1
0.9.56-LTS-release
0.9.56-LTS
0.9.56
0.9.56-rc1
0.9.54
0.9.54-rc2
0.9.54-rc1
0.9.52
0.9.38.12
0.9.50
0.9.50-rc1
0.9.48
0.9.46
0.9.46-rc1
0.9.44.10
0.9.44.8
0.9.44.6
0.9.38.10
0.9.44.4
0.9.38.8
0.9.44.2
0.9.44
0.9.44-rc1
0.9.38.4
0.9.42
0.9.42-rc2
0.9.38.2
0.9.42-rc1
disable-globalcfg
0.9.40
0.9.40-rc1
0.9.38
0.9.38-rc1
0.9.36
0.9.36-rc1
0.9.34
0.9.34-rc1
0.9.32
0.9.32-rc1
0.9.30
0.9.30-rc1
Labels
Clear labels   
LTS merge

   
LTS merge

   
bug

   
bug

   
converted-to-discussion

   
doc-todo

   
documentation

   
duplicate

   
enhancement

   
file-transfer

   
firecfg

   
firejail-in-firejail

   
firetools

   
graphics

   
help wanted

   
information_old

   
installation

   
invalid

   
modif

   
moved

   
needinfo

   
networking

   
notabug

   
notourbug

   
old-version

   
overlayfs

   
packaging

   
profile-request

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
question_old

   
removal

   
runtime-permissions

   
sandbox-ipc

   
security

   
stale

   
wiki

   
wiki

   
wontfix

   
wordpress

   
workaround
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#2962
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?