github-starred/firejail

Fork 0

mirror of https://github.com/netblue30/firejail.git synced 2026-05-15 14:16:14 -06:00

[GH-ISSUE #5297] Add electronapps-common.profile #2948

New issue

Closed

opened 2026-05-05 09:36:45 -06:00 by gitea-mirror · 4 comments

gitea-mirror commented

2026-05-05 09:36:45 -06:00

Owner

Originally created by @ghost on GitHub (Aug 6, 2022).
Original GitHub issue: https://github.com/netblue30/firejail/issues/5297

electronmail can't open the file picker. by disabling noroot, it works again. It's an electron app. There's a profile named electron, i assume it's the SDK, noroot is not there.

I think i remember, there was a sticky about electron apps. In general, these are tricky to handle.

Describe the solution you'd like

There should be a electronapps-common to minimize this kind of stuff.

Describe alternatives you've considered

Maybe also use electronapps-common in chromium-common. That's used by a lot of web browsers. Technically, they are a category of electron apps.

So electron-common could be build as a cut down version of chromium-common. That should keep complexity manageable.

Originally created by @ghost on GitHub (Aug 6, 2022). Original GitHub issue: https://github.com/netblue30/firejail/issues/5297 ### Is your feature request related to a problem? Please describe. electronmail can't open the file picker. by disabling noroot, it works again. It's an electron app. There's a profile named electron, i assume it's the SDK, noroot is not there. I think i remember, there was a sticky about electron apps. In general, these are tricky to handle. ### Describe the solution you'd like There should be a electronapps-common to minimize this kind of stuff. ### Describe alternatives you've considered Maybe also use electronapps-common in chromium-common. That's used by a lot of web browsers. Technically, they are a category of electron apps. So electron-common could be build as a cut down version of chromium-common. That should keep complexity manageable.

gitea-mirror

2026-05-05 09:36:45 -06:00

closed this issue
added the
notabug
label

gitea-mirror commented

2026-05-05 09:36:48 -06:00

Author

Owner

@rusty-snake commented on GitHub (Aug 6, 2022):

Here it is: https://github.com/netblue30/firejail/blob/master/etc/profile-a-l/electron.profile
it's just not named -common.

That electronmail needs to be refactored as electron redirect profile I said somewhere else already (but could not find it).

Technical electron is chromium and not the other ways around.

chromium + file-chooser + noroot (i.e. portals with noroot) is tracked in #4716.

@rusty-snake commented on GitHub (Aug 6, 2022): Here it is: https://github.com/netblue30/firejail/blob/master/etc/profile-a-l/electron.profile it's just not named `-common`. That electronmail needs to be refactored as electron redirect profile I said somewhere else already (but could not find it). --- Technical electron is chromium and not the other ways around. --- chromium + file-chooser + noroot (i.e. portals with noroot) is tracked in #4716.

gitea-mirror commented

2026-05-05 09:36:49 -06:00

Author

Owner

@ghost commented on GitHub (Aug 6, 2022):

then, it should be renamed -common. I thought it was the sdk or something. I'm not familiar with electron apps. They are over engineered and try to avoid them.... The description should also be more clear.

Who came first, the chicken or the egg? chromium-common can't technically redirect to electron? They are indeed related.

I wasn't complaining about noroot it self.

@ghost commented on GitHub (Aug 6, 2022): then, it should be renamed -common. I thought it was the sdk or something. I'm not familiar with electron apps. They are over engineered and try to avoid them.... The description should also be more clear. Who came first, the chicken or the egg? chromium-common can't technically redirect to electron? They are indeed related. I wasn't complaining about noroot it self.

gitea-mirror commented

2026-05-05 09:36:50 -06:00

Author

Owner

@kmk3 commented on GitHub (Aug 6, 2022):

Tagged "notabug" because as mentioned by @rusty-snake, electron.profile
already exists.

Re-closing as "not planned" since nothing was changed in firejail.

@kmk3 commented on GitHub (Aug 6, 2022): Tagged "notabug" because [as mentioned][1] by @rusty-snake, electron.profile already exists. Re-closing as "not planned" since nothing was changed in firejail. [1]: https://github.com/netblue30/firejail/issues/5297#issuecomment-1207291429

gitea-mirror commented

2026-05-05 09:36:51 -06:00

Author

Owner

@ghost commented on GitHub (Aug 7, 2022):

there's this amusing comment in the electron.profile

# Add the next line to your chromium-common.local if your kernel allows unprivileged userns clone.
#include chromium-common-hardened.inc.profile

Maybe chromium-common and electron should indeed have a common redirect. Maybe call it sandboxed-blink-common or something like that.

And renaming it to electron-common is probably better. You should follow conventions, or people get confused. Just call all profiles that are meant to be redirects -common.

@ghost commented on GitHub (Aug 7, 2022): there's this amusing comment in the electron.profile ``` # Add the next line to your chromium-common.local if your kernel allows unprivileged userns clone. #include chromium-common-hardened.inc.profile ``` Maybe chromium-common and electron should indeed have a common redirect. Maybe call it sandboxed-blink-common or something like that. And renaming it to electron-common is probably better. You should follow conventions, or people get confused. Just call all profiles that are meant to be redirects -common.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#2948

No description provided.

Rows
Columns