[GH-ISSUE #5188] Update syscall tables and seccomp groups #2905

Closed
opened 2026-05-05 09:34:10 -06:00 by gitea-mirror · 4 comments
Owner

Originally created by @rusty-snake on GitHub (Jun 10, 2022).
Original GitHub issue: https://github.com/netblue30/firejail/issues/5188

Related: #3106

Since your last seccomp groups update Linux got new syscalls like clone3 (@process), close_range (@basic-io) or move_mount,open_tree,fsconfig,fsmount,fsopen,fspick (@mount). We should update the group definitions to include newly added syscalls.

Originally created by @rusty-snake on GitHub (Jun 10, 2022). Original GitHub issue: https://github.com/netblue30/firejail/issues/5188 Related: #3106 Since your last seccomp groups update Linux got new syscalls like `clone3` (`@process`), `close_range` (`@basic-io`) or `move_mount`,`open_tree`,`fsconfig`,`fsmount`,`fsopen`,`fspick` (`@mount`). We should update the group definitions to include newly added syscalls.
gitea-mirror 2026-05-05 09:34:10 -06:00
Author
Owner

@rusty-snake commented on GitHub (Jul 17, 2022):

@smitsohu can we close?

<!-- gh-comment-id:1186587262 --> @rusty-snake commented on GitHub (Jul 17, 2022): @smitsohu can we close?
Author
Owner

@smitsohu commented on GitHub (Jul 17, 2022):

Closing!

<!-- gh-comment-id:1186631894 --> @smitsohu commented on GitHub (Jul 17, 2022): Closing!
Author
Owner

@kmk3 commented on GitHub (Aug 21, 2022):

Misc: These commits seem to be related:

  • fbceab90a ("refresh and sort syscall tables", 2022-07-15)
  • f4f44a5f9 ("refresh syscall groups (#5188)", 2022-07-17)

And I made a few WIP commits related to the first one.

Since this issue appears to be the most relevant one to that commit, I renamed
this issue to be about the syscalls too.

<!-- gh-comment-id:1221500967 --> @kmk3 commented on GitHub (Aug 21, 2022): Misc: These commits seem to be related: * fbceab90a ("refresh and sort syscall tables", 2022-07-15) * f4f44a5f9 ("refresh syscall groups (#5188)", 2022-07-17) And I made a few WIP commits related to the first one. Since this issue appears to be the most relevant one to that commit, I renamed this issue to be about the syscalls too.
Author
Owner

@kmk3 commented on GitHub (Aug 21, 2022):

(Late review)

@smitsohu

  • fbceab90a ("refresh and sort syscall tables", 2022-07-15)

Please try to avoid doing both sorting and logical changes on the same commit,
as that can make it really hard to see what was changed (and I was interested
to see what syscalls were added/removed in this case).

Considering that the tables weren't fully sorted (by syscall name), the diffs
would have been clearer by splitting the changes like this:

  1. sort syscall tables (by name)
  2. refresh syscall tables
  3. sort syscall tables (by number)

Or like this:

  1. sort syscall tables (by number)
  2. refresh syscall tables
<!-- gh-comment-id:1221506010 --> @kmk3 commented on GitHub (Aug 21, 2022): (Late review) @smitsohu * fbceab90a ("refresh and sort syscall tables", 2022-07-15) Please try to avoid doing both sorting and logical changes on the same commit, as that can make it really hard to see what was changed (and I was interested to see what syscalls were added/removed in this case). Considering that the tables weren't fully sorted (by syscall name), the diffs would have been clearer by splitting the changes like this: 1. sort syscall tables (by name) 2. refresh syscall tables 3. sort syscall tables (by number) Or like this: 1. sort syscall tables (by number) 2. refresh syscall tables
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#2905
No description provided.