github-starred/firejail
2
0
Fork 0
mirror of https://github.com/netblue30/firejail.git synced 2026-05-15 14:16:14 -06:00
Code Issues 531 Projects Packages Wiki Activity Actions 6

[GH-ISSUE #4930] nogroups + wrc prints confusing messages #2826

New issue
Closed
opened 2026-05-05 09:28:46 -06:00 by gitea-mirror · 2 comments
gitea-mirror commented 2026-05-05 09:28:46 -06:00
Owner
Copy link

Originally created by @rusty-snake on GitHub (Feb 11, 2022).
Original GitHub issue: https://github.com/netblue30/firejail/issues/4930

Description

nogroups + wrc prints confusing messages.

Steps to Reproduce

  1. Create test.profile (ordering doesn't matter)
include whitelist-run-common.inc
nogroups
  1. test, run and see
$ firejail --profile=./test.profile groups
Reading profile ./test.profile
Reading profile /etc/firejail/whitelist-run-common.inc
Parent pid 1234, child pid 1235
Warning: logind not detected, nogroups command ignored     <--- is a lie
Warning: cleaning all supplementary groups
Child process initialized in 30.00 ms
rusty-snake    <---- running `groups` outside of the sandbox shows more so groups are actually cleaned

Parent is shutting down, bye...

Expected behavior

  1. Warning: logind not detected is only shown when there is no logind
  2. Warning: nogroups command ignored is only shown when it is relly ignored

Actual behavior

  1. Warning: logind not detected is shown on logind systems
  2. Warning: nogroups command ignored; cleaning all supplementary groups makes no sense and confuses users.

Additional context

Environment

  • Fedora Linux 35 (of course with systemd/logind)
firejail version 0.9.69 (03395e1)

Compile time support:
	- always force nonewprivs support is disabled
	- AppArmor support is disabled
	- AppImage support is enabled
	- chroot support is disabled
	- D-BUS proxy support is enabled
	- file transfer support is disabled
	- firetunnel support is disabled
	- networking support is disabled
	- output logging is disabled
	- overlayfs support is disabled
	- private-home support is disabled
	- private-cache and tmpfs as user enabled
	- SELinux support is enabled
	- user namespace support is enabled
	- X11 sandboxing support is disabled

Edit by @kmk3: Formatting.

Originally created by @rusty-snake on GitHub (Feb 11, 2022). Original GitHub issue: https://github.com/netblue30/firejail/issues/4930 ### Description `nogroups` + wrc prints confusing messages. ### Steps to Reproduce 1. Create test.profile (ordering doesn't matter) ``` include whitelist-run-common.inc nogroups ``` 2. test, run and see ```console $ firejail --profile=./test.profile groups Reading profile ./test.profile Reading profile /etc/firejail/whitelist-run-common.inc Parent pid 1234, child pid 1235 Warning: logind not detected, nogroups command ignored <--- is a lie Warning: cleaning all supplementary groups Child process initialized in 30.00 ms rusty-snake <---- running `groups` outside of the sandbox shows more so groups are actually cleaned Parent is shutting down, bye... ``` ### Expected behavior 1. `Warning: logind not detected` is only shown when there is no logind 2. `Warning: nogroups command ignored` is only shown when it is relly ignored ### Actual behavior 1. `Warning: logind not detected` is shown on logind systems 2. `Warning: nogroups command ignored; cleaning all supplementary groups` makes no sense and confuses users. ### Additional context * #4725 * #4732 ### Environment - Fedora Linux 35 (of course with systemd/logind) ``` firejail version 0.9.69 (03395e1) Compile time support: - always force nonewprivs support is disabled - AppArmor support is disabled - AppImage support is enabled - chroot support is disabled - D-BUS proxy support is enabled - file transfer support is disabled - firetunnel support is disabled - networking support is disabled - output logging is disabled - overlayfs support is disabled - private-home support is disabled - private-cache and tmpfs as user enabled - SELinux support is enabled - user namespace support is enabled - X11 sandboxing support is disabled ``` --- Edit by @kmk3: Formatting.
gitea-mirror 2026-05-05 09:28:46 -06:00
  • closed this issue
  • added the
    bug
         label
gitea-mirror commented 2026-05-05 09:28:49 -06:00
Author
Owner
Copy link

@ghost commented on GitHub (Feb 11, 2022):

Reproduced on Arch Linux. I can definately agree on Expected behavior as described above. Nice find 👍.

<!-- gh-comment-id:1036341192 --> @ghost commented on GitHub (Feb 11, 2022): Reproduced on Arch Linux. I can definately agree on `Expected behavior` as described above. Nice find :+1:.
gitea-mirror commented 2026-05-05 09:28:50 -06:00
Author
Owner
Copy link

@kmk3 commented on GitHub (Feb 11, 2022):

@rusty-snake commented on Feb 11:

Description

nogroups + wrc prints confusing messages.

Steps to Reproduce

  1. Create test.profile (ordering doesn't matter)
include whitelist-run-common.inc
nogroups
  1. test, run and see
$ firejail --profile=./test.profile groups
Reading profile ./test.profile
Reading profile /etc/firejail/whitelist-run-common.inc
Parent pid 1234, child pid 1235
Warning: logind not detected, nogroups command ignored     <--- is a lie
Warning: cleaning all supplementary groups
Child process initialized in 30.00 ms
rusty-snake    <---- running `groups` outside of the sandbox shows more so groups are actually cleaned

Parent is shutting down, bye...

Good catch.

I think this probably happens because check_can_drop_all_groups is called
multiple times and at different places (so it probably runs both before and
after the whitelisting).

IIRC I had tried originally to make the checks run only once a startup, which
would be less likely to fail, but it didn't work for some reason.

I think I'll just comment these messages for now until a better solution is
found.

<!-- gh-comment-id:1036529324 --> @kmk3 commented on GitHub (Feb 11, 2022): @rusty-snake commented [on Feb 11](https://github.com/netblue30/firejail/issues/4930#issue-1132297908): > ### Description > > `nogroups` + wrc prints confusing messages. > ### Steps to Reproduce > > 1. Create test.profile (ordering doesn't matter) > > ``` > include whitelist-run-common.inc > nogroups > ``` > > 2. test, run and see > > ``` > $ firejail --profile=./test.profile groups > Reading profile ./test.profile > Reading profile /etc/firejail/whitelist-run-common.inc > Parent pid 1234, child pid 1235 > Warning: logind not detected, nogroups command ignored <--- is a lie > Warning: cleaning all supplementary groups > Child process initialized in 30.00 ms > rusty-snake <---- running `groups` outside of the sandbox shows more so groups are actually cleaned > > Parent is shutting down, bye... > ``` Good catch. I think this probably happens because `check_can_drop_all_groups` is called multiple times and at different places (so it probably runs both before and after the whitelisting). IIRC I had tried originally to make the checks run only once a startup, which would be less likely to fail, but it didn't work for some reason. I think I'll just comment these messages for now until a better solution is found.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
serialize_remounts_v2
landlock_v4
landlock
release-0.9.64
release-0.9.62
gitlab_ci
LTSbase
fred_ctests
docs
0.9.80
0.9.80-rc1
0.9.78
0.9.76
0.9.76-rc4
0.9.76-rc3
0.9.76-rc2
0.9.76-rc1
0.9.74
landlock-split
0.9.72
0.9.72rc1
0.9.70
0.9.68
0.9.68rc1
0.9.66
0.9.66rc1
0.9.64.4
0.9.64.2
0.9.64
0.9.64rc1
0.9.62.4
0.9.62.2
0.9.62
0.9.56.2-LTS
0.9.60
0.9.60-rc1
0.9.58.2
0.9.58
0.9.58-rc1
0.9.56-LTS-release
0.9.56-LTS
0.9.56
0.9.56-rc1
0.9.54
0.9.54-rc2
0.9.54-rc1
0.9.52
0.9.38.12
0.9.50
0.9.50-rc1
0.9.48
0.9.46
0.9.46-rc1
0.9.44.10
0.9.44.8
0.9.44.6
0.9.38.10
0.9.44.4
0.9.38.8
0.9.44.2
0.9.44
0.9.44-rc1
0.9.38.4
0.9.42
0.9.42-rc2
0.9.38.2
0.9.42-rc1
disable-globalcfg
0.9.40
0.9.40-rc1
0.9.38
0.9.38-rc1
0.9.36
0.9.36-rc1
0.9.34
0.9.34-rc1
0.9.32
0.9.32-rc1
0.9.30
0.9.30-rc1
Labels
Clear labels   
LTS merge

   
LTS merge

   
bug

   
bug

   
converted-to-discussion

   
doc-todo

   
documentation

   
duplicate

   
enhancement

   
file-transfer

   
firecfg

   
firejail-in-firejail

   
firetools

   
graphics

   
help wanted

   
information_old

   
installation

   
invalid

   
modif

   
moved

   
needinfo

   
networking

   
notabug

   
notourbug

   
old-version

   
overlayfs

   
packaging

   
profile-request

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
question_old

   
removal

   
runtime-permissions

   
sandbox-ipc

   
security

   
stale

   
wiki

   
wiki

   
wontfix

   
wordpress

   
workaround
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#2826
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?