mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[GH-ISSUE #4867] Rename and move /etc/firejail/hostnames #2794
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#2794
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @reinerh on GitHub (Jan 19, 2022).
Original GitHub issue: https://github.com/netblue30/firejail/issues/4867
Hi @netblue30,
the new 0.9.68-rc1 installs the file
/etc/firejail/hostnames.Is this file really supposed to be a configuration file? I.e. is the user supposed to change it?
The geoip-database package has its data for example in
/usr/share/GeoIP/GeoIP.dat, which is probably a better place for static data.I also think
hostnamesis a bit poorly named. I couldn't find any hostnames in the file, only mappings from IP addresses/ranges to their owners.In a comment in this file you mention that you obtained it from a geoip package available on Linux distributions. I couldn't find such a file in the source of Debian's
geoip-database.(https://sources.debian.org/src/geoip-database/20191224-3/)
Can you please clarify what the source of the file is? I need to document its license etc in the package.
@netblue30 commented on GitHub (Jan 20, 2022):
Bad name: I'll change it to static-ip-map.
I'll move the file to /usr/lib/firejail.
The file was build mainly by running /usr/bin/whois on addresses I saw coming up in the trace. Most webpages are served today from a handful of CDN or cloud providers. For Google, Cloudflare and Amazon I've found the official public webpages where they list their current addresses. We will have to update our list from time to time (I included the official webpages in the file).
The country name is printed in the trace only if geoip-bin is installed on the system. Our program calls /usr/bin/geoiplookup directly.
I'll put the fixes in, thanks.
Later: We are similar to geoip, all the data is compiled from public sources. I saw they use OpenDataLicense for copyright purposes. Probably we can stay with GPLv2.
@kmk3 commented on GitHub (Feb 1, 2022):
@netblue30 commented on Jan 20:
+1
I think that the license discussion probably deserves its own issue, so I
started one on #4888.
Closing this as the naming and path issues were fixed.