mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[GH-ISSUE #4706] Implement case insensitive sorting of profiles on GitHub to avoid duplication #2760
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#2760
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Lonniebiz on GitHub (Nov 22, 2021).
Original GitHub issue: https://github.com/netblue30/firejail/issues/4706
I downloaded an AppImage of discord from here:
https://www.appimagehub.com/p/1420323/
Debian 11 stable provides firejail version 0.9.64.4, which doesn't have a profile in /etc/firejail/ for discord.
At https://github.com/netblue30/firejail/tree/master/etc/profile-a-l , I located these profile files:
Notice that multiple similar files only differ by capitalization. This is probably a product of the poor sort-order offered by github here and such a "cause of redundancy" may be avoided in the future if it is possible to set github to do some type of case insensitive sorting of profiles that would group these files (above) next to each other and prevent people from overlooking when a profile already exists but has different capitalization.
Also, when I look inside these files I see includes to other (non-discord-named) files.
So, far, when I've found profiles on github, since they are not in my /etc/firejail/ already, I've considered them custom and I've been placing them at ~/.config/firejail/ instead of just placing them in the /etc/firejail/ folder that came with my distribution's installation of firejail.
However, in this case, I'm not sure what to do. I could manually follow all includes and put all dependencies files into ~/.config/firejail/, or I could just place the proper discord profiles into /etc/firejail/ where most of those non-discord includes within (like "include globals.local") will likely already reside at a resolvable relative path.
Or, I could just make one file that includes everything instead of including all the separate files in ~/.config/firejail/ .
So, I'm reporting this seeming redundancy located at https://github.com/netblue30/firejail/tree/master/etc/profile-a-l for discord, but I'd appreciate any advise regarding the proper location to start consuming the correct profile for discord.
@rusty-snake commented on GitHub (Nov 22, 2021):
The easiest way to find a (pro)file on github (case insensitive): https://github.com/netblue30/firejail/find/master
Copying profiles from github (master) to an stable release of firejail can cause trouble because they are written for a newer firejail version.
um wait a minute, this pages says something else https://packages.debian.org/bullseye/all/firejail-profiles/filelist
@Lonniebiz commented on GitHub (Nov 22, 2021):
@rusty-snake It took me a moment to realize that I could just type to filter that master list, but I do like the quick-search-profile-link you provided. I'll go there from now on when looking for profiles.
As for discord being in
/etc/firejail/, it is indeed there. I did look yesterday and I'm not sure how I overlooked it, but I did. Thank you.Are the varying capitalizations of the discord profiles intentional?
@reinerh commented on GitHub (Nov 23, 2021):
Profile names are capitalized the same as the filenames of the binaries that are distributed (some packages might distribute it as
Discord(maybe the official one?), others maybe asdiscord).Firejail uses the filename of the application to find the profile that should be applied to it.
@rusty-snake commented on GitHub (Jun 8, 2022):
See @reinerh's comment.