github-starred/firejail

Fork 0

mirror of https://github.com/netblue30/firejail.git synced 2026-05-15 14:16:14 -06:00

[GH-ISSUE #4421] Fix new profiles after [no]deny / [no]allow revert #2662

New issue

Closed

opened 2026-05-05 09:19:32 -06:00 by gitea-mirror · 4 comments

gitea-mirror commented

2026-05-05 09:19:32 -06:00

Owner

Originally created by @adgross on GitHub (Jul 26, 2021).
Original GitHub issue: https://github.com/netblue30/firejail/issues/4421

Files from the commit a25e4a1011 still uses deny / nodeny and allow / noallow after merging the revert 8b50039a1f.
The revert commit f43382f1e9 is older than these profiles, while the merge itself happened later, so the revert missed the new files.

Affected files:

io.github.lainsce.Notejot.profile [L9-L10, L23-L25]
lifeograph.profile [L9-L11, L22-L23]
rednotebook.profile [L9-L10, L25-L33]
zim.profile [L9-L10, L16, L29-L38]

Originally created by @adgross on GitHub (Jul 26, 2021). Original GitHub issue: https://github.com/netblue30/firejail/issues/4421 Files from the commit a25e4a101129471f3221df5471e2fc8fa6a1c4e6 still uses deny / nodeny and allow / noallow after merging the revert 8b50039a1fad123b90172fadc85bc232e97eb6d1. The revert commit f43382f1e9707b4fd5e63c7bfe881912aa4ee994 is older than these profiles, while the merge itself happened later, so the revert missed the new files. Affected files: - io.github.lainsce.Notejot.profile [[L9-L10](https://github.com/netblue30/firejail/blob/master/etc/profile-m-z/io.github.lainsce.Notejot.profile#L9-L10), [L23-L25](https://github.com/netblue30/firejail/blob/master/etc/profile-m-z/io.github.lainsce.Notejot.profile#L23-L25)] - lifeograph.profile [[L9-L11](https://github.com/netblue30/firejail/blob/master/etc/profile-a-l/lifeograph.profile#L9-L11), [L22-L23](https://github.com/netblue30/firejail/blob/master/etc/profile-a-l/lifeograph.profile#L22-L23)] - rednotebook.profile [[L9-L10](https://github.com/netblue30/firejail/blob/master/etc/profile-m-z/rednotebook.profile#L9-L10), [L25-L33](https://github.com/netblue30/firejail/blob/master/etc/profile-m-z/rednotebook.profile#L25-L33)] - zim.profile [[L9-L10](https://github.com/netblue30/firejail/blob/master/etc/profile-m-z/zim.profile#L9-L10), [L16](https://github.com/netblue30/firejail/blob/master/etc/profile-m-z/zim.profile#L16), [L29-L38](https://github.com/netblue30/firejail/blob/master/etc/profile-m-z/zim.profile#L29-L38)]

gitea-mirror closed this issue

2026-05-05 09:19:33 -06:00

gitea-mirror commented

2026-05-05 09:19:35 -06:00

Author

Owner

@rusty-snake commented on GitHub (Jul 26, 2021):

And #4407.

@rusty-snake commented on GitHub (Jul 26, 2021): And #4407.

gitea-mirror commented

2026-05-05 09:19:36 -06:00

Author

Owner

@rusty-snake commented on GitHub (Jul 28, 2021):

2e4d52ec60

@rusty-snake commented on GitHub (Jul 28, 2021): 2e4d52ec60a677586decc62b0d1bc26757a2856a

gitea-mirror commented

2026-05-05 09:19:37 -06:00

Author

Owner

@kmk3 commented on GitHub (Jul 29, 2021):

Thanks everyone for catching and fixing this. I wasn't sure how/when to handle
PRs with profile changes made between the original commit (fe0f975) and the
merge of the revert (f43382f), so I had just set it aside. But it looks like
everything has been caught indeed:

$ git checkout master >/dev/null 2>&1
$ git show --pretty='%h %ai %s' -s
982013d3b 2021-07-28 21:15:36 +0200 Fixup: Fix Firefox 'Profile not found' - whitelist /run/user/xxx/firefox
$ git grep -E '^#?allow |^#?deny |deny-nolog|noallow|nodeny' -- \
  etc/inc etc/profile-* etc/templates/*.template
$

And the remaining open PRs seem to be unaffected as well.

Nice to see it all sorted out.

Link to the revert PR for cross-reference: #4410.

@kmk3 commented on GitHub (Jul 29, 2021): Thanks everyone for catching and fixing this. I wasn't sure how/when to handle PRs with profile changes made between the original commit (fe0f975) and the merge of the revert (f43382f), so I had just set it aside. But it looks like everything has been caught indeed: ```console $ git checkout master >/dev/null 2>&1 $ git show --pretty='%h %ai %s' -s 982013d3b 2021-07-28 21:15:36 +0200 Fixup: Fix Firefox 'Profile not found' - whitelist /run/user/xxx/firefox $ git grep -E '^#?allow |^#?deny |deny-nolog|noallow|nodeny' -- \ etc/inc etc/profile-* etc/templates/*.template $ ``` And the remaining open PRs seem to be unaffected as well. Nice to see it all sorted out. Link to the revert PR for cross-reference: #4410.

gitea-mirror commented

2026-05-05 09:19:37 -06:00

Author

Owner

@Fred-Barclay commented on GitHub (Jul 30, 2021):

Ha I ran across the files by accident in that commit - thanks to @adgross for catching these as well!

@Fred-Barclay commented on GitHub (Jul 30, 2021): Ha I ran across the files by accident in that commit - thanks to @adgross for catching these as well!

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#2662

No description provided.

Rows
Columns