[GH-ISSUE #4157] [Feature] Should rmenv GitHub auth tokens #2556

New issue

Closed

opened 2026-05-05 09:13:50 -06:00 by gitea-mirror · 2 comments

gitea-mirror commented

2026-05-05 09:13:50 -06:00

Owner

Originally created by @matthew-cline on GitHub (Apr 2, 2021).
Original GitHub issue: https://github.com/netblue30/firejail/issues/4157

The GitHub command line app (gh) uses GitHub personal access tokens. These can be passed to gh via environmental variables:

GH_TOKEN
GITHUB_TOKEN
GH_ENTERPRISE_TOKEN
GITHUB_ENTERPRISE_TOKEN

These should be rmenv'd somewhere. Perhaps in disable-passwdmgr.inc?

Originally created by @matthew-cline on GitHub (Apr 2, 2021). Original GitHub issue: https://github.com/netblue30/firejail/issues/4157 The [GitHub command line app (gh)](https://cli.github.com/) uses GitHub [personal access tokens](https://docs.github.com/en/github/authenticating-to-github/creating-a-personal-access-token). These can be passed to `gh` via [environmental variables](https://cli.github.com/manual/gh_help_environment): - `GH_TOKEN` - `GITHUB_TOKEN` - `GH_ENTERPRISE_TOKEN` - `GITHUB_ENTERPRISE_TOKEN` These should be `rmenv`'d somewhere. Perhaps in `disable-passwdmgr.inc`?

gitea-mirror

2026-05-05 09:13:50 -06:00

closed this issue
added the
enhancement
label

gitea-mirror commented

2026-05-05 09:13:53 -06:00

Author

Owner

@rusty-snake commented on GitHub (Apr 2, 2021):

Keep in mind that even if you rmenv them, a sandbox can still read the file where they are set if this file is not blacklisted or has no whitelist (in whitelisting profiles).

@rusty-snake commented on GitHub (Apr 2, 2021): Keep in mind that even if you `rmenv` them, a sandbox can still read the file where they are set if this file is not `blacklist`ed or has no `whitelist` (in whitelisting profiles).

gitea-mirror commented

2026-05-05 09:13:53 -06:00

Author

Owner

@kmk3 commented on GitHub (Dec 11, 2021):

For future reference, the rmenv entries were moved to disable-common.inc
on #4461.

@kmk3 commented on GitHub (Dec 11, 2021): For future reference, the `rmenv` entries were moved to [disable-common.inc][1] on #4461. [1]: https://github.com/netblue30/firejail/blob/master/etc/inc/disable-common.inc

gitea-mirror referenced this issue

2026-05-05 10:19:26 -06:00

[PR #2556] [MERGED] Fix clawsker for older GTK2 versions #4402

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#2556

No description provided.

Rows
Columns