github-starred/firejail

Fork 0

mirror of https://github.com/netblue30/firejail.git synced 2026-05-15 14:16:14 -06:00

[GH-ISSUE #3960] Patches from Jolla #2478

New issue

Closed

opened 2026-05-05 09:09:49 -06:00 by gitea-mirror · 7 comments

gitea-mirror commented

2026-05-05 09:09:49 -06:00

Owner

Originally created by @SkewedZeppelin on GitHub (Feb 8, 2021).
Original GitHub issue: https://github.com/netblue30/firejail/issues/3960

The Jolla company seems to have used Firejail in their recent OS update.
That is pretty neat.
https://forum.sailfishos.org/t/release-notes-koli-4-0-1/4542

They have some patches here which maybe should be considered for upstream inclusion:
https://github.com/sailfishos/firejail/blob/master/rpm/0002-Fix-symlinks-that-go-though-proc-self.patch
https://github.com/sailfishos/firejail/blob/master/rpm/0007-fcopy-Fix-memory-leaks.patch
https://github.com/sailfishos/firejail/blob/master/rpm/0009-sandbox-Do-not-leave-file-mounts-underneath-private-.patch

Originally created by @SkewedZeppelin on GitHub (Feb 8, 2021). Original GitHub issue: https://github.com/netblue30/firejail/issues/3960 The Jolla company seems to have used Firejail in their recent OS update. That is pretty neat. https://forum.sailfishos.org/t/release-notes-koli-4-0-1/4542 They have some patches here which maybe should be considered for upstream inclusion: https://github.com/sailfishos/firejail/blob/master/rpm/0002-Fix-symlinks-that-go-though-proc-self.patch https://github.com/sailfishos/firejail/blob/master/rpm/0007-fcopy-Fix-memory-leaks.patch https://github.com/sailfishos/firejail/blob/master/rpm/0009-sandbox-Do-not-leave-file-mounts-underneath-private-.patch

gitea-mirror

2026-05-05 09:09:49 -06:00

closed this issue
added the
enhancement
label

gitea-mirror commented

2026-05-05 09:09:52 -06:00

Author

Owner

@netblue30 commented on GitHub (Feb 9, 2021):

I think I'll grab all of them - thanks!

@netblue30 commented on GitHub (Feb 9, 2021): I think I'll grab all of them - thanks!

gitea-mirror commented

2026-05-05 09:09:53 -06:00

Author

Owner

@Tomin1 commented on GitHub (Feb 10, 2021):

Hi! I'm glad that there is interest in our enhancements to firejail. We would like to prepare pull requests for our patches.

@Tomin1 commented on GitHub (Feb 10, 2021): Hi! I'm glad that there is interest in our enhancements to firejail. We would like to prepare pull requests for our patches.

gitea-mirror commented

2026-05-05 09:09:54 -06:00

Author

Owner

@netblue30 commented on GitHub (Feb 10, 2021):

Thanks, that's even better. Send the patches!

@netblue30 commented on GitHub (Feb 10, 2021): Thanks, that's even better. Send the patches!

gitea-mirror commented

2026-05-05 09:09:55 -06:00

Author

Owner

@Tomin1 commented on GitHub (Feb 15, 2021):

@netblue30 Do you think you could handle these three patches as one PR or should I create separate PRs? Additionally I think
0005-Add-missing-linefeeds-in-stderr-logging.patch would be also good fit to the same PR if you agree that it's a useful fix.

I will also make PRs for some of the other patches if they have any chance of being accepted. I'm thinking I would first do those three or four already mentioned and then separately:
0003-Add-utility-functions-for-handing-comma-separa.patch, and
0004-Allow-changing-protocol-list-after-initial-set.patch together since they are part of the same improvement.

0006-PATCH-Add-mkdir-and-mkfile-command-line-options-for-.patch as yet another PR.

That would leave two patches that I guess are not that useful for most firejail users since they are very Sailfish OS specific.

@Tomin1 commented on GitHub (Feb 15, 2021): @netblue30 Do you think you could handle these three patches as one PR or should I create separate PRs? Additionally I think `0005-Add-missing-linefeeds-in-stderr-logging.patch` would be also good fit to the same PR if you agree that it's a useful fix. I will also make PRs for some of the other patches if they have any chance of being accepted. I'm thinking I would first do those three or four already mentioned and then separately: `0003-Add-utility-functions-for-handing-comma-separa.patch`, and `0004-Allow-changing-protocol-list-after-initial-set.patch` together since they are part of the same improvement. `0006-PATCH-Add-mkdir-and-mkfile-command-line-options-for-.patch` as yet another PR. That would leave two patches that I guess are not that useful for most firejail users since they are very Sailfish OS specific.

gitea-mirror commented

2026-05-05 09:09:56 -06:00

Author

Owner

@netblue30 commented on GitHub (Feb 17, 2021):

Do you think you could handle these three patches as one PR or should I create separate PRs?

Your choice, it doesn't really mater. And send patches for all the rest! Thanks a lot!

@netblue30 commented on GitHub (Feb 17, 2021): > Do you think you could handle these three patches as one PR or should I create separate PRs? Your choice, it doesn't really mater. And send patches for all the rest! Thanks a lot!

gitea-mirror commented

2026-05-05 09:09:56 -06:00

Author

Owner

@Tomin1 commented on GitHub (Mar 4, 2021):

That would leave two patches that I guess are not that useful for most firejail users since they are very Sailfish OS specific.

Just to be clear, I don't intend to upstream these two. Everything else is already there.

@Tomin1 commented on GitHub (Mar 4, 2021): > That would leave two patches that I guess are not that useful for most firejail users since they are very Sailfish OS specific. Just to be clear, I don't intend to upstream these two. Everything else is already there.

gitea-mirror commented

2026-05-05 09:09:56 -06:00

Author

Owner

@rusty-snake commented on GitHub (Jul 6, 2021):

Can we close here?

@rusty-snake commented on GitHub (Jul 6, 2021): Can we close here?

gitea-mirror referenced this issue

2026-05-05 10:18:20 -06:00

[PR #2478] [MERGED] Remove double entree from bsdtar.profile #4344

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#2478

No description provided.

Rows
Columns