github-starred/firejail
2
0
Fork 0
mirror of https://github.com/netblue30/firejail.git synced 2026-05-15 14:16:14 -06:00
Code Issues 531 Projects Packages Wiki Activity Actions 6

[GH-ISSUE #3865] obs: program does not start #2433

New issue
Closed
opened 2026-05-05 09:06:28 -06:00 by gitea-mirror · 14 comments
gitea-mirror commented 2026-05-05 09:06:28 -06:00
Owner
Copy link

Originally created by @energrizer-9032 on GitHub (Jan 2, 2021).
Original GitHub issue: https://github.com/netblue30/firejail/issues/3865

I replaced my desktop shortcut of obs studio by running command firecfg .
obs studio is not even showing up.(it shows in htop )
Please help me

Originally created by @energrizer-9032 on GitHub (Jan 2, 2021). Original GitHub issue: https://github.com/netblue30/firejail/issues/3865 I replaced my desktop shortcut of obs studio by running command `firecfg` . obs studio is not even showing up.(it shows in htop ) Please help me
gitea-mirror 2026-05-05 09:06:28 -06:00
gitea-mirror commented 2026-05-05 09:06:31 -06:00
Author
Owner
Copy link

@rusty-snake commented on GitHub (Jan 2, 2021):

Which firejail version do you use? What distro are you on? Are there any errors in the terminal or in the syslog if you run firejail /usr/bin/obs? Does firejail --noprofile /usr/bin/obs work? Has you made any custom overrides in ~/.config/firejail?

<!-- gh-comment-id:753504267 --> @rusty-snake commented on GitHub (Jan 2, 2021): Which firejail version do you use? What distro are you on? Are there any errors in the terminal or in the syslog if you run `firejail /usr/bin/obs`? Does `firejail --noprofile /usr/bin/obs` work? Has you made any custom overrides in `~/.config/firejail`?
gitea-mirror commented 2026-05-05 09:06:31 -06:00
Author
Owner
Copy link

@energrizer-9032 commented on GitHub (Jan 3, 2021):

Firejail 0.9.64-2. I am on Manjaro. As far as I know there are no errors. yes firejail --noprofile /usr/bin/obs does work. No custom overrides in config file

<!-- gh-comment-id:753557375 --> @energrizer-9032 commented on GitHub (Jan 3, 2021): Firejail 0.9.64-2. I am on Manjaro. As far as I know there are no errors. yes ` firejail --noprofile /usr/bin/obs` does work. No custom overrides in config file
gitea-mirror commented 2026-05-05 09:06:33 -06:00
Author
Owner
Copy link

@rusty-snake commented on GitHub (Jan 4, 2021):

That's good and bad. Bad: no error message means we have no hint what could go wrong. Good: because --noprofile works, this can be solved by adopting obs.profile.

Can you copy obs.profile to your home and the use firejail --profile=./ob.profile /usr/bin/obs to start. Then you comment ~/.obs.profile and start uncommenting it line for line.

<!-- gh-comment-id:753931820 --> @rusty-snake commented on GitHub (Jan 4, 2021): That's good and bad. Bad: no error message means we have no hint what could go wrong. Good: because --noprofile works, this can be solved by adopting obs.profile. Can you copy obs.profile to your home and the use `firejail --profile=./ob.profile /usr/bin/obs` to start. Then you comment ~/.obs.profile and start uncommenting it line for line.
gitea-mirror commented 2026-05-05 09:06:34 -06:00
Author
Owner
Copy link

@X6B commented on GitHub (Jan 5, 2021):

Add: seccomp !kcmp to your local profile.

<!-- gh-comment-id:754582919 --> @X6B commented on GitHub (Jan 5, 2021): Add: `seccomp !kcmp` to your local profile.
gitea-mirror commented 2026-05-05 09:06:35 -06:00
Author
Owner
Copy link

@kmk3 commented on GitHub (Jan 5, 2021):

Add: seccomp !kcmp to your local profile.

In that case, the cause is likely the same as #3219.

What's the gpu vendor/driver?

glxinfo | grep '^OpenGL vendor'
glxinfo | grep '^OpenGL version'
<!-- gh-comment-id:754862541 --> @kmk3 commented on GitHub (Jan 5, 2021): > Add: `seccomp !kcmp` to your local profile. In that case, the cause is likely the same as #3219. What's the gpu vendor/driver? ```sh glxinfo | grep '^OpenGL vendor' glxinfo | grep '^OpenGL version' ```
gitea-mirror commented 2026-05-05 09:06:36 -06:00
Author
Owner
Copy link

@X6B commented on GitHub (Jan 6, 2021):

In my case: Archlinux & AMD OpenGL version string: 4.6 (Compatibility Profile) Mesa 20.3.2.

<!-- gh-comment-id:755275881 --> @X6B commented on GitHub (Jan 6, 2021): In my case: Archlinux & AMD OpenGL version string: 4.6 (Compatibility Profile) Mesa 20.3.2.
gitea-mirror commented 2026-05-05 09:06:38 -06:00
Author
Owner
Copy link

@kmk3 commented on GitHub (Jan 6, 2021):

In my case: Archlinux & AMD OpenGL version string: 4.6 (Compatibility
Profile) Mesa 20.3.2.

Then it's probably #3219 indeed.

@energrizer-9032 Does https://github.com/netblue30/firejail/issues/3865#issuecomment-754582919 solve it for you?

If not, does
https://github.com/netblue30/firejail/blob/6d952144bd5049a95ea1799648ed4a3ee5ad1e76/etc/templates/syscalls.txt#L89
give any results?

<!-- gh-comment-id:755735912 --> @kmk3 commented on GitHub (Jan 6, 2021): > In my case: Archlinux & AMD OpenGL version string: 4.6 (Compatibility > Profile) Mesa 20.3.2. Then it's probably #3219 indeed. @energrizer-9032 Does <https://github.com/netblue30/firejail/issues/3865#issuecomment-754582919> solve it for you? If not, does <https://github.com/netblue30/firejail/blob/6d952144bd5049a95ea1799648ed4a3ee5ad1e76/etc/templates/syscalls.txt#L89> give any results?
gitea-mirror commented 2026-05-05 09:06:39 -06:00
Author
Owner
Copy link

@rusty-snake commented on GitHub (Jan 6, 2021):

Since firejail 0.9.64 you need to use firejail --seccomp-error-action=kill … to get audit events.

<!-- gh-comment-id:755743204 --> @rusty-snake commented on GitHub (Jan 6, 2021): Since firejail 0.9.64 you need to use `firejail --seccomp-error-action=kill …` to get audit events.
gitea-mirror commented 2026-05-05 09:06:39 -06:00
Author
Owner
Copy link

@kmk3 commented on GitHub (Jan 6, 2021):

Since firejail 0.9.64 you need to use firejail --seccomp-error-action=kill … to get audit events.

It has always appeared on /var/log/kernel.log on Artix for me, using the
default firejail.config (which seems to use EPERM).

I just tested it again on 0.9.64 to confirm, by forcing the keepassxc violation
from #3760.

The way I understand it is that whenever there's a seccomp violation, the
kernel itself writes directly to the kernel log, regardless of the options.

<!-- gh-comment-id:755763974 --> @kmk3 commented on GitHub (Jan 6, 2021): > Since firejail 0.9.64 you need to use `firejail --seccomp-error-action=kill > …` to get audit events. It has always appeared on /var/log/kernel.log on Artix for me, using the default firejail.config (which seems to use EPERM). I just tested it again on 0.9.64 to confirm, by forcing the keepassxc violation from #3760. The way I understand it is that whenever there's a seccomp violation, the kernel itself writes directly to the kernel log, regardless of the options.
gitea-mirror commented 2026-05-05 09:06:40 -06:00
Author
Owner
Copy link

@rusty-snake commented on GitHub (Jan 7, 2021):

Fedora 32; Firejail 0.9.65 (d5824f1); Linux 5.9.16-100.fc32.x86_64

#include <unistd.h>
#include <string.h>

int main() {
        char hello[] = "Hello";
        write(1, &hello, strlen(hello));
}

gcc -o w w.c
journalctl --boot --pager-end --follow

$ firejail --noprofile --shell=none ./w
Parent pid 139271, child pid 139272
Child process initialized in 32.74 ms
Hello
Parent is shutting down, bye...
$ firejail --noprofile --shell=none --seccomp.drop=write ./w
Seccomp list in: write, check list: @default-keep, prelist: write,
Parent pid 139282, child pid 139283
Seccomp list in: write, check list: @default-keep, prelist: write,
Child process initialized in 39.68 ms

Parent is shutting down, bye...
* no audit in syslog
$ firejail --noprofile --shell=none --seccomp.drop=write --seccomp-error-action=kill ./w
Seccomp list in: write, check list: @default-keep, prelist: write,
Parent pid 139332, child pid 139333
Seccomp list in: write, check list: @default-keep, prelist: write,
Child process initialized in 42.45 ms

Parent is shutting down, bye...
zsh: exit 255   firejail --noprofile --shell=none --seccomp.drop=write  ./w
* new audit in syslog
<!-- gh-comment-id:755975049 --> @rusty-snake commented on GitHub (Jan 7, 2021): Fedora 32; Firejail 0.9.65 (d5824f1); Linux 5.9.16-100.fc32.x86_64 ```c #include <unistd.h> #include <string.h> int main() { char hello[] = "Hello"; write(1, &hello, strlen(hello)); } ``` `gcc -o w w.c` `journalctl --boot --pager-end --follow` ``` $ firejail --noprofile --shell=none ./w Parent pid 139271, child pid 139272 Child process initialized in 32.74 ms Hello Parent is shutting down, bye... $ firejail --noprofile --shell=none --seccomp.drop=write ./w Seccomp list in: write, check list: @default-keep, prelist: write, Parent pid 139282, child pid 139283 Seccomp list in: write, check list: @default-keep, prelist: write, Child process initialized in 39.68 ms Parent is shutting down, bye... * no audit in syslog $ firejail --noprofile --shell=none --seccomp.drop=write --seccomp-error-action=kill ./w Seccomp list in: write, check list: @default-keep, prelist: write, Parent pid 139332, child pid 139333 Seccomp list in: write, check list: @default-keep, prelist: write, Child process initialized in 42.45 ms Parent is shutting down, bye... zsh: exit 255 firejail --noprofile --shell=none --seccomp.drop=write ./w * new audit in syslog ```
gitea-mirror commented 2026-05-05 09:06:40 -06:00
Author
Owner
Copy link

@X6B commented on GitHub (Jan 7, 2021):

What is not working is the virtual camera feature added some releases ago: https://github.com/obsproject/obs-studio/issues/3845

Even firejail --noprofile obs does not work on Archlinux. That feature only works deleting the obs symlink created by firecfg.

<!-- gh-comment-id:756197453 --> @X6B commented on GitHub (Jan 7, 2021): What is not working is the virtual camera feature added some releases ago: https://github.com/obsproject/obs-studio/issues/3845 Even `firejail --noprofile obs` does not work on Archlinux. That feature only works deleting the obs symlink created by firecfg.
gitea-mirror commented 2026-05-05 09:06:41 -06:00
Author
Owner
Copy link

@kmk3 commented on GitHub (Jan 7, 2021):

@rusty-snake Alright, same results here.

Well, the only times I remember having seccomp issues were with keepassxc and
steam.

And strangely enough, these do not log:

$ firejail --seccomp.drop=@basic-io keepassxc; echo $?
Reading profile /etc/firejail/keepassxc.profile
Reading profile /etc/firejail/keepassxc.local
Reading profile /etc/firejail/disable-dbus.inc.local
Reading profile /etc/firejail/disable-common.inc
Reading profile /etc/firejail/disable-common.local
Reading profile /etc/firejail/disable-devel.inc
Reading profile /etc/firejail/disable-exec.inc
Reading profile /etc/firejail/disable-interpreters.inc
Reading profile /etc/firejail/disable-passwdmgr.inc
Reading profile /etc/firejail/disable-programs.inc
Reading profile /etc/firejail/disable-shell.inc
Reading profile /etc/firejail/disable-xdg.inc
Reading profile /etc/firejail/whitelist-usr-share-common.inc
Reading profile /etc/firejail/whitelist-var-common.inc
Seccomp list in: !name_to_handle_at, check list: @default-keep, prelist: unknown,
Seccomp list in: @basic-io, check list: @default-keep, prelist: close,dup,dup2,dup3,lseek,pread64,preadv,preadv2,pwrite64,pwritev,pwritev2,read,readv,write,writev,
Parent pid 2177, child pid 2178
3 programs installed in 54.39 ms
Warning: skipping alternatives for private /etc
Private /etc installed in 9.12 ms
Warning: skipping alternatives for private /usr/etc
Warning: skipping fonts for private /usr/etc
Warning: skipping ld.so.cache for private /usr/etc
Warning: skipping machine-id for private /usr/etc
Private /usr/etc installed in 0.15 ms
Warning: /sbin directory link was not blacklisted
Warning: /usr/sbin directory link was not blacklisted
Blacklist violations are logged to syslog
Seccomp list in: @basic-io, check list: @default-keep, prelist: close,dup,dup2,dup3,lseek,pread64,preadv,preadv2,pwrite64,pwritev,pwritev2,read,readv,write,writev,
Child process initialized in 222.41 ms

Parent is shutting down, bye...
127

(this works; not sure what to do to force it to fail)

$ firejail --seccomp.drop=@basic-io steam; echo $?
[...]

Parent is shutting down, bye...
0

But these always do:

$ firejail --ignore='seccomp !name_to_handle_at' keepassxc; echo $?
Reading profile /etc/firejail/keepassxc.profile
Reading profile /etc/firejail/keepassxc.local
Reading profile /etc/firejail/disable-dbus.inc.local
Reading profile /etc/firejail/disable-common.inc
Reading profile /etc/firejail/disable-common.local
Reading profile /etc/firejail/disable-devel.inc
Reading profile /etc/firejail/disable-exec.inc
Reading profile /etc/firejail/disable-interpreters.inc
Reading profile /etc/firejail/disable-passwdmgr.inc
Reading profile /etc/firejail/disable-programs.inc
Reading profile /etc/firejail/disable-shell.inc
Reading profile /etc/firejail/disable-xdg.inc
Reading profile /etc/firejail/whitelist-usr-share-common.inc
Reading profile /etc/firejail/whitelist-var-common.inc
Parent pid 13423, child pid 13424
3 programs installed in 54.51 ms
Warning: skipping alternatives for private /etc
Private /etc installed in 9.15 ms
Warning: skipping alternatives for private /usr/etc
Warning: skipping fonts for private /usr/etc
Warning: skipping ld.so.cache for private /usr/etc
Warning: skipping machine-id for private /usr/etc
Private /usr/etc installed in 0.22 ms
Warning: /sbin directory link was not blacklisted
Warning: /usr/sbin directory link was not blacklisted
Blacklist violations are logged to syslog
Child process initialized in 230.26 ms
# (hangs)
^C
Parent received signal 2, shutting down the child process...

Child received signal 2, shutting down the sandbox...

Parent is shutting down, bye...
2

$ firejail --ignore='seccomp.drop' steam; echo $?
[...]
# (hangs)
^C
Parent received signal 2, shutting down the child process...

Child received signal 2, shutting down the sandbox...

Parent is shutting down, bye...
2

The seccomp.drop line is this (from https://github.com/netblue30/firejail/issues/3267#issuecomment-596184708):

seccomp.drop @clock,@cpu-emulation,@debug,@module,@obsolete,@raw-io,@reboot,@swap,open_by_handle_at,name_to_handle_at,ioprio_set,ni_syscall,syslog,fanotify_init,add_key,request_key,mbind,migrate_pages,move_pages,keyctl,io_setup,io_destroy,io_getevents,io_submit,io_cancel,remap_file_pages,set_mempolicyvmsplice,umount,userfaultfd,acct,bpf,chroot,mount,nfsservctl,pivot_root,setdomainname,sethostname,umount2,vhangup

Maybe it only happens with GUI programs or with specific syscalls?

<!-- gh-comment-id:756292159 --> @kmk3 commented on GitHub (Jan 7, 2021): @rusty-snake Alright, same results here. Well, the only times I remember having seccomp issues were with keepassxc and steam. And strangely enough, these do not log: ```console $ firejail --seccomp.drop=@basic-io keepassxc; echo $? Reading profile /etc/firejail/keepassxc.profile Reading profile /etc/firejail/keepassxc.local Reading profile /etc/firejail/disable-dbus.inc.local Reading profile /etc/firejail/disable-common.inc Reading profile /etc/firejail/disable-common.local Reading profile /etc/firejail/disable-devel.inc Reading profile /etc/firejail/disable-exec.inc Reading profile /etc/firejail/disable-interpreters.inc Reading profile /etc/firejail/disable-passwdmgr.inc Reading profile /etc/firejail/disable-programs.inc Reading profile /etc/firejail/disable-shell.inc Reading profile /etc/firejail/disable-xdg.inc Reading profile /etc/firejail/whitelist-usr-share-common.inc Reading profile /etc/firejail/whitelist-var-common.inc Seccomp list in: !name_to_handle_at, check list: @default-keep, prelist: unknown, Seccomp list in: @basic-io, check list: @default-keep, prelist: close,dup,dup2,dup3,lseek,pread64,preadv,preadv2,pwrite64,pwritev,pwritev2,read,readv,write,writev, Parent pid 2177, child pid 2178 3 programs installed in 54.39 ms Warning: skipping alternatives for private /etc Private /etc installed in 9.12 ms Warning: skipping alternatives for private /usr/etc Warning: skipping fonts for private /usr/etc Warning: skipping ld.so.cache for private /usr/etc Warning: skipping machine-id for private /usr/etc Private /usr/etc installed in 0.15 ms Warning: /sbin directory link was not blacklisted Warning: /usr/sbin directory link was not blacklisted Blacklist violations are logged to syslog Seccomp list in: @basic-io, check list: @default-keep, prelist: close,dup,dup2,dup3,lseek,pread64,preadv,preadv2,pwrite64,pwritev,pwritev2,read,readv,write,writev, Child process initialized in 222.41 ms Parent is shutting down, bye... 127 ``` (this works; not sure what to do to force it to fail) ```console $ firejail --seccomp.drop=@basic-io steam; echo $? [...] Parent is shutting down, bye... 0 ``` But these always do: ```console $ firejail --ignore='seccomp !name_to_handle_at' keepassxc; echo $? Reading profile /etc/firejail/keepassxc.profile Reading profile /etc/firejail/keepassxc.local Reading profile /etc/firejail/disable-dbus.inc.local Reading profile /etc/firejail/disable-common.inc Reading profile /etc/firejail/disable-common.local Reading profile /etc/firejail/disable-devel.inc Reading profile /etc/firejail/disable-exec.inc Reading profile /etc/firejail/disable-interpreters.inc Reading profile /etc/firejail/disable-passwdmgr.inc Reading profile /etc/firejail/disable-programs.inc Reading profile /etc/firejail/disable-shell.inc Reading profile /etc/firejail/disable-xdg.inc Reading profile /etc/firejail/whitelist-usr-share-common.inc Reading profile /etc/firejail/whitelist-var-common.inc Parent pid 13423, child pid 13424 3 programs installed in 54.51 ms Warning: skipping alternatives for private /etc Private /etc installed in 9.15 ms Warning: skipping alternatives for private /usr/etc Warning: skipping fonts for private /usr/etc Warning: skipping ld.so.cache for private /usr/etc Warning: skipping machine-id for private /usr/etc Private /usr/etc installed in 0.22 ms Warning: /sbin directory link was not blacklisted Warning: /usr/sbin directory link was not blacklisted Blacklist violations are logged to syslog Child process initialized in 230.26 ms # (hangs) ^C Parent received signal 2, shutting down the child process... Child received signal 2, shutting down the sandbox... Parent is shutting down, bye... 2 ``` ```console $ firejail --ignore='seccomp.drop' steam; echo $? [...] # (hangs) ^C Parent received signal 2, shutting down the child process... Child received signal 2, shutting down the sandbox... Parent is shutting down, bye... 2 ``` The seccomp.drop line is this (from <https://github.com/netblue30/firejail/issues/3267#issuecomment-596184708>): `seccomp.drop @clock,@cpu-emulation,@debug,@module,@obsolete,@raw-io,@reboot,@swap,open_by_handle_at,name_to_handle_at,ioprio_set,ni_syscall,syslog,fanotify_init,add_key,request_key,mbind,migrate_pages,move_pages,keyctl,io_setup,io_destroy,io_getevents,io_submit,io_cancel,remap_file_pages,set_mempolicyvmsplice,umount,userfaultfd,acct,bpf,chroot,mount,nfsservctl,pivot_root,setdomainname,sethostname,umount2,vhangup` Maybe it only happens with GUI programs or with specific syscalls?
gitea-mirror commented 2026-05-05 09:06:41 -06:00
Author
Owner
Copy link

@rusty-snake commented on GitHub (Jan 8, 2021):

Best (for debugging): firejail --noprofile --shell=none --seccomp.drop=write --seccomp-error-action=log ./w

<!-- gh-comment-id:756776720 --> @rusty-snake commented on GitHub (Jan 8, 2021): Best (for debugging): `firejail --noprofile --shell=none --seccomp.drop=write --seccomp-error-action=log ./w`
gitea-mirror commented 2026-05-05 09:06:41 -06:00
Author
Owner
Copy link

@rusty-snake commented on GitHub (Mar 8, 2021):

I'm closing here due to inactivity, please fell free to request to reopen if you still have this issue.

<!-- gh-comment-id:793001837 --> @rusty-snake commented on GitHub (Mar 8, 2021): I'm closing here due to inactivity, please fell free to request to reopen if you still have this issue.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
serialize_remounts_v2
landlock_v4
landlock
release-0.9.64
release-0.9.62
gitlab_ci
LTSbase
fred_ctests
docs
0.9.80
0.9.80-rc1
0.9.78
0.9.76
0.9.76-rc4
0.9.76-rc3
0.9.76-rc2
0.9.76-rc1
0.9.74
landlock-split
0.9.72
0.9.72rc1
0.9.70
0.9.68
0.9.68rc1
0.9.66
0.9.66rc1
0.9.64.4
0.9.64.2
0.9.64
0.9.64rc1
0.9.62.4
0.9.62.2
0.9.62
0.9.56.2-LTS
0.9.60
0.9.60-rc1
0.9.58.2
0.9.58
0.9.58-rc1
0.9.56-LTS-release
0.9.56-LTS
0.9.56
0.9.56-rc1
0.9.54
0.9.54-rc2
0.9.54-rc1
0.9.52
0.9.38.12
0.9.50
0.9.50-rc1
0.9.48
0.9.46
0.9.46-rc1
0.9.44.10
0.9.44.8
0.9.44.6
0.9.38.10
0.9.44.4
0.9.38.8
0.9.44.2
0.9.44
0.9.44-rc1
0.9.38.4
0.9.42
0.9.42-rc2
0.9.38.2
0.9.42-rc1
disable-globalcfg
0.9.40
0.9.40-rc1
0.9.38
0.9.38-rc1
0.9.36
0.9.36-rc1
0.9.34
0.9.34-rc1
0.9.32
0.9.32-rc1
0.9.30
0.9.30-rc1
Labels
Clear labels   
LTS merge

   
LTS merge

   
bug

   
bug

   
converted-to-discussion

   
doc-todo

   
documentation

   
duplicate

   
enhancement

   
file-transfer

   
firecfg

   
firejail-in-firejail

   
firetools

   
graphics

   
help wanted

   
information_old

   
installation

   
invalid

   
modif

   
moved

   
needinfo

   
networking

   
notabug

   
notourbug

   
old-version

   
overlayfs

   
packaging

   
profile-request

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
question_old

   
removal

   
runtime-permissions

   
sandbox-ipc

   
security

   
stale

   
wiki

   
wiki

   
wontfix

   
wordpress

   
workaround
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#2433
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?