[GH-ISSUE #3712] 'make test' errors on tests not included in release tarball #2335

New issue

Closed

opened 2026-05-05 09:01:22 -06:00 by gitea-mirror · 2 comments

gitea-mirror commented

2026-05-05 09:01:22 -06:00

Owner

Originally created by @hlein on GitHub (Oct 31, 2020).
Original GitHub issue: https://github.com/netblue30/firejail/issues/3712

Bug and expected behavior

make test produces some errors because Makefile.in's default test target includes test-private-lib and test-fnetfilter; the release tarball has no such subdirectories under test/.
Those are present in the git repo, but not in the release tarballs; Makefile.in's DISTFILES_TEST= enumerates test/ dirs to package, excluding those two.
The right/expected behavior would be some combination of 1) including more test/ subdirs in release tarballs, 2) pruning the list of test-* targets included in the default test: target in Makefile.in, 3) checking for the presence of, and gracefully handling the lack of, individual test/ subdirs.

Reproduce
Steps to reproduce the behavior:

unpack tarball such as firejail-0.9.64.tar.xz
configure and compile
run make test
Errors such as:

cd test/private-lib; ./private-lib.sh | grep TESTING
...
/bin/sh: line 0: cd: test/private-lib: No such file or directory
/bin/sh: ./private-lib.sh: No such file or directory
...
cd test/fnetfilter; ./fnetfilter.sh | grep TESTING
...
/bin/sh: line 0: cd: test/fnetfilter: No such file or directory
/bin/sh: ./fnetfilter.sh: No such file or directory
...
make: *** [Makefile:232: test-private-lib] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Makefile:265: test-fnetfilter] Error 1

Environment

Gentoo Linux
firejail-0.9.64

Originally created by @hlein on GitHub (Oct 31, 2020). Original GitHub issue: https://github.com/netblue30/firejail/issues/3712 **Bug and expected behavior** - `make test` produces some errors because `Makefile.in`'s default `test` target includes `test-private-lib` and `test-fnetfilter`; the release tarball has no such subdirectories under `test/`. - Those are present in the git repo, but not in the release tarballs; `Makefile.in`'s `DISTFILES_TEST=` enumerates `test/` dirs to package, excluding those two. - The right/expected behavior would be some combination of 1) including more `test/` subdirs in release tarballs, 2) pruning the list of `test-*` targets included in the default `test:` target in `Makefile.in`, 3) checking for the presence of, and gracefully handling the lack of, individual `test/` subdirs. **Reproduce** Steps to reproduce the behavior: 1. unpack tarball such as `firejail-0.9.64.tar.xz` 2. configure and compile 3. run `make test` 4. Errors such as: ``` cd test/private-lib; ./private-lib.sh | grep TESTING ... /bin/sh: line 0: cd: test/private-lib: No such file or directory /bin/sh: ./private-lib.sh: No such file or directory ... cd test/fnetfilter; ./fnetfilter.sh | grep TESTING ... /bin/sh: line 0: cd: test/fnetfilter: No such file or directory /bin/sh: ./fnetfilter.sh: No such file or directory ... make: *** [Makefile:232: test-private-lib] Error 1 make: *** Waiting for unfinished jobs.... make: *** [Makefile:265: test-fnetfilter] Error 1 ``` **Environment** - Gentoo Linux - firejail-0.9.64

gitea-mirror

2026-05-05 09:01:22 -06:00

closed this issue
added the
bug
label

gitea-mirror commented

2026-05-05 09:01:25 -06:00

Author

Owner

@netblue30 commented on GitHub (Nov 1, 2020):

Thanks for the bug, should be fixed now.

@netblue30 commented on GitHub (Nov 1, 2020): Thanks for the bug, should be fixed now.

gitea-mirror commented

2026-05-05 09:01:26 -06:00

Author

Owner

@hlein commented on GitHub (Nov 1, 2020):

Awesome, thanks!

@hlein commented on GitHub (Nov 1, 2020): Awesome, thanks!

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#2335

No description provided.

Rows
Columns