mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[GH-ISSUE #3515] [Reminder] Add xdg-dbus-proxy as dependency on next release #2213
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#2213
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Jul 16, 2020).
Original GitHub issue: https://github.com/netblue30/firejail/issues/3515
The recently introduced D-Bus filtering options rely on
xdg-dbus-proxybeing installed. Although the warning is very clear when it isn't, we should inform/remind distro packagers of this and advise to add that package as a dependency.UPDATE: I asked the maintainer of the AUR firejail-git package to act accordingly.
@reinerh commented on GitHub (Jul 17, 2020):
Thanks for thinking about this!
I would hope that package maintainers are also reading the RELNOTES (where it's already mentioned). 😁
@ghost commented on GitHub (Jul 17, 2020):
Heh, true. RELNOTES can become rather long to sift true though and we're all fallible. As the D-Bus filtering is an important change (adding a dependency with a fallback that allows access) I even considered doing something in Makefile to stop the build when xdg-dbus-proxy isn't found. But that might be overkill... Perhaps we can move the item on D-Bus sandboxing to the very top of the RELNOTES when the next release gets cut.
@reinerh commented on GitHub (Jul 17, 2020):
I agree that a build-time check would be a bit overkill.
I think a hard dependency is a bit too much, so I intend to only add it as a Recommendation in the Debian package, as firejail is still usable without it, and users might prefer to keep it uninstalled
@ghost commented on GitHub (Jul 17, 2020):
@reinerh As I'm running both Arch Linux and Debian/Ubuntu I did notice the differences qua packaging on these distros. Sounds very reasonable to add it as Recommends on Debian. I expect lots of reports on our issue-trackers once the D-Bus sandboxing gets out there. Nothing much we can do but 'wait and see' I guess.
@netblue30 commented on GitHub (Oct 1, 2020):
The check is at run-time - we print a warning if the xdg-dbus-proxy is not in /usr/bin. There were some small fixes here and there, and also a fix in firetools GUI, I think we are ready to go!
@rusty-snake commented on GitHub (Oct 23, 2020):
@odubaj a few recommendations for the fedora package:
Requires: xdg-dbus-proxyorRecommends: xdg-dbus-proxy(depending on exact packaging-guidelines)--enable-selinuxto %configure (which needsBuildRequires: libselinux-devel)As a reference, my build script: https://gist.github.com/rusty-snake/95e40fb9449b6b36c8371d77e7048683
@odubaj commented on GitHub (Oct 23, 2020):
Added, thanks!