[GH-ISSUE #3515] [Reminder] Add xdg-dbus-proxy as dependency on next release #2213

Closed
opened 2026-05-05 08:53:57 -06:00 by gitea-mirror · 7 comments
Owner

Originally created by @ghost on GitHub (Jul 16, 2020).
Original GitHub issue: https://github.com/netblue30/firejail/issues/3515

$ pacman -Q firejail
firejail-git 0.9.63.r6272.ce462b6b-1

$ seahorse-tool --import foo.asc
Warning: /usr/bin/xdg-dbus-proxy was not found, downgrading dbus-user policy to allow.
To enable DBus filtering, install the xdg-dbus-proxy program.
Ignoring "dbus-user.own org.gnome.seahorse.Application" and 1 other dbus-user filter rule.

The recently introduced D-Bus filtering options rely on xdg-dbus-proxy being installed. Although the warning is very clear when it isn't, we should inform/remind distro packagers of this and advise to add that package as a dependency.

UPDATE: I asked the maintainer of the AUR firejail-git package to act accordingly.

Originally created by @ghost on GitHub (Jul 16, 2020). Original GitHub issue: https://github.com/netblue30/firejail/issues/3515 ``` $ pacman -Q firejail firejail-git 0.9.63.r6272.ce462b6b-1 $ seahorse-tool --import foo.asc Warning: /usr/bin/xdg-dbus-proxy was not found, downgrading dbus-user policy to allow. To enable DBus filtering, install the xdg-dbus-proxy program. Ignoring "dbus-user.own org.gnome.seahorse.Application" and 1 other dbus-user filter rule. ``` The recently introduced D-Bus filtering options rely on `xdg-dbus-proxy` being installed. Although the warning is very clear when it isn't, we should inform/remind distro packagers of this and advise to add that package as a dependency. UPDATE: I asked the maintainer of the AUR [firejail-git](https://aur.archlinux.org/packages/firejail-git/) package to act accordingly.
gitea-mirror 2026-05-05 08:53:57 -06:00
  • closed this issue
  • added the
    packaging
    label
Author
Owner

@reinerh commented on GitHub (Jul 17, 2020):

Thanks for thinking about this!

I would hope that package maintainers are also reading the RELNOTES (where it's already mentioned). 😁

<!-- gh-comment-id:660369291 --> @reinerh commented on GitHub (Jul 17, 2020): Thanks for thinking about this! I would hope that package maintainers are also reading the RELNOTES (where it's already mentioned). :grin:
Author
Owner

@ghost commented on GitHub (Jul 17, 2020):

I would hope that package maintainers are also reading the RELNOTES (where it's already mentioned).

Heh, true. RELNOTES can become rather long to sift true though and we're all fallible. As the D-Bus filtering is an important change (adding a dependency with a fallback that allows access) I even considered doing something in Makefile to stop the build when xdg-dbus-proxy isn't found. But that might be overkill... Perhaps we can move the item on D-Bus sandboxing to the very top of the RELNOTES when the next release gets cut.

<!-- gh-comment-id:660377269 --> @ghost commented on GitHub (Jul 17, 2020): > I would hope that package maintainers are also reading the RELNOTES (where it's already mentioned). Heh, true. RELNOTES can become rather long to sift true though and we're all fallible. As the D-Bus filtering is an important change (adding a dependency with a fallback that allows access) I even considered doing something in Makefile to stop the build when xdg-dbus-proxy isn't found. But that might be overkill... Perhaps we can move the item on D-Bus sandboxing to the very top of the RELNOTES when the next release gets cut.
Author
Owner

@reinerh commented on GitHub (Jul 17, 2020):

I agree that a build-time check would be a bit overkill.
I think a hard dependency is a bit too much, so I intend to only add it as a Recommendation in the Debian package, as firejail is still usable without it, and users might prefer to keep it uninstalled

<!-- gh-comment-id:660378537 --> @reinerh commented on GitHub (Jul 17, 2020): I agree that a build-time check would be a bit overkill. I think a hard dependency is a bit too much, so I intend to only add it as a Recommendation in the Debian package, as firejail is still usable without it, and users might prefer to keep it uninstalled
Author
Owner

@ghost commented on GitHub (Jul 17, 2020):

@reinerh As I'm running both Arch Linux and Debian/Ubuntu I did notice the differences qua packaging on these distros. Sounds very reasonable to add it as Recommends on Debian. I expect lots of reports on our issue-trackers once the D-Bus sandboxing gets out there. Nothing much we can do but 'wait and see' I guess.

<!-- gh-comment-id:660383334 --> @ghost commented on GitHub (Jul 17, 2020): @reinerh As I'm running both Arch Linux and Debian/Ubuntu I did notice the differences qua packaging on these distros. Sounds very reasonable to add it as Recommends on Debian. I expect lots of reports on our issue-trackers once the D-Bus sandboxing gets out there. Nothing much we can do but 'wait and see' I guess.
Author
Owner

@netblue30 commented on GitHub (Oct 1, 2020):

The check is at run-time - we print a warning if the xdg-dbus-proxy is not in /usr/bin. There were some small fixes here and there, and also a fix in firetools GUI, I think we are ready to go!

<!-- gh-comment-id:702081726 --> @netblue30 commented on GitHub (Oct 1, 2020): The check is at run-time - we print a warning if the xdg-dbus-proxy is not in /usr/bin. There were some small fixes here and there, and also a fix in firetools GUI, I think we are ready to go!
Author
Owner

@rusty-snake commented on GitHub (Oct 23, 2020):

@odubaj a few recommendations for the fedora package:

  1. add Requires: xdg-dbus-proxy or Recommends: xdg-dbus-proxy (depending on exact packaging-guidelines)
  2. add --enable-selinux to %configure (which needs BuildRequires: libselinux-devel)

As a reference, my build script: https://gist.github.com/rusty-snake/95e40fb9449b6b36c8371d77e7048683

<!-- gh-comment-id:715314723 --> @rusty-snake commented on GitHub (Oct 23, 2020): @odubaj a few recommendations for the fedora package: 1. add `Requires: xdg-dbus-proxy` or `Recommends: xdg-dbus-proxy` (depending on exact packaging-guidelines) 2. add `--enable-selinux` to %configure (which needs `BuildRequires: libselinux-devel`) As a reference, my build script: https://gist.github.com/rusty-snake/95e40fb9449b6b36c8371d77e7048683
Author
Owner

@odubaj commented on GitHub (Oct 23, 2020):

@odubaj a few recommendations for the fedora package:

1. add `Requires: xdg-dbus-proxy` or `Recommends: xdg-dbus-proxy` (depending on exact packaging-guidelines)

2. add `--enable-selinux` to %configure (which needs `BuildRequires: libselinux-devel`)

As a reference, my build script: https://gist.github.com/rusty-snake/95e40fb9449b6b36c8371d77e7048683

Added, thanks!

<!-- gh-comment-id:715320515 --> @odubaj commented on GitHub (Oct 23, 2020): > @odubaj a few recommendations for the fedora package: > > 1. add `Requires: xdg-dbus-proxy` or `Recommends: xdg-dbus-proxy` (depending on exact packaging-guidelines) > > 2. add `--enable-selinux` to %configure (which needs `BuildRequires: libselinux-devel`) > > > As a reference, my build script: https://gist.github.com/rusty-snake/95e40fb9449b6b36c8371d77e7048683 Added, thanks!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#2213
No description provided.