github-starred/firejail
2
0
Fork 0
mirror of https://github.com/netblue30/firejail.git synced 2026-05-15 14:16:14 -06:00
Code Issues 531 Projects Packages Wiki Activity Actions 6

[GH-ISSUE #3462] Installation fails if /etc/firejail/login.users exists #2176

New issue
Closed
opened 2026-05-05 08:51:23 -06:00 by gitea-mirror · 7 comments
gitea-mirror commented 2026-05-05 08:51:23 -06:00
Owner
Copy link

Originally created by @Fred-Barclay on GitHub (Jun 10, 2020).
Original GitHub issue: https://github.com/netblue30/firejail/issues/3462

Bug and expected behavior
When compiling from source from latest with ./configure --prefix=/usr && make && sudo make install-strip #or install the process errors with the message:

[ ! -f /etc/firejail/login.users ] && install -m 0644 etc/login.users /etc/firejail
make[1]: *** [Makefile:118: realinstall] Error 1
make[1]: Leaving directory '/home/fred/firejail'
make: *** [Makefile:156: install-strip] Error 2

I believe the issue started some point after 378d0e613a, possibly due to dae3933bc3 or the few commits following.

Relevant line seems to be 0b237315e6/Makefile.in (L125)

Not entirely sure why it gives up and dies, not super familiar with makefiles... 😕

Environment

$ sb_release -a
No LSB modules are available.
Distributor ID:	Linuxmint
Description:	LMDE 4 (debbie)
Release:	4
Codename:	debbie

$ cat /etc/debian_version 
10.2
Originally created by @Fred-Barclay on GitHub (Jun 10, 2020). Original GitHub issue: https://github.com/netblue30/firejail/issues/3462 **Bug and expected behavior** When compiling from source from latest with `./configure --prefix=/usr && make && sudo make install-strip #or install` the process errors with the message: ``` [ ! -f /etc/firejail/login.users ] && install -m 0644 etc/login.users /etc/firejail make[1]: *** [Makefile:118: realinstall] Error 1 make[1]: Leaving directory '/home/fred/firejail' make: *** [Makefile:156: install-strip] Error 2 ``` I believe the issue started some point after 378d0e613a915cc0d6d1138565abde2d253af69a, possibly due to dae3933bc30a08e355083b67ee99e688bfa13b4e or the few commits following. Relevant line seems to be https://github.com/netblue30/firejail/blob/0b237315e6f9fd98af093eda30ab6f555c2db96d/Makefile.in#L125 Not entirely sure why it gives up and dies, not super familiar with makefiles... :confused: **Environment** ``` $ sb_release -a No LSB modules are available. Distributor ID: Linuxmint Description: LMDE 4 (debbie) Release: 4 Codename: debbie $ cat /etc/debian_version 10.2 ```
gitea-mirror 2026-05-05 08:51:23 -06:00
  • closed this issue
  • added the
    bug
         label
gitea-mirror commented 2026-05-05 08:51:26 -06:00
Author
Owner
Copy link

@rusty-snake commented on GitHub (Jun 10, 2020):

can you try this:

[ ! -f $(DESTDIR)$(sysconfdir)/firejail/login.users ] && install -m 0644 etc/login.users $(DESTDIR)$(sysconfdir)/firejail/login.users
<!-- gh-comment-id:641875619 --> @rusty-snake commented on GitHub (Jun 10, 2020): can you try this: ``` [ ! -f $(DESTDIR)$(sysconfdir)/firejail/login.users ] && install -m 0644 etc/login.users $(DESTDIR)$(sysconfdir)/firejail/login.users ```
gitea-mirror commented 2026-05-05 08:51:27 -06:00
Author
Owner
Copy link

@Fred-Barclay commented on GitHub (Jun 10, 2020):

@rusty-snake no change :(

<!-- gh-comment-id:642098842 --> @Fred-Barclay commented on GitHub (Jun 10, 2020): @rusty-snake no change :(
gitea-mirror commented 2026-05-05 08:51:29 -06:00
Author
Owner
Copy link

@ghost commented on GitHub (Jun 10, 2020):

I noticed this too as stated in https://github.com/netblue30/firejail/pull/3450#issuecomment-639599715. At the moment, the only way I can reliably build from git master on Ubuntu is by reverting 52e24dbb3e and dae3933bc3. Can't explain why though...

<!-- gh-comment-id:642130240 --> @ghost commented on GitHub (Jun 10, 2020): I noticed this too as stated in https://github.com/netblue30/firejail/pull/3450#issuecomment-639599715. At the moment, the only way I can reliably build from git master **on Ubuntu** is by reverting https://github.com/netblue30/firejail/commit/52e24dbb3e89beca6d2f748eb3e5e49202270f03 and https://github.com/netblue30/firejail/commit/dae3933bc30a08e355083b67ee99e688bfa13b4e. Can't explain why though...
gitea-mirror commented 2026-05-05 08:51:30 -06:00
Author
Owner
Copy link

@rusty-snake commented on GitHub (Jun 10, 2020):

Then let's revert this changes completely, I will commit later.

sh -c "if [ ! -f $(DESTDIR)/$(sysconfdir)/firejail/login.users ]; then install -c -m 0644 etc/login.users $(DESTDIR)/$(sysconfdir)/firejail/.; fi;"

sh -c "if [ ! -d $(DESTDIR)/$(sysconfdir)/apparmor.d ]; then install -d -m 755 $(DESTDIR)/$(sysconfdir)/apparmor.d; fi;"

sh -c "if [ ! -d $(DESTDIR)/$(sysconfdir)/apparmor.d/local ]; then install -d -m 755 $(DESTDIR)/$(sysconfdir)/apparmor.d/local; fi;"

sh -c "if [ ! -f $(DESTDIR)/$(sysconfdir)/apparmor.d/local/firejail-local ]; then install -c -m 0644 etc/apparmor/firejail-local $(DESTDIR)/$(sysconfdir)/apparmor.d/local/.; fi;"
<!-- gh-comment-id:642205197 --> @rusty-snake commented on GitHub (Jun 10, 2020): Then let's revert this changes completely, I will commit later. ``` sh -c "if [ ! -f $(DESTDIR)/$(sysconfdir)/firejail/login.users ]; then install -c -m 0644 etc/login.users $(DESTDIR)/$(sysconfdir)/firejail/.; fi;" ``` ``` sh -c "if [ ! -d $(DESTDIR)/$(sysconfdir)/apparmor.d ]; then install -d -m 755 $(DESTDIR)/$(sysconfdir)/apparmor.d; fi;" ``` ``` sh -c "if [ ! -d $(DESTDIR)/$(sysconfdir)/apparmor.d/local ]; then install -d -m 755 $(DESTDIR)/$(sysconfdir)/apparmor.d/local; fi;" ``` ``` sh -c "if [ ! -f $(DESTDIR)/$(sysconfdir)/apparmor.d/local/firejail-local ]; then install -c -m 0644 etc/apparmor/firejail-local $(DESTDIR)/$(sysconfdir)/apparmor.d/local/.; fi;" ```
gitea-mirror commented 2026-05-05 08:51:30 -06:00
Author
Owner
Copy link

@rusty-snake commented on GitHub (Jun 11, 2020):

@Fred-Barclay @glitsj16 ^^

<!-- gh-comment-id:642913759 --> @rusty-snake commented on GitHub (Jun 11, 2020): @Fred-Barclay @glitsj16 ^^
gitea-mirror commented 2026-05-05 08:51:31 -06:00
Author
Owner
Copy link

@ghost commented on GitHub (Jun 11, 2020):

@rusty-snake For me this is fixed now on Ubuntu 16.04 LTS. Thanks!

<!-- gh-comment-id:642987307 --> @ghost commented on GitHub (Jun 11, 2020): @rusty-snake For me this is fixed now on Ubuntu 16.04 LTS. Thanks!
gitea-mirror commented 2026-05-05 08:51:32 -06:00
Author
Owner
Copy link

@Fred-Barclay commented on GitHub (Jun 12, 2020):

@rusty-snake I haven't been able to check on my Debian box but it seems good now on my Ubuntu 20.04 - thanks! 😄

<!-- gh-comment-id:642993787 --> @Fred-Barclay commented on GitHub (Jun 12, 2020): @rusty-snake I haven't been able to check on my Debian box but it seems good now on my Ubuntu 20.04 - thanks! 😄
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
serialize_remounts_v2
landlock_v4
landlock
release-0.9.64
release-0.9.62
gitlab_ci
LTSbase
fred_ctests
docs
0.9.80
0.9.80-rc1
0.9.78
0.9.76
0.9.76-rc4
0.9.76-rc3
0.9.76-rc2
0.9.76-rc1
0.9.74
landlock-split
0.9.72
0.9.72rc1
0.9.70
0.9.68
0.9.68rc1
0.9.66
0.9.66rc1
0.9.64.4
0.9.64.2
0.9.64
0.9.64rc1
0.9.62.4
0.9.62.2
0.9.62
0.9.56.2-LTS
0.9.60
0.9.60-rc1
0.9.58.2
0.9.58
0.9.58-rc1
0.9.56-LTS-release
0.9.56-LTS
0.9.56
0.9.56-rc1
0.9.54
0.9.54-rc2
0.9.54-rc1
0.9.52
0.9.38.12
0.9.50
0.9.50-rc1
0.9.48
0.9.46
0.9.46-rc1
0.9.44.10
0.9.44.8
0.9.44.6
0.9.38.10
0.9.44.4
0.9.38.8
0.9.44.2
0.9.44
0.9.44-rc1
0.9.38.4
0.9.42
0.9.42-rc2
0.9.38.2
0.9.42-rc1
disable-globalcfg
0.9.40
0.9.40-rc1
0.9.38
0.9.38-rc1
0.9.36
0.9.36-rc1
0.9.34
0.9.34-rc1
0.9.32
0.9.32-rc1
0.9.30
0.9.30-rc1
Labels
Clear labels   
LTS merge

   
LTS merge

   
bug

   
bug

   
converted-to-discussion

   
doc-todo

   
documentation

   
duplicate

   
enhancement

   
file-transfer

   
firecfg

   
firejail-in-firejail

   
firetools

   
graphics

   
help wanted

   
information_old

   
installation

   
invalid

   
modif

   
moved

   
needinfo

   
networking

   
notabug

   
notourbug

   
old-version

   
overlayfs

   
packaging

   
profile-request

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
question_old

   
removal

   
runtime-permissions

   
sandbox-ipc

   
security

   
stale

   
wiki

   
wiki

   
wontfix

   
wordpress

   
workaround
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#2176
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?