[GH-ISSUE #3393] seccomp filter are generated multible times #2131

Closed
opened 2026-05-05 08:48:45 -06:00 by gitea-mirror · 3 comments
Owner

Originally created by @rusty-snake on GitHub (May 2, 2020).
Original GitHub issue: https://github.com/netblue30/firejail/issues/3393

Describe the bug

The following block in the Makefile is called multiple times with make and make install.

8c69eab213/Makefile.in (L46-L58)

To Reproduce
Steps to reproduce the behavior:

  1. Add @echo HELLO I AM CALLED above
    8c69eab213/Makefile.in (L49)
  2. Run ./configure && make && make install
  3. See HELLO I AM CALLED around 12 times

Expected behavior
seccomp filter are just generated once

cc @topimiettinen

Originally created by @rusty-snake on GitHub (May 2, 2020). Original GitHub issue: https://github.com/netblue30/firejail/issues/3393 **Describe the bug** The following block in the Makefile is called multiple times with `make` and `make install`. https://github.com/netblue30/firejail/blob/8c69eab213556169ad5ea303e46fb0a80499b004/Makefile.in#L46-L58 **To Reproduce** Steps to reproduce the behavior: 1. Add `@echo HELLO I AM CALLED` above https://github.com/netblue30/firejail/blob/8c69eab213556169ad5ea303e46fb0a80499b004/Makefile.in#L49 2. Run `./configure && make && make install` 3. See `HELLO I AM CALLED` around 12 times **Expected behavior** seccomp filter are just generated once cc @topimiettinen
Author
Owner

@topimiettinen commented on GitHub (May 2, 2020):

To me the Makefile looks just fine. Probably it isn't a bug in Make either. Running make --debug=m shows that rules don't work as expected though.

<!-- gh-comment-id:623006133 --> @topimiettinen commented on GitHub (May 2, 2020): To me the Makefile looks just fine. Probably it isn't a bug in Make either. Running `make --debug=m` shows that rules don't work as expected though.
Author
Owner

@rusty-snake commented on GitHub (May 3, 2020):

To me the Makefile looks just fine.

I'm to a makefile expert, I don't see what's wrong, just that something is wrong.

<!-- gh-comment-id:623069384 --> @rusty-snake commented on GitHub (May 3, 2020): > To me the Makefile looks just fine. I'm to a makefile expert, I don't see what's wrong, just that something is wrong.
Author
Owner

@topimiettinen commented on GitHub (May 4, 2020):

I think the problem was with use of .PHONY.

<!-- gh-comment-id:623331197 --> @topimiettinen commented on GitHub (May 4, 2020): I think the problem was with use of .PHONY.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#2131
No description provided.