github-starred/firejail

Fork 0

mirror of https://github.com/netblue30/firejail.git synced 2026-05-15 14:16:14 -06:00

[GH-ISSUE #296] Various issues with building RPM files #209

New issue

Closed

opened 2026-05-05 05:19:41 -06:00 by gitea-mirror · 4 comments

gitea-mirror commented

2026-05-05 05:19:41 -06:00

Owner

Originally created by @jgriffiths on GitHub (Feb 15, 2016).
Original GitHub issue: https://github.com/netblue30/firejail/issues/296

Currently:

There are 2 scripts to build rpms
mkrpm.sh is completely broken and contains committed merge conflicts
Both scripts are overly verbose
Both scripts duplicate data held elsewhere (version, changelog) and so will always be out of date
Both scripts fail to cleanup if interrupted
The spec file is missing a library

The rpm building really should be/needs to be simplified and added to the make machinery.

Originally created by @jgriffiths on GitHub (Feb 15, 2016). Original GitHub issue: https://github.com/netblue30/firejail/issues/296 Currently: - There are 2 scripts to build rpms - mkrpm.sh is completely broken and contains committed merge conflicts - Both scripts are overly verbose - Both scripts duplicate data held elsewhere (version, changelog) and so will always be out of date - Both scripts fail to cleanup if interrupted - The spec file is missing a library The rpm building really should be/needs to be simplified and added to the make machinery.

gitea-mirror

2026-05-05 05:19:41 -06:00

closed this issue
added the
information_old
label

gitea-mirror commented

2026-05-05 05:19:49 -06:00

Author

Owner

@h1z1 commented on GitHub (Feb 16, 2016):

See #238 . I believe they are working on it.

@h1z1 commented on GitHub (Feb 16, 2016): See #238 . I believe they are working on it.

gitea-mirror commented

2026-05-05 05:19:51 -06:00

Author

Owner

@jgriffiths commented on GitHub (Feb 16, 2016):

@h1z1 That issue isn't directly related although they obviously had issues with the RPM creation in 0.9.38 as shown by their comments about e.g. needing to add the the missing library to the spec file. The patch that closed that issue didn't touch the RPM creation scripts or the spec file at all.

This issue and associated pull request are to fix the RPM building problems.

@jgriffiths commented on GitHub (Feb 16, 2016): @h1z1 That issue isn't directly related although they obviously had issues with the RPM creation in 0.9.38 as shown by their comments about e.g. needing to add the the missing library to the spec file. The patch that closed that issue didn't touch the RPM creation scripts or the spec file at all. This issue and associated pull request are to fix the RPM building problems.

gitea-mirror commented

2026-05-05 05:19:54 -06:00

Author

Owner

@netblue30 commented on GitHub (Feb 16, 2016):

https://github.com/netblue30/firejail/issues/238 - there was a problem with 0.9.38 on CentOS 6, /run directory does not exist on Centos 6, the user would have to create it manually. The problem is fixed now. I'll go ahead and merge https://github.com/netblue30/firejail/pull/297

@netblue30 commented on GitHub (Feb 16, 2016): https://github.com/netblue30/firejail/issues/238 - there was a problem with 0.9.38 on CentOS 6, /run directory does not exist on Centos 6, the user would have to create it manually. The problem is fixed now. I'll go ahead and merge https://github.com/netblue30/firejail/pull/297

gitea-mirror commented

2026-05-05 05:19:56 -06:00

Author

Owner

@netblue30 commented on GitHub (Feb 16, 2016):

All merged, thanks!

@netblue30 commented on GitHub (Feb 16, 2016): All merged, thanks!

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#209

No description provided.

Rows
Columns