[GH-ISSUE #3320] Build fails on Ubuntu 16.04 LTS with commit ab62720 #2085

Closed
opened 2026-05-05 08:45:28 -06:00 by gitea-mirror · 8 comments
Owner

Originally created by @ghost on GitHub (Apr 5, 2020).
Original GitHub issue: https://github.com/netblue30/firejail/issues/3320

Just noticed that building from git master breaks on Ubuntu 16.04 LTS. Not sure, but it looks as if older versions of install can't handle the syntax introduced in ab62720b38. I do realize 16.04 is dinosaurial by now, but it might be broken on other OS'es too.

$ install --version | head -n 1
install (GNU coreutils) 8.25

...
# etc files
install -m 0755 -d //etc/firejail
install -m 0644 -t //etc/firejail etc/{*.profile,*.inc,*.net,firejail.config}
install: cannot stat 'etc/{*.profile,*.inc,*.net,firejail.config}': No such file or directory
make[1]: *** [Makefile:125: realinstall] Error 1
make[1]: Leaving directory '/tmp/bz-dirkos/firejail-git'
make: *** [Makefile:164: install] Error 2
Originally created by @ghost on GitHub (Apr 5, 2020). Original GitHub issue: https://github.com/netblue30/firejail/issues/3320 Just noticed that building from git master breaks on Ubuntu 16.04 LTS. Not sure, but it looks as if older versions of `install` can't handle the syntax introduced in https://github.com/netblue30/firejail/commit/ab62720b38ffa766b1a51153d167df254148091b. I do realize 16.04 is dinosaurial by now, but it might be broken on other OS'es too. ``` $ install --version | head -n 1 install (GNU coreutils) 8.25 ... # etc files install -m 0755 -d //etc/firejail install -m 0644 -t //etc/firejail etc/{*.profile,*.inc,*.net,firejail.config} install: cannot stat 'etc/{*.profile,*.inc,*.net,firejail.config}': No such file or directory make[1]: *** [Makefile:125: realinstall] Error 1 make[1]: Leaving directory '/tmp/bz-dirkos/firejail-git' make: *** [Makefile:164: install] Error 2 ```
Author
Owner

@netblue30 commented on GitHub (Apr 5, 2020):

Try now, I think I have a fix in. I'm still waiting on travis here:

https://travis-ci.org/github/netblue30/firejail

<!-- gh-comment-id:609429078 --> @netblue30 commented on GitHub (Apr 5, 2020): Try now, I think I have a fix in. I'm still waiting on travis here: https://travis-ci.org/github/netblue30/firejail
Author
Owner

@rusty-snake commented on GitHub (Apr 5, 2020):

The globbing should be done by the your shell. Maybe the bash in 16.04 is too old for this syntax. The globing in fbec95c4 is also done by the shell, if it works can you try:

install -m 0644 -t $(DESTDIR)/$(sysconfdir)/firejail etc/*.profile etc/*.inc etc/*.net etc/firejail.config
<!-- gh-comment-id:609430075 --> @rusty-snake commented on GitHub (Apr 5, 2020): The globbing should be done by the your shell. Maybe the bash in 16.04 is too old for this syntax. The globing in fbec95c4 is also done by the shell, if it works can you try: install -m 0644 -t $(DESTDIR)/$(sysconfdir)/firejail etc/*.profile etc/*.inc etc/*.net etc/firejail.config
Author
Owner

@netblue30 commented on GitHub (Apr 5, 2020):

I'm seeing the same problem in debian stable. It's something very recent. TravisCi is fine (that's an Ubuntu 14.04) @rusty-snake what distro are you on?

<!-- gh-comment-id:609432190 --> @netblue30 commented on GitHub (Apr 5, 2020): I'm seeing the same problem in debian stable. It's something very recent. TravisCi is fine (that's an Ubuntu 14.04) @rusty-snake what distro are you on?
Author
Owner

@rusty-snake commented on GitHub (Apr 5, 2020):

Fedora 31; bash 5.0; install/coreutils 8.31; make 4.2.1.

<!-- gh-comment-id:609432953 --> @rusty-snake commented on GitHub (Apr 5, 2020): Fedora 31; bash 5.0; install/coreutils 8.31; make 4.2.1.
Author
Owner

@netblue30 commented on GitHub (Apr 5, 2020):

cool!

<!-- gh-comment-id:609433804 --> @netblue30 commented on GitHub (Apr 5, 2020): cool!
Author
Owner

@ghost commented on GitHub (Apr 5, 2020):

@netblue30 Thanks, that worked.

install -m 0644 -t $(DESTDIR)/$(sysconfdir)/firejail etc/.profile etc/.inc etc/*.net
etc/firejail.config

@rusty-snake seems a lot faster now doing it like that, it worked with bash from a xenial PPA (5.0-6ubuntu1~16.04.sav0) and the original xenial version (4.0).

<!-- gh-comment-id:609433836 --> @ghost commented on GitHub (Apr 5, 2020): @netblue30 Thanks, that worked. > install -m 0644 -t $(DESTDIR)/$(sysconfdir)/firejail etc/*.profile etc/*.inc etc/*.net etc/firejail.config @rusty-snake seems a lot faster now doing it like that, it worked with bash from a xenial PPA (5.0-6ubuntu1~16.04.sav0) and the original xenial version (4.0).
Author
Owner

@netblue30 commented on GitHub (Apr 5, 2020):

running a travis test with the version from @glitsj16 - fine on debian

<!-- gh-comment-id:609434923 --> @netblue30 commented on GitHub (Apr 5, 2020): running a travis test with the version from @glitsj16 - fine on debian
Author
Owner

@netblue30 commented on GitHub (Apr 5, 2020):

all fine, both travis and gitlab pipeline passing.

<!-- gh-comment-id:609437755 --> @netblue30 commented on GitHub (Apr 5, 2020): all fine, both travis and gitlab pipeline passing.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#2085
No description provided.