mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[GH-ISSUE #3145] Handle "non-standard" login.defs paths better #1976
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#1976
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @danieru98 on GitHub (Jan 14, 2020).
Original GitHub issue: https://github.com/netblue30/firejail/issues/3145
On function init_uid_gid_min firejail tries to open /etc/login.defs. But on opensuse for example they recently moved this file to /usr/etc/login.defs https://lizards.opensuse.org/2019/12/05/yast-sprint-90/
This means that firejail will fail in the case where /etc/login.defs is not found and a user with uid/gid other than 1000 attemps to run it.
pclinux might also be affected http://www.pclinuxos.com/forum/index.php?topic=146992.0
@ghost commented on GitHub (Jan 17, 2020):
@danieru98 Great detective work. Thank you for reporting and providing those links. I've tested a quick patch but that didn't pan out well. Let's hope that by marking this as a bug the main C collaborators can come up with a proper fix sooner rather than later.
@ghost commented on GitHub (Jan 17, 2020):
@smitsohu Sorry to bother you (again), but have you seen this? Looks rather urgent and complicated, but I'm not the best to judge as I've never came close to an actual opensuse machine...
@smitsohu commented on GitHub (Jan 17, 2020):
Creating a second /etc hierarchy inside /usr is a quite significant change. It's not only about
login.defs, there is also an impact onprivate-etcand maybe other options.@danieru98 Do I understand it right that if there is a file
/etc/login.defsit will take precedence over/usr/etc/login.defs?@smitsohu commented on GitHub (Feb 9, 2020):
Thanks for the report!