mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[GH-ISSUE #3095] Firecfg CLI archivers - missing and/or broken on Arch makepkg #1941
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#1941
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Dec 23, 2019).
Original GitHub issue: https://github.com/netblue30/firejail/issues/3095
I noticed that firecfg enables some of the available command-line archivers, but not others (see compiled list below). Is there any (official)
policyto decide which archivers are supported infirecfgand which not? If this is simply due to omissions, we need to add the missing ones IMHO.List of currently missing archiver (redirect) profiles in firecfg:
7z, 7za, 7zr, bsdcat, bsdcpio, bsdtar, cpio, gtar, gunzip, gzexe, gzip, lbunzip2, lbzcat, lbzip2, lzcat, lzcmp, lzdiff, lzegrep, lzfgrep, lzgrep, lzip, lzless, lzma, lzmainfo, lzmore, p7zip, tar, uncompress, unlzma, unrar, unxz, unzip, xz, xzcat, xzcmp, xzdiff, xzegrep, xzfgrep, xzgrep, xzless, xzmore, zcat, zcmp, zdiff, zegrep, zfgrep, zforce, zgrep, zless, zmore, znew
@rusty-snake commented on GitHub (Dec 24, 2019):
Tools like *grep, *diff, *less, *more, .. should be added IMHO (after removing whitelist-var). Tools like xz, lzma, cpio maybe conflict with some packet-managers.
@ghost commented on GitHub (Dec 24, 2019):
I just checked. None of the CLI archivers includes
whitelist-var-common.inc, so that shouldn't pose any problems.@rusty-snake commented on GitHub (Dec 24, 2019):
@glitsj16 you right, but maybe some
noblacklistandwritable-var-log(andwritable-var?).@Vincent43 commented on GitHub (Dec 24, 2019):
Yeah, archivers are tricky due to package managers issues.
bzip2already causes trouble for me in Arch. I think it's better to focus on gui archivers like ark, engrampa, etc. which most people use and leave cli tools out from defaults.@ghost commented on GitHub (Dec 24, 2019):
@rusty-snake I agree, we should review all CLI-archivers for stuff like that. I've been doing this occasionally for a while now (manually firejailed all archivers that have a profile, I don't use firecfg). It did take a few .local files, but for me these archivers all work fine - both on Arch and Ubuntu 16.04 LTS. Only one exception:
bsdtar(which I run non-firejailed).@Vincent43 I tend to agree that firecfg should only deal with GUI archivers. I'm willing to make a PR for that shortly, allthough I'm not sure it will be in time for the upcoming 0.9.62 release (end-of-year holidays and all that...). Out of curiosity, what seems to be the problem with bzip2 you face on Arch exactly?
@Vincent43 commented on GitHub (Dec 25, 2019):
I don't remember specifics right now but I think it caused issues with
makepkg.@ghost commented on GitHub (Dec 26, 2019):
@Vincent43 Sounds familiar. That seems to be where the
bsdtarprofile is causing havoc for me. After some more tests it seems to stem from the fact that Arch relies onfakerootin makepkg. Outside makepkg these archivers seem to work just fine. For testing I added a fakeroot wrapper that disables firejailed applications via PATH manipulation, explicitly leaving out /usr/local/bin (where firecfg drops the symlinks). Far from ideal, but at least I'm able to keep archiver profiles enabled.More research/testing is needed here, but this convinces me even more that we should implement your suggestion to leave CLI tools out of firecfg sooner rather than later. If we decide to take that road we should prepare for users asking support for (safe, reliable) ways to exclude/include profiles into firecfg (cfr. #3016).