mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[GH-ISSUE #2995] Epiphany needs bwrap #1877
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#1877
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mkdy on GitHub (Oct 8, 2019).
Original GitHub issue: https://github.com/netblue30/firejail/issues/2995
A fresh version of Epiphany browser (3.34.1-1) uses bwrap for some purposes (have no idea why).
I've created
epiphany.localand filled it with:noblacklist ${PATH}/bwrapHowever, it seems that
bwrapitself needs some permissions such as internet access.@Vincent43 commented on GitHub (Oct 8, 2019):
bwrap is very similar to firejail itself sandboxing tool (used by flatpak) and I guess Epiphany uses it for that. Perhaps we have to drop epiphany support as overlapping sandboxes can't work.
@rusty-snake commented on GitHub (Oct 8, 2019):
Confirming. Fedora 31 BETA VM with firejail-git.
@smitsohu commented on GitHub (Oct 10, 2019):
It is probably similar to Chrome, only the (sometimes setuid) sandbox binary is different.
@FOSSONLY commented on GitHub (Oct 12, 2019):
@Vincent43
In fact, Firejail had no support for the Epiphany browser so far. The existing profile called Epiphany refers to a game of the same name. You should better use the Firefox profile for Epiphany.
However, I'm not sure how good it is for programs to bring their own sandbox. So the security is in the hands of the developers, and the user loses any flexibility to define it, if you don't want to change the source code. Personally, I would always use Firejail, because I don't think any program should be able to control its own security. For me, this is something that has to be centrally enforced, to which every program has to subordinate itself. What do the others think about it?
@rusty-snake commented on GitHub (Oct 12, 2019):
IMHO we should say this explicit in the profile that is not for epiphany (aka GNOME Web) and remove it form
firecfg.configsince it cause name conflicts. Maybe also rename toepiphany_game.profileor similar.@rusty-snake commented on GitHub (Oct 12, 2019):
👍 💯 IMHO a tight firejail sandbox is better, if possible. For
chromiumthis would mean starting with--no-sandboxand hardening the FJ profile. Anyway the fox is better 😇@SkewedZeppelin commented on GitHub (Oct 14, 2019):
Whoa there
epiphany.profile is indeed for GNOME Web
Must've slipped through the cracks with the automated descriptions pull
4666466fc6@Vincent43 commented on GitHub (Oct 14, 2019):
@SkewedZeppelin nice, should we sunset it though, considering it's broken with 3.34+?
@rusty-snake commented on GitHub (Oct 14, 2019):
Adding a note about broke for 3.34+ and removing form firecfg, but leaving for now for e.g. debian users.
@msva commented on GitHub (Jul 21, 2024):
actually, it looks like it is possible (at least, for now) to kinda "mitigate" this problem by setting WEBKIT_DISABLE_SANDBOX_THIS_IS_DANGEROUS variable value to
1in firejail profileOr by creating one of this files inside "jail":
0678a98c86/Source/WTF/wtf/glib/Sandbox.cpp (L42)0678a98c86/Source/WTF/wtf/glib/Sandbox.cpp (L35)@ghost commented on GitHub (Jul 21, 2024):
@msva
Very nice find! Can you open a PR to add this to our epiphany.profile?
Side note:
Going over the referenced ProcessLauncherGlib.cpp file I noticed that this env var replaces the now deprecated
WEBKIT_FORCE_SANDBOXenv var. We set the latter in thebijiben.profile:969e29b756/etc/profile-a-l/bijiben.profile (L62)@rusty-snake commented on GitHub (Jul 21, 2024):
No, we should not add this.
@ghost commented on GitHub (Jul 21, 2024):
@rusty-snake Unsafe to do so?
@rusty-snake commented on GitHub (Jul 21, 2024):
Yes
epiphany+bwrap is more secure than firejail+epiphany-bwrap. If people still want to do this against my/our advise, for the more-secure-felling-but-less-secure-in-reality, we could add a comment (I really do not want to promote those unsafe debugging hacks).
@ghost commented on GitHub (Jul 21, 2024):
@rusty-snake
I totally agree. We already have a comment in epiphany.profile referring to this issue, so I think we're good as-is. Thanks for your explaining!
On that note, we should drop the unsafe workaround in
bijiben.profile. As far as I understand the deprecated env var won't work any longer anyway.