mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[GH-ISSUE #2669] Remove the need for QTWEBENGINE_DISABLE_SANDBOX=1 (appimage) #1685
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#1685
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @probonopd on GitHub (Apr 30, 2019).
Original GitHub issue: https://github.com/netblue30/firejail/issues/2669
QTWEBENGINE_DISABLE_SANDBOX=1may be needed to run Qt applications that use QtWebEngine under Firejail.At least this is the case for https://appimage.github.io/Galacteek/.
Would it make sense to have Firejail set this environment variable globally? I see it already exists in the source code but is commented out.
@rusty-snake commented on GitHub (Apr 30, 2019):
Currently this is only set for Viber,
Also see here.
@probonopd commented on GitHub (May 1, 2019):
Is it already known under which circumstances QtWebEngine needs this option?
@Vincent43 commented on GitHub (May 1, 2019):
I would say it should be never added. Firejail sandbox should be tweaked instead.
@probonopd commented on GitHub (May 3, 2019):
Listing here which applications needs this:
@smitsohu commented on GitHub (May 4, 2019):
Always (given that unprivileged user namespaces are enabled).
It's all about the chroot syscall being included in the default seccomp filter. As this is an increasingly common problem, would it justify a new option?
@probonopd commented on GitHub (May 5, 2019):
It would be best if it would not need a special option to be invoked by the user. (If the user has to do something, then
QTWEBENGINE_DISABLE_SANDBOX=1is fine imho.)@Vincent43 commented on GitHub (May 6, 2019):
Maybe tweak
seccomprule to allow defining firejail defaults +/- a chosen syscall,like
seccomp +chroot?@rusty-snake commented on GitHub (Jun 26, 2019):
I think we schould implement @Vincent43 idea
@rusty-snake commented on GitHub (Aug 26, 2019):
How future proceed here?
@Vincent43 commented on GitHub (Aug 26, 2019):
Adding this to Viber.profile and removing
env QTWEBENGINE_DISABLE_SANDBOX=1from there should be enough to close this. You may include this in https://github.com/netblue30/firejail/pull/2927 and wait till https://github.com/netblue30/firejail/pull/2926 is merged.@probonopd commented on GitHub (Aug 28, 2019):
Well, I'd say this ticket can be closed once we the user won't need to manually run
env QTWEBENGINE_DISABLE_SANDBOX=1anywhere anymore, not just for Viber.@Vincent43 commented on GitHub (Aug 28, 2019):
@probonopd you mean appimage apps? They seem to use
default.profile. The only fix I see is to removechrootfrom default seccomp filter.@probonopd commented on GitHub (Aug 30, 2019):
Yes, I mean AppImage apps. What would the security implications be of what you are suggesting? Would the FIrejail sandboxing still be effective?
If we have to disable either FIrejail's or Chrome's sandbox, then I'd say enable Firejail's and disable Chrome's, e.g., by exporting
QTWEBENGINE_DISABLE_SANDBOX=1all the time.@Vincent43 commented on GitHub (Aug 30, 2019):
We just need to allow one additional syscall (
chroot) which many apps use for self-sandboxing. Everything else will stay intact and app will be protected by both firejail and chrome sandboxing.@probonopd commented on GitHub (Sep 4, 2019):
Thank you very much.
@smitsohu commented on GitHub (Sep 5, 2019):
@Vincent43 Maybe rather than removing
chrootfrom the default seccomp blacklist, we could just remove it from default.profile? (or I understood you wrong and that was what you were saying)@Vincent43 commented on GitHub (Sep 5, 2019):
@smitsohu
chrootbreaks most electron apps and will ultimately break all of them once they update to latest version. It's no longer suitable default in apps world.