[GH-ISSUE #2664] Broken commit !! #1680

Closed
opened 2026-05-05 08:19:35 -06:00 by gitea-mirror · 3 comments
Owner

Originally created by @dandelionred on GitHub (Apr 24, 2019).
Original GitHub issue: https://github.com/netblue30/firejail/issues/2664

0d42e12f11

Originally created by @dandelionred on GitHub (Apr 24, 2019). Original GitHub issue: https://github.com/netblue30/firejail/issues/2664 0d42e12f11825f84d6bf6f9c667cd16272a3700c
Author
Owner

@rusty-snake commented on GitHub (Apr 24, 2019):

How this is going to be fixed somebody has to tell me. There are two options:

  1. https://github.com/rusty-snake/firejail/pull/1 but this will break git blame for these profiles (including disable-programs.inc)

  2. someone tells me how to revert this cleanly.

<!-- gh-comment-id:486204687 --> @rusty-snake commented on GitHub (Apr 24, 2019): How this is going to be fixed somebody has to tell me. There are two options: 1. https://github.com/rusty-snake/firejail/pull/1 but this will break git blame for these profiles (including disable-programs.inc) 2. someone tells me how to revert this cleanly.
Author
Owner

@SkewedZeppelin commented on GitHub (Apr 24, 2019):

I reverted it, there is nothing you can do about git blame unless someone like @netblue30 force pushed it, which is never a good idea, especially with a common/popular repo like this.

In the future, I recommend the habit of doing a git show before a git push.

<!-- gh-comment-id:486316973 --> @SkewedZeppelin commented on GitHub (Apr 24, 2019): I reverted it, there is nothing you can do about git blame unless someone like @netblue30 force pushed it, which is never a good idea, especially with a common/popular repo like this. In the future, I recommend the habit of doing a `git show` before a `git push`.
Author
Owner

@rusty-snake commented on GitHub (Apr 24, 2019):

@SkewedZeppelin Thanks.

Yes, I should be a bit more careful in the future with git push (and git commit and git merge and git ...) and look over it before pushing.

The curiosity about this is that it was firejail.

<!-- gh-comment-id:486335831 --> @rusty-snake commented on GitHub (Apr 24, 2019): @SkewedZeppelin Thanks. Yes, I should be a bit more careful in the future with `git push` (and `git commit` and `git merge` and `git ...`) and look over it before pushing. The curiosity about this is that it was firejail.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#1680
No description provided.