github-starred/firejail

Fork 0

mirror of https://github.com/netblue30/firejail.git synced 2026-05-15 14:16:14 -06:00

[GH-ISSUE #2361] "desktop.profile" #1573

New issue

Closed

opened 2026-05-05 08:13:58 -06:00 by gitea-mirror · 6 comments

gitea-mirror commented

2026-05-05 08:13:58 -06:00

Owner

Originally created by @reinerh on GitHub (Jan 21, 2019).
Original GitHub issue: https://github.com/netblue30/firejail/issues/2361

I noticed a profile called "desktop.profile".
Is this named correctly? The local file it includes is actually named "github-desktop.local", so it suggests that "github-desktop.profile" would be the correct name.
It would also be quite strange if the github-desktop binary was just called "desktop". But I can't check it at the moment.
Can someone please verify if the name is correct?

cc @glitsj16

Originally created by @reinerh on GitHub (Jan 21, 2019). Original GitHub issue: https://github.com/netblue30/firejail/issues/2361 I noticed a profile called "desktop.profile". Is this named correctly? The local file it includes is actually named "github-desktop.local", so it suggests that "github-desktop.profile" would be the correct name. It would also be quite strange if the github-desktop binary was just called "desktop". But I can't check it at the moment. Can someone please verify if the name is correct? cc @glitsj16

gitea-mirror

2026-05-05 08:13:58 -06:00

closed this issue
added the
question_old
label

gitea-mirror commented

2026-05-05 08:14:01 -06:00

Author

Owner

@SkewedZeppelin commented on GitHub (Jan 21, 2019):

this is https://github.com/desktop/desktop
there appear to be no official binaries for Linux, nor do any distros seem to package it
there are a few unofficial builds of it, one I checked and the binary was github-desktop

since there isn't a github-desktop.profile I'm going to assume the file name was an accident, but lets wait for @glitsj16's response

@SkewedZeppelin commented on GitHub (Jan 21, 2019): this is https://github.com/desktop/desktop there appear to be no official binaries for Linux, nor do any distros seem to package it there are a few unofficial builds of it, one I checked and the binary was `github-desktop` since there isn't a github-desktop.profile I'm going to assume the file name was an accident, but lets wait for @glitsj16's response

gitea-mirror commented

2026-05-05 08:14:02 -06:00

Author

Owner

@ghost commented on GitHub (Jan 21, 2019):

Hi, I remember this application going through some (file)name changes. At the time I added the profile the binary was named desktop, indeed strange and exceptional. For a while now it has been available in the AUR in a few differently named packages for Arch Linux. To confuse things even more, there's https://github.com/shiftkey/desktop and https://snapcraft.io/github-desktop, offering Appimage, Snap, .deb and .rpm's.

@reinerh: You are correct though. The profile should be named github-desktop.profile. On top of that, the aforementioned installers now all use the more sensible github-desktop.desktop format. Hence the firecfg name also needs changing. If you and @SkewedZeppelin are okay with this, I'll make a PR with the needed changes asap.

Thanks for pointing out this mistake, which was mine indeed.

@ghost commented on GitHub (Jan 21, 2019): Hi, I remember this application going through some (file)name changes. At the time I added the profile the binary was named `desktop`, indeed strange and exceptional. For a while now it has been [available in the AUR](https://aur.archlinux.org/packages.php?K=github-desktop&O=0&do_Search=Go) in a few differently named packages for Arch Linux. To confuse things even more, there's https://github.com/shiftkey/desktop and https://snapcraft.io/github-desktop, offering Appimage, Snap, .deb and .rpm's. @reinerh: You are correct though. The profile should be named `github-desktop.profile`. On top of that, the aforementioned installers now all use the more sensible `github-desktop.desktop` format. Hence the firecfg name also needs changing. If you and @SkewedZeppelin are okay with this, I'll make a PR with the needed changes asap. Thanks for pointing out this mistake, which was mine indeed.

gitea-mirror commented

2026-05-05 08:14:03 -06:00

Author

Owner

@ghost commented on GitHub (Jan 21, 2019):

Follow-up. I just noticed that the .deb from https://github.com/shiftkey/desktop/releases installs to /opt/Github Desktop. I've never used anything from /opt with firejail, so give me some time to boot into Ubuntu 16.04, install the .deb and test an edited profile. I'll report back here, please hold.

@ghost commented on GitHub (Jan 21, 2019): Follow-up. I just noticed that the .deb from https://github.com/shiftkey/desktop/releases installs to `/opt/Github Desktop`. I've never used anything from /opt with firejail, so give me some time to boot into Ubuntu 16.04, install the .deb and test an edited profile. I'll report back here, please hold.

gitea-mirror commented

2026-05-05 08:14:04 -06:00

Author

Owner

@reinerh commented on GitHub (Jan 21, 2019):

Thank you for looking into it. 👍

@reinerh commented on GitHub (Jan 21, 2019): Thank you for looking into it. :+1:

gitea-mirror commented

2026-05-05 08:14:04 -06:00

Author

Owner

@ghost commented on GitHub (Jan 22, 2019):

Hi all. After some more testing I came up with the following PR: https://github.com/netblue30/firejail/pull/2362. Please check and/or advise on these changes. I added comments inside the profile to cover 2 possible issues:

user needs to add preferred location where local repositories are kept;
binary location might not be in PATH on debian-based distros.

@ghost commented on GitHub (Jan 22, 2019): Hi all. After some more testing I came up with the following PR: https://github.com/netblue30/firejail/pull/2362. Please check and/or advise on these changes. I added comments inside the profile to cover 2 possible issues: * user needs to add preferred location where local repositories are kept; * binary location might not be in PATH on debian-based distros.

gitea-mirror commented

2026-05-05 08:14:05 -06:00

Author

Owner

@ghost commented on GitHub (Jan 22, 2019):

PR https://github.com/netblue30/firejail/pull/2362 fixes the profile name issue and refactors it as a blacklist profile with additional support for github-desktop appimage.

@ghost commented on GitHub (Jan 22, 2019): PR https://github.com/netblue30/firejail/pull/2362 fixes the profile name issue and refactors it as a blacklist profile with additional support for github-desktop appimage.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#1573

No description provided.

Rows
Columns