mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[GH-ISSUE #2194] add nou2f to all profiles with private-dev #1469
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#1469
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @smitsohu on GitHub (Oct 14, 2018).
Original GitHub issue: https://github.com/netblue30/firejail/issues/2194
We punched a small hole in
private-devto get yubikeys and such working, but it hasn't been closed yet in the profiles that we ship.I would propose to add
nou2fto all profiles withprivate-dev, including the browsers and keepassxc. The reason is that /dev/usb can contain devices such as printers and keyboards, and exposing them in the sandbox is usually neither necessary nor desirable.Imho users who own a yubikey and want to use it with firejail should rather opt-in and disable nou2f themselves.
@reinerh commented on GitHub (Oct 15, 2018):
instead of touching every profile, why not make nou2f the default, and add an "u2f" option which allows it?
@smitsohu commented on GitHub (Oct 15, 2018):
@reinerh It would be way easier to maintain! But if I understand #1446 right, we are going to do this anyway at some point. To avoid confusing semantics, all
private-devrelated options should probably change behavior simultaneously.@SkewedZeppelin commented on GitHub (Oct 15, 2018):
@smitsohu if you want to go the easy approach, here is a commit that adds nou2f to all profiles in the proper location
284e0750e5@smitsohu commented on GitHub (Oct 15, 2018):
@SkewedZeppelin Cool!
It is only me, but I would find "the easy approach" more suitable for what might be a "bugfix" release.