[GH-ISSUE #2154] Split up disable-mnt #1462

Closed
opened 2026-05-05 08:07:41 -06:00 by gitea-mirror · 6 comments
Owner

Originally created by @chiraag-nataraj on GitHub (Oct 9, 2018).
Original GitHub issue: https://github.com/netblue30/firejail/issues/2154

We should split disable-mnt into two different directives (disable-mnt and disable-media) to make things more granular.

Originally created by @chiraag-nataraj on GitHub (Oct 9, 2018). Original GitHub issue: https://github.com/netblue30/firejail/issues/2154 We should split `disable-mnt` into two different directives (`disable-mnt` and `disable-media`) to make things more granular.
gitea-mirror 2026-05-05 08:07:41 -06:00
Author
Owner

@chiraag-nataraj commented on GitHub (Oct 9, 2018):

Alternate proposal by @smitsohu: Turn disable-mnt into a set of ordinary blacklist commands, which can be overridden as usual with noblacklist.

<!-- gh-comment-id:428215318 --> @chiraag-nataraj commented on GitHub (Oct 9, 2018): Alternate proposal by @smitsohu: Turn `disable-mnt` into a set of ordinary `blacklist` commands, which can be overridden as usual with `noblacklist`.
Author
Owner

@smitsohu commented on GitHub (Oct 9, 2018):

Adding some advertisement for my own proposal: I doesn't change the meaning of an existing option and hence doesn't create a need to update existing profiles.
Also I recall people actually trying to noblacklist /media or /mnt in order to get their setup running, and posting to the bug tracker because that didn't work.

<!-- gh-comment-id:428362427 --> @smitsohu commented on GitHub (Oct 9, 2018): Adding some advertisement for my own proposal: I doesn't change the meaning of an existing option and hence doesn't create a need to update existing profiles. Also I recall people actually trying to noblacklist /media or /mnt in order to get their setup running, and posting to the bug tracker because that didn't work.
Author
Owner

@startx2017 commented on GitHub (Oct 9, 2018):

We have disable-mnt in firetools GUI. Replacing it with blacklists in profile files should be fine.

<!-- gh-comment-id:428368332 --> @startx2017 commented on GitHub (Oct 9, 2018): We have disable-mnt in firetools GUI. Replacing it with blacklists in profile files should be fine.
Author
Owner

@Fred-Barclay commented on GitHub (Oct 10, 2018):

@smitsohu Would disable-mnt just blacklist /mnt as a whole?

<!-- gh-comment-id:428421796 --> @Fred-Barclay commented on GitHub (Oct 10, 2018): @smitsohu Would `disable-mnt` just blacklist /mnt as a whole?
Author
Owner

@smitsohu commented on GitHub (Oct 10, 2018):

@Fred-Barclay Like it does currently, yes.

<!-- gh-comment-id:428472932 --> @smitsohu commented on GitHub (Oct 10, 2018): @Fred-Barclay Like it does currently, yes.
Author
Owner

@Vincent43 commented on GitHub (Oct 10, 2018):

I think splitting disable-media will only add maintenance burden as there will be yet another option to add to each profile. Changing it behavior to work as --blacklist=/media --blacklist=/run/media --blacklist=/mnt which will be overridable by --noblacklist sounds much better.

<!-- gh-comment-id:428534895 --> @Vincent43 commented on GitHub (Oct 10, 2018): I think splitting `disable-media` will only add maintenance burden as there will be yet another option to add to each profile. Changing it behavior to work as `--blacklist=/media` `--blacklist=/run/media` `--blacklist=/mnt` which will be overridable by `--noblacklist` sounds much better.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#1462
No description provided.