mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[GH-ISSUE #2009] Maximum profile include level was reached #1353
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#1353
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ferreum on GitHub (Jun 23, 2018).
Original GitHub issue: https://github.com/netblue30/firejail/issues/2009
I seem to have a quite customized setup, and since version 0.9.54 firejail complains (and fails starting) with the above message if I try to start thunderbird (edit: I should say that I linked
/usr/local/bin/thunderbirdto firejail):The file
/home/fe/.local/share/firejail/thunderbird.localdoesn't include anything, so/home/fe/.config/firejail/disable-common.inc.localis on the 7th include level. This file contains one further include of~/.local/share/firejail/disable-common.localbut the chain ends there.My guess is that this happens because the thunderbird profile now includes the firefox profile.
Why is the limit so low? I couldn't find any option to increase the maximum include level.
@SkewedZeppelin commented on GitHub (Jun 23, 2018):
The limit is 6, defined as MAX_INCLUDE_LEVEL
dc96a6c6fa/src/firejail/firejail.h (L107)and it is enforced here
dc96a6c6fa/src/firejail/profile.c (L1224-L1228)According to git blame it was added back in the early days before we had .local and .global files.
We should probably consider increasing it maybe to 8 or 10.
@Fred-Barclay commented on GitHub (Jun 24, 2018):
@netblue30 why do we have an include limit?
@reinerh commented on GitHub (Jun 26, 2018):
Maybe to prevent recursion?
@ferreum commented on GitHub (Jun 26, 2018):
To prevent (infinite) recursion, the limit doesn't need to be this low - may aswell increase it to 32 or higher. What I'm concerned about is that each recursion may need a hard to determine amout of stack, so this could lead to security issues from stack overflows. This is also why I refrained from patching the limit myself.
@netblue30 commented on GitHub (Jun 30, 2018):
Yes, it was to prevent infinite recursion - increased the level to 16 -
bc2a81b299