[GH-ISSUE #2006] globals.local included twice in profiles using x-common.profile format #1352

Closed
opened 2026-05-05 07:55:07 -06:00 by gitea-mirror · 1 comment
Owner

Originally created by @ghost on GitHub (Jun 20, 2018).
Original GitHub issue: https://github.com/netblue30/firejail/issues/2006

Profiles using an include x-common.profile format (like {chromium,discord,firefox}-common.profile do) are seeing globals.local included twice. Probably more confusing than harmful, but then again I don't know what users put inside that file. This happens for the following profiles:

  1. chromium-common.profile
  • bnox.profile
  • brave.profile
  • chromium.profile
  • dnox.profile
  • enox.profile
  • flashpeak-slimjet.profile
  • google-chrome.profile
  • google-chrome-beta.profile
  • google-chrome-unstable.profile
  • inox.profile
  • iridium.profile
  • opera.profile
  • opera-beta.profile
  • vivaldi.profile
  • vivaldi-snapshot.profile
  • yandex-browser.profile
  1. discord-common.profile
  • discord.profile
  • Discord.profile
  • discord-canary.profile
  • DiscordCanary.profile
  1. firefox-common.profile
  • abrowser.profile
  • basilisk.profile
  • cliqz.profile
  • cyberfox.profile
  • firefox.profile
  • icecat.profile
  • iceweasel.profile
  • palemoon.profile
  • waterfox.profile

Luckily we don't need to change all affected profiles. Commenting include /etc/firejail/globals.local in {chromium,discord,firefox}-common.profile should be enough to avoid multiple inclusion of globals.local.

Originally created by @ghost on GitHub (Jun 20, 2018). Original GitHub issue: https://github.com/netblue30/firejail/issues/2006 Profiles using an _include x-common.profile_ format (like {chromium,discord,firefox}-common.profile do) are seeing `globals.local` included twice. Probably more confusing than harmful, but then again I don't know what users put inside that file. This happens for the following profiles: 1. `chromium-common.profile` - bnox.profile - brave.profile - chromium.profile - dnox.profile - enox.profile - flashpeak-slimjet.profile - google-chrome.profile - google-chrome-beta.profile - google-chrome-unstable.profile - inox.profile - iridium.profile - opera.profile - opera-beta.profile - vivaldi.profile - vivaldi-snapshot.profile - yandex-browser.profile 2. `discord-common.profile` - discord.profile - Discord.profile - discord-canary.profile - DiscordCanary.profile 3. `firefox-common.profile` - abrowser.profile - basilisk.profile - cliqz.profile - cyberfox.profile - firefox.profile - icecat.profile - iceweasel.profile - palemoon.profile - waterfox.profile Luckily we don't need to change all affected profiles. Commenting `include /etc/firejail/globals.local` in `{chromium,discord,firefox}-common.profile` should be enough to avoid multiple inclusion of globals.local.
Author
Owner

@netblue30 commented on GitHub (Jun 22, 2018):

Thanks for the patch. It will speed up the setup.

<!-- gh-comment-id:399386768 --> @netblue30 commented on GitHub (Jun 22, 2018): Thanks for the patch. It will speed up the setup.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#1352
No description provided.