mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[GH-ISSUE #1773] rewrite browser profiles with redirections #1203
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#1203
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @smitsohu on GitHub (Feb 11, 2018).
Original GitHub issue: https://github.com/netblue30/firejail/issues/1773
We are shipping Firejail with a large number of browser profiles. Many of these browsers are just forks off Firefox and Chromium, with only minor deviations from the original codebase.
In order to ease maintenance, I would like to propose rewriting these profiles with redirections to something like firefox-common.inc and chromium-common.inc. The browser profiles themselves could keep their specific paths (and
private-binif necessary).Should projects begin to deviate more strongly (like Moon browser does already), it is still always possible to switch to a dedicated profile.
@SkewedZeppelin commented on GitHub (Feb 11, 2018):
Here are all the browsers we have profiles for. If I missed any just edit it in.
Chromium Based
Gecko Based
WekKit2Gtk
QtWebEngine (cef?)
Text Based
Unknown
@SkewedZeppelin commented on GitHub (Feb 11, 2018):
Of note there are 4 email clients that all include firefox.profile for whatever reason:
fossamail, geary, icedove, and thunderbird
@SkewedZeppelin commented on GitHub (Feb 11, 2018):
Here I gave it a go and unified all of the Chromium-based profiles
30d0b5d179Edit: Updated with brave added. Its probably safe to merge.
the Firefox ones might be more tedious, we should also evaluate whether or not we want to keep all of the paths that we currently do in Firefox
@Fred-Barclay commented on GitHub (Feb 11, 2018):
On the note about the email clients, I for one think we ought to not include firefox in their profiles. We already have to do some workarounds (like
ignore private-tmpand commenting outmachine-idin the thunderbird profile, all because we also include firefox's profile.)I'll take a look at the firefox profiles and see if I can get something similar to @SkewedZeppelin
@SkewedZeppelin commented on GitHub (Feb 11, 2018):
@Fred-Barclay I hope you didn't start yet, because I just finished.
Here are all Chromium and Firefox based browsers profiles unified
df2f568041I left out torbrowser for the increased security. We should also consider removing many of the paths in firefox-common.profile
@Fred-Barclay commented on GitHub (Feb 11, 2018):
@SkewedZeppelin no worries. 😁 Thanks!
Would removing all of the paths besides
be too far?
@SkewedZeppelin commented on GitHub (Feb 11, 2018):
So these? That'd be great, but I wonder how many people use addons/plugins that depend on them.
We could break them out into an includes and have it included by default, so advanced users wanting extra security can comment the line. Or the inverse or similar.
Like
include /etc/firejail/firefox-common-addons.incEdit: See
c4a640f05a@Fred-Barclay commented on GitHub (Feb 11, 2018):
Let's do it!
EDIT: by "it" I would prefer commenting the include addons line out and just letting advanced users uncomment it if needed... but this might temporarily break more people's setups than we really ought.
Now that firefox is using webextensions (like Chrome, I believe), maybe we don't need all these paths anyways? The chrome profiles don't have 'em and I don't think we've had any real issues despite them not being there.
@smitsohu commented on GitHub (Feb 12, 2018):
@Fred-Barclay Ahh, sorry, I had not seen your edit when I posted to the PR.
Maybe external pdf readers were more popular in Firefox because the built-in reader used to be worse than Chromium's 😄
But in general I agree, you have a point there.