Commit graph

55 commits

Author SHA1 Message Date
dependabot[bot]
d1995025b4 Bump github/codeql-action from 1.0.29 to 1.0.30
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1.0.29 to 1.0.30.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](384cfc42b2...8b37404d56)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-31 19:56:33 +00:00
dependabot[bot]
d1ac6a12bd Bump github/codeql-action from 1.0.27 to 1.0.29
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1.0.27 to 1.0.29.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](cd783c8a29...384cfc42b2)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-24 07:48:39 +00:00
dependabot[bot]
5f8dc7a943 Bump github/codeql-action from 1.0.26 to 1.0.27
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1.0.26 to 1.0.27.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](5f53256358...cd783c8a29)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-17 09:02:44 +00:00
dependabot[bot]
aebb75c079 Bump github/codeql-action from 1.0.24 to 1.0.26
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1.0.24 to 1.0.26.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](e095058bfa...5f53256358)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-12-26 22:00:57 +00:00
Topi Miettinen
678eb88ee7 CI: enable Dependabot for updating SHAs
Update GitHub actions with Dependabot:

https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/keeping-your-actions-up-to-date-with-dependabot
2021-12-26 21:52:05 +00:00
Topi Miettinen
4bac5c6d71 CI: pin GitHub actions to SHAs
Pinning actions to SHAs instead of versions improves the supply chain
security:
https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
2021-12-26 21:52:05 +00:00
rusty-snake
0aa66649ef Add Profile Checks 2021-10-29 11:00:06 +02:00
netblue30
d84ba25808
Merge pull request #4561 from kmk3/issue-template-improvements2
Issue template improvements2
2021-10-09 12:49:15 +00:00
a1346054
6eafbfdfcc
trim excess whitespace 2021-09-25 19:09:14 +00:00
Kelvin M. Klann
20727361b2 bug_report.md: link to markdown formatting help
As suggested by @rusty-snake.
2021-09-20 08:25:07 -03:00
Kelvin M. Klann
b39ef34e0a bug_report.md: add checked item example
It is not uncommon for people to use other characters to try to mark an
item as checked (which usually screws up the html output), so be sure to
include an example with "[x]".
2021-09-20 08:21:50 -03:00
Kelvin M. Klann
2b2df66047 bug_report.md: use LC_ALL where appropriate 2021-09-19 08:18:17 -03:00
Kelvin M. Klann
f9620708e0 bug_report.md: use LC_ALL instead of LANG
This overrides all `LC_*` variables (and LANG) rather than just LANG.

From Section 8.2, Internationalization Variables of POSIX.1-2017[1]:

> LANG
>     This variable shall determine the locale category for native
>     language, local customs, and coded character set in the absence of
>     the LC_ALL and other LC_* (LC_COLLATE, LC_CTYPE, LC_MESSAGES,
>     LC_MONETARY, LC_NUMERIC, LC_TIME) environment variables.  This can
>     be used by applications to determine the language to use for error
>     messages and instructions, collating sequences, date formats, and
>     so on.
>
> LC_ALL
>     This variable shall determine the values for all locale
>     categories.  The value of the LC_ALL environment variable has
>     precedence over any of the other environment variables starting
>     with LC_ (LC_COLLATE, LC_CTYPE, LC_MESSAGES, LC_MONETARY,
>     LC_NUMERIC, LC_TIME) and the LANG environment variable.

[1] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html
2021-09-19 08:16:40 -03:00
Kelvin M. Klann
b3212edeed bug_report.md: clarify message
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
2021-09-17 14:38:06 +02:00
Kelvin M. Klann
1b1009c408 bug_report.md: improve grammar
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
2021-09-17 14:37:58 +02:00
Kelvin M. Klann
a138a6545b bug_report.md: remove extraneous newline 2021-09-16 09:12:34 -03:00
rusty-snake
7b3cd31cfe Rework issue templates 2021-09-07 18:10:34 +02:00
Kelvin M. Klann
26d6744737 bug_report.md: add log section
Currently, the log portion seems to be part of the Checklist section.
2021-08-25 15:04:25 -03:00
Kelvin M. Klann
dc3859f345 bug_report.md: format the details section
And put the code block inside of an HTML paragraph, so that it's not
just free floating after the `<summary>`.
2021-08-25 15:04:25 -03:00
Kelvin M. Klann
06317bcdd2 bug_report.md: trim leading spaces on list items 2021-08-25 15:04:25 -03:00
Kelvin M. Klann
7b69b3ddcd bug_report.md: turn section titles into headers
This properly separates the document into sections and makes the titles
stand out more.  It is also more consistent with what is generated by
GitHub issue forms (YAML).

See also the following discussion:
https://github.com/netblue30/firejail/discussions/4468
2021-08-25 15:04:23 -03:00
Kelvin M. Klann
df766272bb bug_report.md: add missing blank lines
Isolate each section title and each list from other elements, to make
them more visually distinguishable.  This should also make it easier to
find and edit only the parts that are meant to be edited.

See also the following discussion:
https://github.com/netblue30/firejail/discussions/4468
2021-08-25 15:04:17 -03:00
Reiner Herrmann
07b85f39af CI: build with GCC 11
this fixes a new false positive memory leak (#4297), but unfortunately
opens a few new false positives (#4274).
therefore let it ignore memleak checks for now, until the detection
is a bit more stable in GCC.

Fixes: #4274, #4297
2021-05-23 11:48:27 +02:00
Reiner Herrmann
c9e7fe8ab3
CI: build with clang 11 (#4277) 2021-05-14 10:15:05 +02:00
rusty-snake
23ea15fd7b Add some more paths-ignore to build-extra.yml 2021-04-24 11:49:27 +02:00
rusty-snake
48b385c0ee
Improve issue template (#4141)
- Avoid confusing on "What changed calling the program by path"
 - Checklist: Questions should be asked in discussions
2021-03-25 16:46:05 +00:00
Ted Robertson
c94f678b1c
Fix typos 2021-03-13 19:39:40 -10:00
Ted Robertson
9c1bb05859
Improve English in the PR template 2021-03-11 11:20:33 -10:00
rusty-snake
bdabc874f3
Merge pull request #3985 from rusty-snake/sort.py-updates
Sort.py updates
2021-02-17 16:10:36 +00:00
Reiner Herrmann
1a559b92b8 CI: sync codeql config with Github's template
Fixes: #3986
2021-02-14 18:20:38 +01:00
rusty-snake
3ff0eb2e77 workflows/sort.yml: Run also if sort.py is changed 2021-02-14 09:04:35 +01:00
rusty-snake
091802e3c9 Remove skip ci if conndition from workflows
GitHub added native support for it, no need for this anymore.
https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/
2021-02-09 19:07:46 +01:00
Fred Barclay
ad0b7fc886 Housekeeping: strip extra whitespace
Just `find . -not \( -name .git -prune -o -name *.AppImage -prune \) -type f -print0 | xargs -0 perl -pi -e 's/ +$//'`
and filter to avoid unwanted changes (especially .md files)
2021-02-08 17:24:28 -06:00
Kelvin M. Klann
2c54e65ab0 bug_report.md: improve wording (upstream/duplicates)
Clarify that:

* "upstream profile" means the profile version on the master branch
* "duplicates" refer to duplicate issues

As suggested by @scruloose on
https://github.com/netblue30/firejail/issues/3884#issue-784605766
https://github.com/netblue30/firejail/issues/3884#issuecomment-759528185
2021-01-14 11:20:30 +00:00
rusty-snake
81bba6c7ee
Update bug_report.md 2020-12-08 09:30:05 +00:00
rusty-snake
4b0b7ec216
Update build.yml (#3779)
* Update build.yml

Currently we run all actions for all commits. This is not resource friendly. Let's tweak this a bit.

This commit adds support for "skip ci" tags (i.e. if the head commit contains [s k i p   c i] (w/o the extra spaces used to escape here), no jobs are executed.
In addition are all commits which modify non-code files (e.g. README) only excluded.

Furthermore we should not run cppcheck and scan-build if only profiles are changed and sort.py need only to be execute if profiles are changed.

* Create sort.yml

* Update build.yml

profile-sort is now in sort.yml

* Update sort.yml

fix syntax

* Update codeql-analysis.yml

    paths-ignore:
      - CONTRIBUTING.md
      - README
      - README.md  
      - RELNOTES
      - SECURITY.md
      - 'etc/**'

* Create build-extra.yml

* Update build.yml

* Update build-extra.yml
2020-11-29 14:04:22 +00:00
rusty-snake
f3585e5393 fixes, closes, enhances, improvements, and so on
- .github/ISSUE_TEMPLATE/bug_report.md: get ride off spanish,
   french, ... error messages
 - etc/inc/firefox-common-addons.inc: support ff2mpv
 - etc/profile-a-l/gimp.profile: note about xsane
 - etc/profile-m-z/min.profile: prettify
 - etc/profile-m-z/mpsyt.profile: fix, add lua
 - etc/profile-m-z/qbittorrent.profile: add note for tray-icons; this
   will get a better note once I investigated and audited all the D-Bus
   tray stuff.
 - etc/profile-m-z/transmission-daemon.profile: fix, add protocol packet

close #3686 - mps-youtube needs lua
close #3701 - Firefox native messaging regression in 0.9.62.4 -> 0.9.64rc1
close #3636 - transmission-daemon fills log with error
close #3640 - Gimp - add note how to enable scanning (xsane)
close #3707 - qBittorrent tray icon missing from notification panel when running it with firejail
2020-11-09 20:57:33 +01:00
Reiner Herrmann
03b9d9dedd Merge branch 'tests' into master 2020-10-25 13:58:26 +01:00
Reiner Herrmann
807af3dce0 check that profiles are sorted 2020-10-24 22:01:26 +02:00
Reiner Herrmann
300efec351 let github CI run tests 2020-10-24 21:44:57 +02:00
rusty-snake
eae5d42188
Update bug_report.md
Stop "mentioned"-notes in 1139.
2020-10-20 17:55:39 +00:00
Reiner Herrmann
6fd7e7318e build: enable CI build with scan-build 2020-10-14 17:47:01 +02:00
Reiner Herrmann
0fa11826b9 build: test build with apparmor and selinux in CI 2020-10-01 22:47:21 +02:00
Reiner Herrmann
88eb73edac build: enable clang-10 build in github CI 2020-10-01 22:30:56 +02:00
Reiner Herrmann
94e2ce275d
Create build.yml (#3651) 2020-10-01 19:55:27 +02:00
Reiner Herrmann
51f070ef2f
Create codeql-analysis.yml 2020-10-01 09:17:18 +00:00
rusty-snake
a0101dbf1d
Update bug_report.md
* Try to make it a bit more friendly for unskilled users.

* Add AppImage --profile hint
2020-09-23 17:43:09 +00:00
Jan
cf81b8e7b6 bug_template: more specific information like related programs, profile existence, lookup for installed profiles and user investigation on related problems 2020-05-04 13:57:51 +02:00
rusty-snake
2bd91a6c9d update issue template + add ICEauthority to wruc 2020-04-21 20:05:49 +02:00
Jan
482e3b100d early decision if git master 2020-04-09 15:12:45 +02:00