mirror of
https://github.com/debauchee/barrier.git
synced 2026-05-15 14:16:02 -06:00
[GH-ISSUE #1223] Super + : (shift + ;) is treated as Super + ; in the client #987
Labels
No labels
HiDPI
bounty
bsd/freebsd
bsd/openbsd
bug
bug
build-infra
cantfix
critical
doc
duplicate
enhancement
fix-available
from git
from release
good first issue
help wanted
installer/package
invalid
linux
macOS
meta
needs testing
pull-request
query
question
regression
regression
v2.4.0
windows
wontfix
work-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/barrier#987
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tom-tan on GitHub (Jul 4, 2021).
Original GitHub issue: https://github.com/debauchee/barrier/issues/1223
Describe the bug
As described in the title.
Barrier client successfully receives Super+
:virtual keys but it is decoded to Super +;keys (See Additional context section for details).To Reproduce
I used Windows server and macOS client.
Win + :in the client screenExpected behavior
A keystroke
Command + :is sent to the client.For example, if there exists a keyboard short cut for
Command + :, it is invoked.Actual behavior
A keystroke
Command + ;is sent to the client.A keyboard short cut for
Command + ;is invoked rather than a short cut forCommand + :.Desktop (please complete the following information):
Server:
Client:
Additional context
I confirmed the single colon (
:) is successfully treated as is in the client as follows.In this case, a virtual key code
0x3a(:) is decoded to the key stroke0x38+0x29(i.e., shift +;).Note:
0x0000003ais a virtual key code for:that is defined insrc/lib/barrier/key_types.cpp0x0038and0x0029are key codes forkVK_ShiftandkVK_ANSI_Semicolon, respectively.On the other hand, here is a debug log in the case of
Win + :.A virtual key code
:is decoded to the key stroke0x29and it lacks0x38.Note:
0x0010is a key modifierSuper(a.k.a.WinorCommandkey)@PhilCS commented on GitHub (Nov 5, 2021):
The problem comes from here. It seems... intentional?
69ec896e65/src/lib/barrier/KeyMap.cpp (L538-L551)