mirror of
https://github.com/debauchee/barrier.git
synced 2026-05-15 14:16:02 -06:00
[GH-ISSUE #1024] Barrier waits for the systray at startup when this isn't required as Qt can do this internally #813
Labels
No labels
HiDPI
bounty
bsd/freebsd
bsd/openbsd
bug
bug
build-infra
cantfix
critical
doc
duplicate
enhancement
fix-available
from git
from release
good first issue
help wanted
installer/package
invalid
linux
macOS
meta
needs testing
pull-request
query
question
regression
regression
v2.4.0
windows
wontfix
work-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/barrier#813
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ahayzen on GitHub (Jan 16, 2021).
Original GitHub issue: https://github.com/debauchee/barrier/issues/1024
Describe the bug
Barrier puts
QSystemTrayIcon::isSystemTrayAvailable()in a loop waiting for 10 seconds, this is a large amount of time to wait for a system which doesn't have a system tray. (d4382b9b80/src/gui/src/main.cpp (L129))Furthermore the Qt docs state that "If the system tray is currently unavailable but becomes available later, QSystemTrayIcon will automatically add an entry in the system tray if it is visible." https://doc.qt.io/qt-5/qsystemtrayicon.html#isSystemTrayAvailable
So it appears that this wait isn't required, as if the system tray becomes available later Qt will automatically show it.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
At step 3 I expected Barrier to instantly.
Desktop (please complete the following information):
@curiousercreative commented on GitHub (Mar 2, 2021):
@ahayzen any chance you can submit a PR for this? I'm experiencing this as well and can try to test a fix
@ahayzen commented on GitHub (Mar 2, 2021):
@curiousercreative I've created a pull request here https://github.com/debauchee/barrier/pull/1084 which changes how the waiting works, which should ensure good UX in the majority of cases. Feel free to test it :-)