github-starred/barrier

Fork 0

mirror of https://github.com/debauchee/barrier.git synced 2026-05-15 14:16:02 -06:00

[GH-ISSUE #87] Change "Interface" to "Address" #66

New issue

Closed

opened 2026-05-05 04:54:31 -06:00 by gitea-mirror · 6 comments

gitea-mirror commented

2026-05-05 04:54:31 -06:00

Owner

Originally created by @AdrianKoshka on GitHub (Jul 3, 2018).
Original GitHub issue: https://github.com/debauchee/barrier/issues/87

The word Interface is misleading, a user would think they would put an interface name here like enp1s0, eth0, etc. Though this isn't the case, instead the user is supposed to put an IP address here. I suggest the word Interface be changed to Address

Originally created by @AdrianKoshka on GitHub (Jul 3, 2018). Original GitHub issue: https://github.com/debauchee/barrier/issues/87 The word `Interface` is misleading, a user would think they would put an interface name here like `enp1s0`, `eth0`, etc. Though this isn't the case, instead the user is supposed to put an IP address here. I suggest the word `Interface` be changed to `Address` ![settings](https://user-images.githubusercontent.com/8690255/42197980-6f6512b2-7e53-11e8-93e1-87729612c66b.png)

gitea-mirror

2026-05-05 04:54:31 -06:00

closed this issue
added the
enhancement
label

gitea-mirror commented

2026-05-05 04:54:41 -06:00

Author

Owner

@W4RH4WK commented on GitHub (Jul 18, 2018):

Do you just intend to change the UI or should the underlying names of the controls be adapted accordingly?

@W4RH4WK commented on GitHub (Jul 18, 2018): Do you just intend to change the UI or should the underlying names of the controls be adapted accordingly?

gitea-mirror commented

2026-05-05 04:54:44 -06:00

Author

Owner

@AdrianKoshka commented on GitHub (Jul 18, 2018):

What do you mean? I know with barrierc and barriers, the verbage is address.

@AdrianKoshka commented on GitHub (Jul 18, 2018): What do you mean? I know with `barrierc` and `barriers`, the verbage is `address`.

gitea-mirror commented

2026-05-05 04:54:49 -06:00

Author

Owner

@W4RH4WK commented on GitHub (Jul 18, 2018):

Should only this line (and the related ones in the translation files) be changed:
https://github.com/debauchee/barrier/blob/master/src/gui/src/SettingsDialogBase.ui#L170

Or also the names, like m_pLineEditInterface over here:
https://github.com/debauchee/barrier/blob/master/src/gui/src/SettingsDialog.cpp#L47

Only chaning the label (+ translations) is probably better so that future patches can be migrated from Synergy easily.

@W4RH4WK commented on GitHub (Jul 18, 2018): Should only this line (and the related ones in the translation files) be changed: https://github.com/debauchee/barrier/blob/master/src/gui/src/SettingsDialogBase.ui#L170 Or also the names, like `m_pLineEditInterface` over here: https://github.com/debauchee/barrier/blob/master/src/gui/src/SettingsDialog.cpp#L47 Only chaning the label (+ translations) is probably better so that future patches can be migrated from Synergy easily.

gitea-mirror commented

2026-05-05 04:54:53 -06:00

Author

Owner

@AdrianKoshka commented on GitHub (Jul 18, 2018):

I would say only change the label.

@AdrianKoshka commented on GitHub (Jul 18, 2018): I would say only change the label.

gitea-mirror commented

2026-05-05 04:54:55 -06:00

Author

Owner

@nathan-teoh commented on GitHub (Jul 21, 2018):

I agree. I initially thought I had to enter eth0 into Interface.

@nathan-teoh commented on GitHub (Jul 21, 2018): I agree. I initially thought I had to enter eth0 into Interface.

gitea-mirror commented

2026-05-05 04:54:58 -06:00

Author

Owner

@walker0643 commented on GitHub (Sep 8, 2018):

fixed in b2aac6719f, though the translations still need to be updated (probably for many reasons apart from this change)

@walker0643 commented on GitHub (Sep 8, 2018): fixed in b2aac6719f374e254a3a7ec2a82a112f3e8d18cd, though the translations still need to be updated (probably for many reasons apart from this change)

gitea-mirror referenced this issue

2026-05-05 07:57:00 -06:00

[PR #250] [CLOSED] Add .appveyor.yml File With Ubuntu & Windows Builds #1588