github-starred/barrier

Fork 0

mirror of https://github.com/debauchee/barrier.git synced 2026-05-15 14:16:02 -06:00

[GH-ISSUE #277] Check to see if VS2019 works for building on windows. #224

New issue

Closed

opened 2026-05-05 05:43:39 -06:00 by gitea-mirror · 7 comments

gitea-mirror commented

2026-05-05 05:43:39 -06:00

Owner

Originally created by @AdrianKoshka on GitHub (Apr 3, 2019).
Original GitHub issue: https://github.com/debauchee/barrier/issues/277

Originally created by @AdrianKoshka on GitHub (Apr 3, 2019). Original GitHub issue: https://github.com/debauchee/barrier/issues/277

gitea-mirror

2026-05-05 05:43:39 -06:00

closed this issue
added the
windows

good first issue
labels

gitea-mirror commented

2026-05-05 05:43:46 -06:00

Author

Owner

@noisyshape commented on GitHub (Apr 10, 2019):

clean_build.bat has a hard coded cmake generator string for VS2017 and there is no Qt library specifically for VS2019 yet. Changing "Visual Studio 15 2017 Win64" to "Visual Studio 16 2019" allows for a successful build. I'm running the binaries as both client and server and they seem to be fine.

@noisyshape commented on GitHub (Apr 10, 2019): clean_build.bat has a hard coded cmake generator string for VS2017 and there is no Qt library specifically for VS2019 yet. Changing ``"Visual Studio 15 2017 Win64"`` to ``"Visual Studio 16 2019"`` allows for a successful build. I'm running the binaries as both client and server and they seem to be fine.

gitea-mirror commented

2026-05-05 05:43:48 -06:00

Author

Owner

@AdrianKoshka commented on GitHub (Apr 10, 2019):

You do get a clean build? Odd, I remember changing that and only getting errors.

@AdrianKoshka commented on GitHub (Apr 10, 2019): You do get a clean build? Odd, I remember changing that and only getting errors.

gitea-mirror commented

2026-05-05 05:43:50 -06:00

Author

Owner

@noisyshape commented on GitHub (Apr 10, 2019):

I get 3 warnings, but I think they're the same warnings I get with VS2017. The only other change I made was setting the Qt version to 5.12.2. Try building again off of master and post the errors if you get any.

@noisyshape commented on GitHub (Apr 10, 2019): I get 3 warnings, but I think they're the same warnings I get with VS2017. The only other change I made was setting the Qt version to 5.12.2. Try building again off of master and post the errors if you get any.

gitea-mirror commented

2026-05-05 05:43:52 -06:00

Author

Owner

@AdrianKoshka commented on GitHub (Apr 10, 2019):

Ah, I was building off tag v2.1.2.

@AdrianKoshka commented on GitHub (Apr 10, 2019): Ah, I was building off tag `v2.1.2`.

gitea-mirror commented

2026-05-05 05:43:54 -06:00

Author

Owner

@AdrianKoshka commented on GitHub (Apr 10, 2019):

A PR to update clean_build.bat to compile against vs2019 would be appreciated, if you want to that is.

@AdrianKoshka commented on GitHub (Apr 10, 2019): A PR to update `clean_build.bat` to compile against vs2019 would be appreciated, if you want to that is.

gitea-mirror commented

2026-05-05 05:43:56 -06:00

Author

Owner

@noisyshape commented on GitHub (Apr 10, 2019):

Done. It looks like the Appveyor is getting a bad argument, however.

@noisyshape commented on GitHub (Apr 10, 2019): Done. It looks like the Appveyor is getting a bad argument, however.

gitea-mirror commented

2026-05-05 05:43:58 -06:00

Author

Owner

@AdrianKoshka commented on GitHub (Apr 10, 2019):