github-starred/barrier

Fork 0

mirror of https://github.com/debauchee/barrier.git synced 2026-05-15 22:01:23 -06:00

[GH-ISSUE #248] Version info in v2.1.2 is wrong #199

New issue

Closed

opened 2026-05-05 05:39:51 -06:00 by gitea-mirror · 9 comments

gitea-mirror commented

2026-05-05 05:39:51 -06:00

Owner

Originally created by @kakra on GitHub (Feb 4, 2019).
Original GitHub issue: https://github.com/debauchee/barrier/issues/248

These lines in v2.1.2 tag are wrong:
53ebc47ace/cmake/Version.cmake (L4)

Probably a merge glitch that slipped through...

Building this version results in the binary identifying itself as 2.2.0 while it isn't. I think this problem has also been there already in a previous version.

Originally created by @kakra on GitHub (Feb 4, 2019). Original GitHub issue: https://github.com/debauchee/barrier/issues/248 These lines in v2.1.2 tag are wrong: https://github.com/debauchee/barrier/blob/53ebc47ace7486d0b7ba975e58506c4a9f28acd6/cmake/Version.cmake#L4 Probably a merge glitch that slipped through... Building this version results in the binary identifying itself as 2.2.0 while it isn't. I think this problem has also been there already in a previous version.

gitea-mirror

2026-05-05 05:39:51 -06:00

closed this issue
added the
enhancement

installer/package
labels

gitea-mirror commented

2026-05-05 05:39:58 -06:00

Author

Owner

@AdrianKoshka commented on GitHub (Feb 4, 2019):

Yeah, forgot to update some metadata.

@AdrianKoshka commented on GitHub (Feb 4, 2019): Yeah, forgot to update some metadata.

gitea-mirror commented

2026-05-05 05:40:00 -06:00

Author

Owner

@yjqg6666 commented on GitHub (May 7, 2019):

so is the release version which should be 2.1.2 instead of 2.2.0.

@yjqg6666 commented on GitHub (May 7, 2019): so is the release version which should be 2.1.2 instead of 2.2.0.

gitea-mirror commented

2026-05-05 05:40:02 -06:00

Author

Owner

@parkerlreed commented on GitHub (Jun 7, 2019):

Yeah 2.2.0 still links to https://github.com/debauchee/barrier/archive/v2.1.2.tar.gz

@parkerlreed commented on GitHub (Jun 7, 2019): Yeah 2.2.0 still links to https://github.com/debauchee/barrier/archive/v2.1.2.tar.gz

gitea-mirror commented

2026-05-05 05:40:05 -06:00

Author

Owner

@AdrianKoshka commented on GitHub (Jun 7, 2019):

Yeah…it's not high priority and I'm on vacation right now…

@AdrianKoshka commented on GitHub (Jun 7, 2019): Yeah…it's not high priority and I'm on vacation right now…

gitea-mirror commented

2026-05-05 05:40:07 -06:00

Author

Owner

@mirh commented on GitHub (Aug 14, 2019):

This is fixed.. I guess?

@mirh commented on GitHub (Aug 14, 2019): This is fixed.. I guess?

gitea-mirror commented

2026-05-05 05:40:09 -06:00

Author

Owner

@shymega commented on GitHub (Aug 14, 2019):

As of commit 8e8b38b493, the version tag has been updated to 2.3.0. I can see from commit 73c13ab023, the version tag is 2.2.0.

@walker0643 How can we fix this? I'd rather not rewrite the Git history, but I'm not convinced there's any other way, given the nature of Git.

@shymega commented on GitHub (Aug 14, 2019): As of commit 8e8b38b493d031f5007bebc44e8f767482e41fb6, the version tag has been updated to 2.3.0. I can see from commit 73c13ab023399f6d181644f3b1360eba07914571, the version tag is 2.2.0. @walker0643 How can we fix this? I'd rather _not_ rewrite the Git history, but I'm not convinced there's any other way, given the nature of Git.

gitea-mirror commented

2026-05-05 05:40:11 -06:00

Author

Owner

@mirh commented on GitHub (Aug 14, 2019):

... I don't know which commits you are picking up, but it seems just right here
https://github.com/debauchee/barrier/blob/v2.3.1/cmake/Version.cmake

@mirh commented on GitHub (Aug 14, 2019): ... I don't know which commits you are picking up, but it seems just right here https://github.com/debauchee/barrier/blob/v2.3.1/cmake/Version.cmake

gitea-mirror commented

2026-05-05 05:40:14 -06:00

Author

Owner

@shymega commented on GitHub (Aug 14, 2019):

Didn't look look like it from my end.

@shymega commented on GitHub (Aug 14, 2019): Didn't look look like it from my end.

gitea-mirror commented

2026-05-05 05:40:17 -06:00

Author

Owner

@shymega commented on GitHub (Aug 14, 2019):

Ah.. I've just seen my repo is a few commits behind 😅 I guess we can close this issue now.

@shymega commented on GitHub (Aug 14, 2019): Ah.. I've just seen my repo is a few commits behind 😅 I guess we can close this issue now.

No labels

Rows
Columns