[PR #1904] fixed X11 clipboard issues, added size limit, added webp/tiff/png/jpg #1836

Open
opened 2026-05-05 08:02:55 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1904
Author: @draekko
Created: 2/20/2023
Status: 🔄 Open

Base: masterHead: master


📝 Commits (5)

  • c225716 fixed X11 clipboard issues, added support for size limit, added image support for webp/tiff/png/jpg
  • 490e239 add missing converters
  • 5204629 adds missing features doc as per readme for PR
  • 9c41922 add missing checks in motif to prevent leaking image data to text targets
  • 3c60417 clarification on setting clipboardSharingSize option

📊 Changes

27 files changed (+633 additions, -65 deletions)

View changed files

doc/newsfragments/adds-clipboard-memory-limit.feature (+7 -0)
📝 src/gui/src/ServerConfig.cpp (+19 -0)
📝 src/gui/src/ServerConfig.h (+5 -1)
📝 src/gui/src/ServerConfigDialog.cpp (+3 -0)
📝 src/gui/src/ServerConfigDialogBase.ui (+62 -43)
📝 src/lib/barrier/IClipboard.h (+6 -2)
📝 src/lib/barrier/option_types.h (+1 -0)
📝 src/lib/client/Client.cpp (+20 -2)
📝 src/lib/client/Client.h (+1 -0)
📝 src/lib/platform/XWindowsClipboard.cpp (+66 -13)
📝 src/lib/platform/XWindowsClipboardAnyBitmapConverter.cpp (+4 -0)
📝 src/lib/platform/XWindowsClipboardBMPConverter.cpp (+8 -0)
📝 src/lib/platform/XWindowsClipboardHTMLConverter.cpp (+4 -0)
src/lib/platform/XWindowsClipboardJPGConverter.h (+40 -0)
src/lib/platform/XWindowsClipboardPNGConverter.cpp (+72 -0)
src/lib/platform/XWindowsClipboardPNGConverter.h (+40 -0)
src/lib/platform/XWindowsClipboardTIFConverter.cpp (+77 -0)
src/lib/platform/XWindowsClipboardTIFConverter.h (+40 -0)
📝 src/lib/platform/XWindowsClipboardTextConverter.cpp (+4 -0)
📝 src/lib/platform/XWindowsClipboardUCS2Converter.cpp (+4 -0)

...and 7 more files

📄 Description

This fixes X11 to X11 issues, prevents images from leaking to text targets, adds size limits if someone wants to limit clipboard transfers, adds converters for webp, tiff, png, jpg. PNG is need to properly transfer images copy pasted or from gimp on one machine to the next under an X11 to X11 scenario for use in other apps.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1904 **Author:** [@draekko](https://github.com/draekko) **Created:** 2/20/2023 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`c225716`](https://github.com/debauchee/barrier/commit/c22571658dd41fe9460941d8b8021574416f9719) fixed X11 clipboard issues, added support for size limit, added image support for webp/tiff/png/jpg - [`490e239`](https://github.com/debauchee/barrier/commit/490e23946454b572c2ea7e78959bba7674461cb0) add missing converters - [`5204629`](https://github.com/debauchee/barrier/commit/52046298a6e97779a901d86c97a2259bdf4d4b88) adds missing features doc as per readme for PR - [`9c41922`](https://github.com/debauchee/barrier/commit/9c41922b33303de6f6b9b562c89bdc84ee81605d) add missing checks in motif to prevent leaking image data to text targets - [`3c60417`](https://github.com/debauchee/barrier/commit/3c60417c0e532923a126b6086b6bb5a187724ee6) clarification on setting clipboardSharingSize option ### 📊 Changes **27 files changed** (+633 additions, -65 deletions) <details> <summary>View changed files</summary> ➕ `doc/newsfragments/adds-clipboard-memory-limit.feature` (+7 -0) 📝 `src/gui/src/ServerConfig.cpp` (+19 -0) 📝 `src/gui/src/ServerConfig.h` (+5 -1) 📝 `src/gui/src/ServerConfigDialog.cpp` (+3 -0) 📝 `src/gui/src/ServerConfigDialogBase.ui` (+62 -43) 📝 `src/lib/barrier/IClipboard.h` (+6 -2) 📝 `src/lib/barrier/option_types.h` (+1 -0) 📝 `src/lib/client/Client.cpp` (+20 -2) 📝 `src/lib/client/Client.h` (+1 -0) 📝 `src/lib/platform/XWindowsClipboard.cpp` (+66 -13) 📝 `src/lib/platform/XWindowsClipboardAnyBitmapConverter.cpp` (+4 -0) 📝 `src/lib/platform/XWindowsClipboardBMPConverter.cpp` (+8 -0) 📝 `src/lib/platform/XWindowsClipboardHTMLConverter.cpp` (+4 -0) ➕ `src/lib/platform/XWindowsClipboardJPGConverter.h` (+40 -0) ➕ `src/lib/platform/XWindowsClipboardPNGConverter.cpp` (+72 -0) ➕ `src/lib/platform/XWindowsClipboardPNGConverter.h` (+40 -0) ➕ `src/lib/platform/XWindowsClipboardTIFConverter.cpp` (+77 -0) ➕ `src/lib/platform/XWindowsClipboardTIFConverter.h` (+40 -0) 📝 `src/lib/platform/XWindowsClipboardTextConverter.cpp` (+4 -0) 📝 `src/lib/platform/XWindowsClipboardUCS2Converter.cpp` (+4 -0) _...and 7 more files_ </details> ### 📄 Description This fixes X11 to X11 issues, prevents images from leaking to text targets, adds size limits if someone wants to limit clipboard transfers, adds converters for webp, tiff, png, jpg. PNG is need to properly transfer images copy pasted or from gimp on one machine to the next under an X11 to X11 scenario for use in other apps. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror added the
pull-request
label 2026-05-05 08:02:55 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/barrier#1836
No description provided.