[PR #1827] Fix out-of-bounds access in XWindowsScreen::updateButtons #1831

New issue

Open

opened 2026-05-05 08:02:50 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:02:50 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1827
Author: @DuBistKomisch
Created: 11/6/2022
Status: 🔄 Open

Base: master ← Head: fix-linux-out-of-bounds

📝 Commits (1)

9cfd521 Fix out-of-bounds access in XWindowsScreen::updateButtons

📊 Changes

2 files changed (+5 additions, -5 deletions)

View changed files

📝 src/lib/platform/XWindowsScreen.cpp (+4 -4)
📝 src/lib/platform/XWindowsScreen.h (+1 -1)

📄 Description

This code triggers an assertion in gcc's std_vector.h on my system due to a logical button 0 causing a write to m_buttons[-1], and a SIGABRT.

I've tried to make this code do what it seems to be intended to do, but m_buttons isn't actually read from anywhere anyway.

Contributor Checklist:

I have created a file in the doc/newsfragments directory IF it is a
user-visible change (and make sure to read the README.md in that directory)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1827 **Author:** [@DuBistKomisch](https://github.com/DuBistKomisch) **Created:** 11/6/2022 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix-linux-out-of-bounds` --- ### 📝 Commits (1) - [`9cfd521`](https://github.com/debauchee/barrier/commit/9cfd521ae1c3442c672251d13b2bbca18cfe3d25) Fix out-of-bounds access in XWindowsScreen::updateButtons ### 📊 Changes **2 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/platform/XWindowsScreen.cpp` (+4 -4) 📝 `src/lib/platform/XWindowsScreen.h` (+1 -1) </details> ### 📄 Description This code triggers an assertion in gcc's std_vector.h on my system due to a logical button 0 causing a write to m_buttons[-1], and a SIGABRT. I've tried to make this code do what it seems to be intended to do, but m_buttons isn't actually read from anywhere anyway. ## Contributor Checklist: * [ ] I have created a file in the `doc/newsfragments` directory *IF* it is a user-visible change (and make sure to read the `README.md` in that directory) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>