[PR #1711] Fix Broken Tilde and Grave (Backtick/Backquote) (regression bugfix) #1826

New issue

Open

opened 2026-05-05 08:02:43 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:02:43 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1711
Author: @dgentry
Created: 7/6/2022
Status: 🔄 Open

Base: master ← Head: fix_missing_tilde

📝 Commits (3)

ed37361 Fix Broken Tilde and Grave (Backtick/Backquote)
645a0c9 Remove no-longer-possible Mojave build from azure
ee11f5c Remove Windows-breaking change that fixes Mac-warnings

📊 Changes

3 files changed (+8 additions, -6 deletions)

View changed files

📝 azure-pipelines.yml (+5 -4)
➕ doc/newsfragments/1541-fix-broken-tilde-and-grave (+3 -0)
📝 src/lib/platform/OSXKeyState.cpp (+0 -2)

📄 Description

This is nearly a duplicate PR to vladimirlagunov's PR #1541, which seems to have stalled. This PR doesn't have Azure attempt to build for MacOS 10.14, because Azure removed the MacOS 10.14 image in Dec 2021. This PR fixes #1531 and #1407.

This regression was introduced in PR #1214 and broke tilde (~) and grave/backtick/backquote (`) on MacOS Barrier servers.

If the author of the regression-introducing PR (1241) wants to enable tilde and grave as modifier keys on JIS keyboards, it would be possible in a non-breaking way by checking for the keyboard type before adding these as modifier keys.

Contributor Checklist:

I have created a file in the doc/newsfragments directory IF it is a
user-visible change (and make sure to read the README.md in that directory)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1711 **Author:** [@dgentry](https://github.com/dgentry) **Created:** 7/6/2022 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix_missing_tilde` --- ### 📝 Commits (3) - [`ed37361`](https://github.com/debauchee/barrier/commit/ed373612b7cb1705ab3de0d2a500f9ba1781e2d8) Fix Broken Tilde and Grave (Backtick/Backquote) - [`645a0c9`](https://github.com/debauchee/barrier/commit/645a0c9d569d5583f38ab1fb1dae669611174c98) Remove no-longer-possible Mojave build from azure - [`ee11f5c`](https://github.com/debauchee/barrier/commit/ee11f5cafaffd034533aa1c13ff164e98f1a950e) Remove Windows-breaking change that fixes Mac-warnings ### 📊 Changes **3 files changed** (+8 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `azure-pipelines.yml` (+5 -4) ➕ `doc/newsfragments/1541-fix-broken-tilde-and-grave` (+3 -0) 📝 `src/lib/platform/OSXKeyState.cpp` (+0 -2) </details> ### 📄 Description This is nearly a duplicate PR to [vladimirlagunov](https://github.com/vladimirlagunov)'s PR #1541, which seems to have stalled. This PR doesn't have Azure attempt to build for MacOS 10.14, because Azure removed the MacOS 10.14 image in Dec 2021. This PR fixes #1531 and #1407. This regression was introduced in [PR #1214](https://github.com/debauchee/barrier/pull/1214) and broke tilde (~) and grave/backtick/backquote (`) on MacOS Barrier servers. If the author of the regression-introducing PR (1241) wants to enable tilde and grave as modifier keys on JIS keyboards, it would be possible in a non-breaking way by checking for the keyboard type before adding these as modifier keys. ## Contributor Checklist: * [x] I have created a file in the `doc/newsfragments` directory *IF* it is a user-visible change (and make sure to read the `README.md` in that directory) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>