[PR #1626] Allow changing screens from non-rectangular multi-monitor setups #1820

New issue

Open

opened 2026-05-05 08:02:39 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:02:39 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1626
Author: @vjpr
Created: 3/31/2022
Status: 🔄 Open

Base: master ← Head: u/vr/feat/multi-monitor

📝 Commits (1)

810bf79 Multi-monitor working for up/down directions to/from macOS.

📊 Changes

18 files changed (+231 additions, -29 deletions)

View changed files

➕ src/lib/barrier/Display.h (+12 -0)
📝 src/lib/barrier/IScreen.h (+3 -0)
📝 src/lib/barrier/PlatformScreen.h (+3 -3)
📝 src/lib/barrier/Screen.cpp (+5 -0)
📝 src/lib/barrier/Screen.h (+1 -0)
📝 src/lib/client/Client.cpp (+6 -0)
📝 src/lib/client/Client.h (+1 -0)
📝 src/lib/platform/OSXScreen.h (+5 -0)
📝 src/lib/platform/OSXScreen.mm (+23 -0)
📝 src/lib/server/BaseClientProxy.h (+1 -0)
📝 src/lib/server/ClientProxy1_0.cpp (+9 -0)
📝 src/lib/server/ClientProxy1_0.h (+1 -0)
📝 src/lib/server/ClientProxy1_6.cpp (+8 -0)
📝 src/lib/server/ClientProxy1_6.h (+1 -0)
📝 src/lib/server/PrimaryClient.cpp (+12 -0)
📝 src/lib/server/PrimaryClient.h (+1 -0)
📝 src/lib/server/Server.cpp (+138 -25)
📝 src/lib/server/Server.h (+1 -1)

📄 Description

Status

This is an incomplete draft.

Currently only implemented for up/down from a macOS primary display (my setup).

Reference

#1112

Todo

Create a new protocol version to allow sending information about display dimensions and origins.
Implement and test left/right.
Implement Windows and Linux display retrieval code.
Remove hard-coded macos-specific code from Server.cpp.
Extract display detection code into separate functions/files.

Allow setting the positioning of one screen's displays relative to another screen's
This is possible with range config setting but only for percentages at the moment.
See links (https://symless.com/help-articles/creating-text-config-files).

Contributor Checklist:

I have created a file in the doc/newsfragments directory IF it is a
user-visible change (and make sure to read the README.md in that directory)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1626 **Author:** [@vjpr](https://github.com/vjpr) **Created:** 3/31/2022 **Status:** 🔄 Open **Base:** `master` ← **Head:** `u/vr/feat/multi-monitor` --- ### 📝 Commits (1) - [`810bf79`](https://github.com/debauchee/barrier/commit/810bf794566c626e8f89e1bd0b867844fb5ffec4) Multi-monitor working for up/down directions to/from macOS. ### 📊 Changes **18 files changed** (+231 additions, -29 deletions) <details> <summary>View changed files</summary> ➕ `src/lib/barrier/Display.h` (+12 -0) 📝 `src/lib/barrier/IScreen.h` (+3 -0) 📝 `src/lib/barrier/PlatformScreen.h` (+3 -3) 📝 `src/lib/barrier/Screen.cpp` (+5 -0) 📝 `src/lib/barrier/Screen.h` (+1 -0) 📝 `src/lib/client/Client.cpp` (+6 -0) 📝 `src/lib/client/Client.h` (+1 -0) 📝 `src/lib/platform/OSXScreen.h` (+5 -0) 📝 `src/lib/platform/OSXScreen.mm` (+23 -0) 📝 `src/lib/server/BaseClientProxy.h` (+1 -0) 📝 `src/lib/server/ClientProxy1_0.cpp` (+9 -0) 📝 `src/lib/server/ClientProxy1_0.h` (+1 -0) 📝 `src/lib/server/ClientProxy1_6.cpp` (+8 -0) 📝 `src/lib/server/ClientProxy1_6.h` (+1 -0) 📝 `src/lib/server/PrimaryClient.cpp` (+12 -0) 📝 `src/lib/server/PrimaryClient.h` (+1 -0) 📝 `src/lib/server/Server.cpp` (+138 -25) 📝 `src/lib/server/Server.h` (+1 -1) </details> ### 📄 Description ## Status This is an incomplete draft. Currently only implemented for up/down from a macOS primary display (my setup). ## Reference #1112 ## Todo - [ ] Create a new protocol version to allow sending information about display dimensions and origins. - [ ] Implement and test left/right. - [ ] Implement Windows and Linux display retrieval code. - [ ] Remove hard-coded macos-specific code from `Server.cpp`. - [ ] Extract display detection code into separate functions/files. ## Related Features - [ ] Allow setting the positioning of one screen's displays relative to another screen's This is possible with range config setting but only for percentages at the moment. See links (https://symless.com/help-articles/creating-text-config-files). ## Contributor Checklist: * [ ] I have created a file in the `doc/newsfragments` directory *IF* it is a user-visible change (and make sure to read the `README.md` in that directory) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>