[PR #1562] add macOS 12/SDK version check (M1 fix) #1817

Open
opened 2026-05-05 08:02:33 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1562
Author: @thejasonfisher
Created: 2/11/2022
Status: 🔄 Open

Base: masterHead: master


📝 Commits (1)

  • afe950d add macOS 12/SDK version check

📊 Changes

2 files changed (+12 additions, -3 deletions)

View changed files

📝 CMakeLists.txt (+2 -2)
📝 clean_build.sh (+10 -1)

📄 Description

Build was breaking on 12.x or with the new Xcode --

  • Incorporated a change to use brew to get the openssl path
  • Added tests for 12.x with a fallback to 10.9 deploy target (must match openssl deploy target)
  • Added tests for new MacOS.sdk location with fallback to old
  • Built and tested with: export B_BUILD_TYPE=Release ./clean_build.sh
  • Self-signed with: codesign --force --deep --sign - /Applications/Barrier.app

This shouldn't change anything user-facing, i.e. break compatibility with older versions, but I have not tested that yet. This works on my M1 MacBook Air as a native Apple Silicon app.

Contributor Checklist:

  • I have created a file in the doc/newsfragments directory IF it is a
    user-visible change (and make sure to read the README.md in that directory)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1562 **Author:** [@thejasonfisher](https://github.com/thejasonfisher) **Created:** 2/11/2022 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`afe950d`](https://github.com/debauchee/barrier/commit/afe950d11e6fad01c1caf2651ea70db6e575ff1d) add macOS 12/SDK version check ### 📊 Changes **2 files changed** (+12 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+2 -2) 📝 `clean_build.sh` (+10 -1) </details> ### 📄 Description Build was breaking on 12.x or with the new Xcode -- - Incorporated a change to use brew to get the openssl path - Added tests for 12.x with a fallback to 10.9 deploy target (must match openssl deploy target) - Added tests for new MacOS.sdk location with fallback to old - Built and tested with: export B_BUILD_TYPE=Release ./clean_build.sh - Self-signed with: codesign --force --deep --sign - /Applications/Barrier.app This shouldn't change anything user-facing, i.e. break compatibility with older versions, but I have not tested that yet. This works on my M1 MacBook Air as a native Apple Silicon app. ## Contributor Checklist: * [ ] I have created a file in the `doc/newsfragments` directory *IF* it is a user-visible change (and make sure to read the `README.md` in that directory) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror added the
pull-request
label 2026-05-05 08:02:33 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/barrier#1817
No description provided.