[PR #1541] Fix #1531: Revert control key remapping from grave/tilde to zenkaku #1814

New issue

Open

opened 2026-05-05 08:02:32 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:02:32 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1541
Author: @vladimirlagunov
Created: 1/26/2022
Status: 🔄 Open

Base: master ← Head: revert-zenkaku

📝 Commits (1)

4fa7f25 Fix #1531: Revert control key remapping from grave/tilde to zenkaku

📊 Changes

3 files changed (+3 additions, -2 deletions)

View changed files

➕ doc/newsfragments/1531_remove_zenkaku_remapping.bugfix (+1 -0)
➕ doc/newsfragments/1531_zenkaku_remapping.removal (+1 -0)
📝 src/lib/platform/OSXKeyState.cpp (+1 -2)

📄 Description

The bug was introduced in the pull request #1214, and even in the description of the request it had been acknowledged that there is no such key on mac keyboards.

As a consequence, it led to inability to transfer the grave accent and and the tilde, at least from macOS to Windows on default "ABC" keyboard layout.

Unfortunately, I don't have a JIS keyboard, nor understand how to use it. The only thing I can suggest now is to revert the controversial remapping.

Contributor Checklist:

I have created a file in the doc/newsfragments directory IF it is a
user-visible change (and make sure to read the README.md in that directory)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1541 **Author:** [@vladimirlagunov](https://github.com/vladimirlagunov) **Created:** 1/26/2022 **Status:** 🔄 Open **Base:** `master` ← **Head:** `revert-zenkaku` --- ### 📝 Commits (1) - [`4fa7f25`](https://github.com/debauchee/barrier/commit/4fa7f250c7042d8236b080f0ce6223ab282f9079) Fix #1531: Revert control key remapping from grave/tilde to zenkaku ### 📊 Changes **3 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `doc/newsfragments/1531_remove_zenkaku_remapping.bugfix` (+1 -0) ➕ `doc/newsfragments/1531_zenkaku_remapping.removal` (+1 -0) 📝 `src/lib/platform/OSXKeyState.cpp` (+1 -2) </details> ### 📄 Description The bug was introduced in the pull request #1214, and even in the description of the request it had been acknowledged that there is no such key on mac keyboards. As a consequence, it led to inability to transfer the grave accent and and the tilde, at least from macOS to Windows on default "ABC" keyboard layout. Unfortunately, I don't have a JIS keyboard, nor understand how to use it. The only thing I can suggest now is to revert the controversial remapping. ## Contributor Checklist: * [x] I have created a file in the `doc/newsfragments` directory *IF* it is a user-visible change (and make sure to read the `README.md` in that directory) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>