[PR #1425] [MERGED] Fix issue with generation of new certificate #1809

New issue

Closed

opened 2026-05-05 08:02:25 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:02:25 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1425
Author: @albertony
Created: 11/12/2021
Status: ✅ Merged
Merged: 11/12/2021
Merged by: @walker0643

Base: master ← Head: cert-gen-fix

📝 Commits (1)

20a1bd2 Fix issue with generation of new certificate

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/lib/net/SecureUtils.cpp (+1 -1)

📄 Description

Barrier did not create a new certificate when testing a fresh install of v2.4 on a Windows VM. There are several issues reported on the same. After inspecting the code, it seems to me the abvious reason is that the file handle supplied to PEM_write_PrivateKey is opened for read-only.

Contributor Checklist:

I have created a file in the doc/newsfragments directory IF it is a
user-visible change (and make sure to read the README.md in that directory)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1425 **Author:** [@albertony](https://github.com/albertony) **Created:** 11/12/2021 **Status:** ✅ Merged **Merged:** 11/12/2021 **Merged by:** [@walker0643](https://github.com/walker0643) **Base:** `master` ← **Head:** `cert-gen-fix` --- ### 📝 Commits (1) - [`20a1bd2`](https://github.com/debauchee/barrier/commit/20a1bd2e4c8b019eb9ab9e11267e3f22c08b59f4) Fix issue with generation of new certificate ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/net/SecureUtils.cpp` (+1 -1) </details> ### 📄 Description Barrier did not create a new certificate when testing a fresh install of v2.4 on a Windows VM. There are several issues reported on the same. After inspecting the code, it seems to me the abvious reason is that the file handle supplied to `PEM_write_PrivateKey` is opened for read-only. Related: https://github.com/debauchee/barrier/issues/1377#issuecomment-965129129 ## Contributor Checklist: * [x] I have created a file in the `doc/newsfragments` directory *IF* it is a user-visible change (and make sure to read the `README.md` in that directory) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>