[PR #1403] [MERGED] Clarify PR template with regards to user-visible changes #1806

New issue

Closed

opened 2026-05-05 08:02:19 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:02:19 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1403
Author: @shymega
Created: 11/5/2021
Status: ✅ Merged
Merged: 11/6/2021
Merged by: @shymega

Base: master ← Head: fix/template/pull-request-template-clarify

📝 Commits (1)

37e7741 Clarify PR template with regards to user-visible changes to Barrier

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 .github/PULL_REQUEST_TEMPLATE.md (+2 -1)

📄 Description

I've made the PR template clarify the need for the newsfragment to be created if the PR is a user-visible change. For example, I had made a PR that modified the CI configuration. GIven this isn't a user-visible change, @p12tic gave feedback that the template should make that clear.

Therefore, this PR addresses that feedback.

Contributor Checklist:

I have created a file in the doc/newsfragments directory (and read the README.md in that directory)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1403 **Author:** [@shymega](https://github.com/shymega) **Created:** 11/5/2021 **Status:** ✅ Merged **Merged:** 11/6/2021 **Merged by:** [@shymega](https://github.com/shymega) **Base:** `master` ← **Head:** `fix/template/pull-request-template-clarify` --- ### 📝 Commits (1) - [`37e7741`](https://github.com/debauchee/barrier/commit/37e77419423e92b4bace3fde1d57975040a31499) Clarify PR template with regards to user-visible changes to Barrier ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/PULL_REQUEST_TEMPLATE.md` (+2 -1) </details> ### 📄 Description I've made the PR template clarify the need for the newsfragment to be created **if** the PR is a user-visible change. For example, I had made a PR that modified the CI configuration. GIven this isn't a user-visible change, @p12tic gave feedback that the template should make that clear. Therefore, this PR addresses that feedback. ## Contributor Checklist: * [x] I have created a file in the `doc/newsfragments` directory (and read the `README.md` in that directory) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>