[PR #1370] [CLOSED] Use standard mutex primitives throughout the codebase #1797

New issue

Closed

opened 2026-05-05 08:02:06 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:02:06 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1370
Author: @p12tic
Created: 11/3/2021
Status: ❌ Closed

Base: master ← Head: use-std-mutex

📝 Commits (10+)

cd356d7 arch: Use standard mutex utilities as underlying implementation
9e7982f lib: Switch ArchMutexLock to use std::unique_lock behind the scenes
8586b0a lib/arch: Use standard mutex primitives in BSD network impl
62913ab lib/barrier: Remove unused code
c16581b lib/base: Rename m_mutex to mutex_ in EventQueue
cb69469 lib/base: Use standard mutex primitives in EventQueue
27de30e lib/base: Use standard mutex primitives in event queue buffer
cbf22ad lib/net: Use standard mutex primitives in socket multiplexer
836a65c lib/net: Use standard mutex primitives in TCP socket code
489f45f lib/arch: Add IArchMultithread::wait_cond_var() for standard mutex

📊 Changes

52 files changed (+346 additions, -1405 deletions)

View changed files

📝 src/lib/arch/Arch.h (+2 -16)
➕ src/lib/arch/IArchMultithread.cpp (+50 -0)
📝 src/lib/arch/IArchMultithread.h (+9 -72)
📝 src/lib/arch/unix/ArchMultithreadPosix.cpp (+0 -156)
📝 src/lib/arch/unix/ArchMultithreadPosix.h (+0 -19)
📝 src/lib/arch/unix/ArchNetworkBSD.cpp (+19 -29)
📝 src/lib/arch/unix/ArchNetworkBSD.h (+2 -1)
📝 src/lib/arch/win32/ArchDaemonWindows.cpp (+14 -34)
📝 src/lib/arch/win32/ArchDaemonWindows.h (+4 -2)
📝 src/lib/arch/win32/ArchMultithreadWindows.cpp (+33 -186)
📝 src/lib/arch/win32/ArchMultithreadWindows.h (+2 -24)
📝 src/lib/arch/win32/ArchNetworkWinsock.cpp (+10 -18)
📝 src/lib/arch/win32/ArchNetworkWinsock.h (+3 -1)
📝 src/lib/arch/win32/ArchTaskBarWindows.cpp (+15 -36)
📝 src/lib/arch/win32/ArchTaskBarWindows.h (+4 -2)
📝 src/lib/barrier/ClientTaskBarReceiver.cpp (+0 -1)
📝 src/lib/barrier/PacketStreamFilter.cpp (+8 -9)
📝 src/lib/barrier/PacketStreamFilter.h (+3 -2)
📝 src/lib/barrier/PortableTaskBarReceiver.cpp (+0 -1)
📝 src/lib/barrier/ServerTaskBarReceiver.cpp (+0 -1)

...and 32 more files

📄 Description

This PR replaces homegrown mutex and condition variable classes with what's available in the C++11 standard library. This will reduce maintenance effort going forward.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1370 **Author:** [@p12tic](https://github.com/p12tic) **Created:** 11/3/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `use-std-mutex` --- ### 📝 Commits (10+) - [`cd356d7`](https://github.com/debauchee/barrier/commit/cd356d7c3d39fc95b827db441362ce60e05cea58) arch: Use standard mutex utilities as underlying implementation - [`9e7982f`](https://github.com/debauchee/barrier/commit/9e7982f8ec91e05dbdb19cd254809cc802f03cd9) lib: Switch ArchMutexLock to use std::unique_lock behind the scenes - [`8586b0a`](https://github.com/debauchee/barrier/commit/8586b0a58166c5b85531a651194e75197ef7ecb0) lib/arch: Use standard mutex primitives in BSD network impl - [`62913ab`](https://github.com/debauchee/barrier/commit/62913ab7489cbc14f01aff43b42faf55fdb2efc7) lib/barrier: Remove unused code - [`c16581b`](https://github.com/debauchee/barrier/commit/c16581b399053e990ef3d3bcea31e9eb8c384158) lib/base: Rename m_mutex to mutex_ in EventQueue - [`cb69469`](https://github.com/debauchee/barrier/commit/cb694698713db0d0d768615454911b41db57eab4) lib/base: Use standard mutex primitives in EventQueue - [`27de30e`](https://github.com/debauchee/barrier/commit/27de30e76164cc1735c255a090089f68347260a6) lib/base: Use standard mutex primitives in event queue buffer - [`cbf22ad`](https://github.com/debauchee/barrier/commit/cbf22ad5898533953f6d5e58ddaf1479db87010c) lib/net: Use standard mutex primitives in socket multiplexer - [`836a65c`](https://github.com/debauchee/barrier/commit/836a65cda4f5ca0da400d60238045663cd9fab3d) lib/net: Use standard mutex primitives in TCP socket code - [`489f45f`](https://github.com/debauchee/barrier/commit/489f45fc94dce838dfd9bb450ecec2e58800edb3) lib/arch: Add IArchMultithread::wait_cond_var() for standard mutex ### 📊 Changes **52 files changed** (+346 additions, -1405 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/arch/Arch.h` (+2 -16) ➕ `src/lib/arch/IArchMultithread.cpp` (+50 -0) 📝 `src/lib/arch/IArchMultithread.h` (+9 -72) 📝 `src/lib/arch/unix/ArchMultithreadPosix.cpp` (+0 -156) 📝 `src/lib/arch/unix/ArchMultithreadPosix.h` (+0 -19) 📝 `src/lib/arch/unix/ArchNetworkBSD.cpp` (+19 -29) 📝 `src/lib/arch/unix/ArchNetworkBSD.h` (+2 -1) 📝 `src/lib/arch/win32/ArchDaemonWindows.cpp` (+14 -34) 📝 `src/lib/arch/win32/ArchDaemonWindows.h` (+4 -2) 📝 `src/lib/arch/win32/ArchMultithreadWindows.cpp` (+33 -186) 📝 `src/lib/arch/win32/ArchMultithreadWindows.h` (+2 -24) 📝 `src/lib/arch/win32/ArchNetworkWinsock.cpp` (+10 -18) 📝 `src/lib/arch/win32/ArchNetworkWinsock.h` (+3 -1) 📝 `src/lib/arch/win32/ArchTaskBarWindows.cpp` (+15 -36) 📝 `src/lib/arch/win32/ArchTaskBarWindows.h` (+4 -2) 📝 `src/lib/barrier/ClientTaskBarReceiver.cpp` (+0 -1) 📝 `src/lib/barrier/PacketStreamFilter.cpp` (+8 -9) 📝 `src/lib/barrier/PacketStreamFilter.h` (+3 -2) 📝 `src/lib/barrier/PortableTaskBarReceiver.cpp` (+0 -1) 📝 `src/lib/barrier/ServerTaskBarReceiver.cpp` (+0 -1) _...and 32 more files_ </details> ### 📄 Description This PR replaces homegrown mutex and condition variable classes with what's available in the C++11 standard library. This will reduce maintenance effort going forward. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>