[PR #1356] [MERGED] [2.3.x] Backports of security fixes #1792

New issue

Closed

opened 2026-05-05 08:02:00 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:02:00 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1356
Author: @p12tic
Created: 11/1/2021
Status: ✅ Merged
Merged: 11/1/2021
Merged by: @p12tic

Base: 2.3.x ← Head: 2.3-security-fixes

📝 Commits (7)

d9b4a1c lib/server: Remove unused code
f546af4 lib: Enforce a maximum length of input messages
d762ab7 lib/net: Limit the maximum size of TCP or SSL input buffers
45cd2a9 lib/barrier: Disconnect client on too long input packets
ceecc61 lib/server: Close connection when client app-level handshake fails
1c1e83c lib/net: Fix race conditions when closing SSL connections
e32cc60 lib/net: Fix incorrect sharing of data between different SSL sessions

📊 Changes

17 files changed (+200 additions, -78 deletions)

View changed files

➕ doc/newsfragments/close-failed-handshake-connections.bugfix (+6 -0)
➕ doc/newsfragments/enforce-maximum-message-length.bugfix (+6 -0)
➕ doc/newsfragments/fix-crash-on-ssl-hello.bugfix (+4 -0)
➕ doc/newsfragments/ssl-corrupted-data.bugfix (+2 -0)
📝 src/lib/barrier/PacketStreamFilter.cpp (+16 -6)
📝 src/lib/barrier/PacketStreamFilter.h (+3 -1)
📝 src/lib/barrier/ProtocolUtil.cpp (+10 -0)
📝 src/lib/barrier/protocol_types.h (+8 -0)
📝 src/lib/base/EventTypes.cpp (+1 -0)
📝 src/lib/base/EventTypes.h (+6 -0)
📝 src/lib/client/ServerProxy.cpp (+20 -9)
📝 src/lib/net/SecureSocket.cpp (+57 -38)
📝 src/lib/net/SecureSocket.h (+27 -9)
📝 src/lib/net/TCPSocket.cpp (+5 -3)
📝 src/lib/server/ClientListener.cpp (+5 -9)
📝 src/lib/server/ClientProxy1_0.cpp (+18 -3)
📝 src/lib/server/ClientProxyUnknown.cpp (+6 -0)

📄 Description

This PR backports #1351, #1350 and #1347 to 2.3.x branch.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1356 **Author:** [@p12tic](https://github.com/p12tic) **Created:** 11/1/2021 **Status:** ✅ Merged **Merged:** 11/1/2021 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `2.3.x` ← **Head:** `2.3-security-fixes` --- ### 📝 Commits (7) - [`d9b4a1c`](https://github.com/debauchee/barrier/commit/d9b4a1c703e1fef251d0f9616a347d32f3076c6d) lib/server: Remove unused code - [`f546af4`](https://github.com/debauchee/barrier/commit/f546af4a8521cca7c60fbbf81a03ef95ae9cb089) lib: Enforce a maximum length of input messages - [`d762ab7`](https://github.com/debauchee/barrier/commit/d762ab7d50ee2c1e6107094eb01913444ec2c6fa) lib/net: Limit the maximum size of TCP or SSL input buffers - [`45cd2a9`](https://github.com/debauchee/barrier/commit/45cd2a9f34272ed817fcb93c728b631261ac88cb) lib/barrier: Disconnect client on too long input packets - [`ceecc61`](https://github.com/debauchee/barrier/commit/ceecc6138807b92b6a776c7357ba7ad63fecc910) lib/server: Close connection when client app-level handshake fails - [`1c1e83c`](https://github.com/debauchee/barrier/commit/1c1e83c94235a0148503144f070155c4eba21cc9) lib/net: Fix race conditions when closing SSL connections - [`e32cc60`](https://github.com/debauchee/barrier/commit/e32cc609e281794f69d4f8bbf048ba30b6f8e22c) lib/net: Fix incorrect sharing of data between different SSL sessions ### 📊 Changes **17 files changed** (+200 additions, -78 deletions) <details> <summary>View changed files</summary> ➕ `doc/newsfragments/close-failed-handshake-connections.bugfix` (+6 -0) ➕ `doc/newsfragments/enforce-maximum-message-length.bugfix` (+6 -0) ➕ `doc/newsfragments/fix-crash-on-ssl-hello.bugfix` (+4 -0) ➕ `doc/newsfragments/ssl-corrupted-data.bugfix` (+2 -0) 📝 `src/lib/barrier/PacketStreamFilter.cpp` (+16 -6) 📝 `src/lib/barrier/PacketStreamFilter.h` (+3 -1) 📝 `src/lib/barrier/ProtocolUtil.cpp` (+10 -0) 📝 `src/lib/barrier/protocol_types.h` (+8 -0) 📝 `src/lib/base/EventTypes.cpp` (+1 -0) 📝 `src/lib/base/EventTypes.h` (+6 -0) 📝 `src/lib/client/ServerProxy.cpp` (+20 -9) 📝 `src/lib/net/SecureSocket.cpp` (+57 -38) 📝 `src/lib/net/SecureSocket.h` (+27 -9) 📝 `src/lib/net/TCPSocket.cpp` (+5 -3) 📝 `src/lib/server/ClientListener.cpp` (+5 -9) 📝 `src/lib/server/ClientProxy1_0.cpp` (+18 -3) 📝 `src/lib/server/ClientProxyUnknown.cpp` (+6 -0) </details> ### 📄 Description This PR backports #1351, #1350 and #1347 to 2.3.x branch. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>