[PR #1352] [MERGED] Cleanup internal callback APIs #1790

New issue

Closed

opened 2026-05-05 08:01:59 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:01:59 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1352
Author: @p12tic
Created: 11/1/2021
Status: ✅ Merged
Merged: 11/1/2021
Merged by: @p12tic

Base: master ← Head: cleanup-callbacks

📝 Commits (6)

666460a lib/platform: Use std::function instead of IJob in MSWindowsDesks
815e80e lib: Remove unused threading functionality related to thread results
9cf590c lib: Make ThreadFunc return nothing
5335669 lib/arch: Pass jobs to Arch threads as std::function
d2c106d lib: Pass jobs to barrier::Thread as std::function
d7de571 lib/net: Simplify handling of socket multiplexer jobs

📊 Changes

50 files changed (+159 additions, -531 deletions)

View changed files

📝 src/lib/arch/IArchMultithread.h (+3 -11)
📝 src/lib/arch/unix/ArchMultithreadPosix.cpp (+5 -24)
📝 src/lib/arch/unix/ArchMultithreadPosix.h (+1 -2)
📝 src/lib/arch/win32/ArchMultithreadWindows.cpp (+4 -25)
📝 src/lib/arch/win32/ArchMultithreadWindows.h (+1 -2)
📝 src/lib/arch/win32/ArchTaskBarWindows.cpp (+1 -8)
📝 src/lib/arch/win32/ArchTaskBarWindows.h (+0 -1)
📝 src/lib/barrier/App.cpp (+1 -3)
📝 src/lib/barrier/App.h (+1 -1)
📝 src/lib/barrier/ClientApp.cpp (+1 -5)
📝 src/lib/barrier/ClientApp.h (+0 -1)
📝 src/lib/barrier/ServerApp.cpp (+1 -5)
📝 src/lib/barrier/StreamChunker.cpp (+2 -3)
📝 src/lib/barrier/StreamChunker.h (+1 -4)
📝 src/lib/barrier/win32/DaemonApp.cpp (+0 -1)
➖ src/lib/base/FunctionJob.cpp (+0 -43)
➖ src/lib/base/FunctionJob.h (+0 -39)
➖ src/lib/base/TMethodJob.h (+0 -68)
📝 src/lib/base/log_outputters.cpp (+0 -1)
📝 src/lib/client/Client.cpp (+5 -14)

...and 30 more files

📄 Description

This PR cleans up a number of internal APIs that accept callbacks. We use the standard std::function instead of home-grown classes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1352 **Author:** [@p12tic](https://github.com/p12tic) **Created:** 11/1/2021 **Status:** ✅ Merged **Merged:** 11/1/2021 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `cleanup-callbacks` --- ### 📝 Commits (6) - [`666460a`](https://github.com/debauchee/barrier/commit/666460aced4885c81457b2c1758f2a8ffd6e432a) lib/platform: Use std::function instead of IJob in MSWindowsDesks - [`815e80e`](https://github.com/debauchee/barrier/commit/815e80ec4d0855be5049504f483cbc4f2e357d15) lib: Remove unused threading functionality related to thread results - [`9cf590c`](https://github.com/debauchee/barrier/commit/9cf590ccd75eaa28ec93771ccafa283672d051c4) lib: Make ThreadFunc return nothing - [`5335669`](https://github.com/debauchee/barrier/commit/53356697d92c0a2161486110ff60861c28b29b21) lib/arch: Pass jobs to Arch threads as std::function - [`d2c106d`](https://github.com/debauchee/barrier/commit/d2c106db530c973dbc74867ee1a252ec7739555e) lib: Pass jobs to barrier::Thread as std::function - [`d7de571`](https://github.com/debauchee/barrier/commit/d7de571fdc56c6b76eabb69cf430a9c72251e0be) lib/net: Simplify handling of socket multiplexer jobs ### 📊 Changes **50 files changed** (+159 additions, -531 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/arch/IArchMultithread.h` (+3 -11) 📝 `src/lib/arch/unix/ArchMultithreadPosix.cpp` (+5 -24) 📝 `src/lib/arch/unix/ArchMultithreadPosix.h` (+1 -2) 📝 `src/lib/arch/win32/ArchMultithreadWindows.cpp` (+4 -25) 📝 `src/lib/arch/win32/ArchMultithreadWindows.h` (+1 -2) 📝 `src/lib/arch/win32/ArchTaskBarWindows.cpp` (+1 -8) 📝 `src/lib/arch/win32/ArchTaskBarWindows.h` (+0 -1) 📝 `src/lib/barrier/App.cpp` (+1 -3) 📝 `src/lib/barrier/App.h` (+1 -1) 📝 `src/lib/barrier/ClientApp.cpp` (+1 -5) 📝 `src/lib/barrier/ClientApp.h` (+0 -1) 📝 `src/lib/barrier/ServerApp.cpp` (+1 -5) 📝 `src/lib/barrier/StreamChunker.cpp` (+2 -3) 📝 `src/lib/barrier/StreamChunker.h` (+1 -4) 📝 `src/lib/barrier/win32/DaemonApp.cpp` (+0 -1) ➖ `src/lib/base/FunctionJob.cpp` (+0 -43) ➖ `src/lib/base/FunctionJob.h` (+0 -39) ➖ `src/lib/base/TMethodJob.h` (+0 -68) 📝 `src/lib/base/log_outputters.cpp` (+0 -1) 📝 `src/lib/client/Client.cpp` (+5 -14) _...and 30 more files_ </details> ### 📄 Description This PR cleans up a number of internal APIs that accept callbacks. We use the standard `std::function` instead of home-grown classes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>