[PR #1345] [MERGED] Filesystem operations cleanup #1786

New issue

Closed

opened 2026-05-05 08:01:54 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:01:54 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1345
Author: @p12tic
Created: 11/1/2021
Status: ✅ Merged
Merged: 11/1/2021
Merged by: @p12tic

Base: master ← Head: filesystem-cleanup

📝 Commits (10+)

801a5a7 ext: Add https://github.com/gulrak/filesystem for filesystem operations
a987605 lib/io: Rename fstream.h to filesystem.h
bcafdc6 src/lib: Switch to ghc::filesystem in path utilities
e7d936b lib/common: Replace PathUtilities::concat with barrier::fs equivalent
677612d lib/common: Replace PathUtilities::basename with barrier::fs equivalent
298980f lib/common: Move DataDirectories to barrier namespace
a2ca7e2 lib/common: Switch data directories to fs::path
220f9e8 lib/common: Remove unused file
d033ffa lib/net: Use fs::is_regular_file() to check for path existence
b76b332 lib/common: Move SSL certificate path definition to common location

📊 Changes

33 files changed (+196 additions, -314 deletions)

View changed files

📝 .gitmodules (+3 -0)
📝 CMakeLists.txt (+2 -0)
➕ ext/gulrak-filesystem (+1 -0)
📝 src/gui/src/MainWindow.cpp (+4 -4)
📝 src/gui/src/SslCertificate.cpp (+16 -35)
📝 src/gui/src/SslCertificate.h (+3 -8)
📝 src/lib/barrier/App.cpp (+1 -1)
📝 src/lib/barrier/ArgParser.cpp (+10 -4)
📝 src/lib/barrier/ArgParser.h (+3 -0)
📝 src/lib/barrier/ArgsBase.cpp (+1 -1)
📝 src/lib/barrier/ArgsBase.h (+3 -2)
📝 src/lib/barrier/ClientApp.cpp (+1 -2)
📝 src/lib/barrier/DropHelper.cpp (+1 -1)
📝 src/lib/barrier/ServerApp.cpp (+18 -15)
📝 src/lib/barrier/win32/DaemonApp.cpp (+1 -1)
📝 src/lib/base/log_outputters.cpp (+1 -1)
📝 src/lib/common/DataDirectories.h (+23 -15)
📝 src/lib/common/DataDirectories_static.cpp (+20 -12)
➖ src/lib/common/MacOSXPrecomp.h (+0 -23)
➖ src/lib/common/PathUtilities.cpp (+0 -75)

...and 13 more files

📄 Description

This PR adds https://github.com/gulrak/filesystem as a dependency for filesystem operations and rewrites most of these to use that library. This way we don't need to invent the bicycle ourselves.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1345 **Author:** [@p12tic](https://github.com/p12tic) **Created:** 11/1/2021 **Status:** ✅ Merged **Merged:** 11/1/2021 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `filesystem-cleanup` --- ### 📝 Commits (10+) - [`801a5a7`](https://github.com/debauchee/barrier/commit/801a5a7084b20e2548af0e8645bf3b0bea490585) ext: Add https://github.com/gulrak/filesystem for filesystem operations - [`a987605`](https://github.com/debauchee/barrier/commit/a987605513a0f99c2964b0850d43264f41117a2b) lib/io: Rename fstream.h to filesystem.h - [`bcafdc6`](https://github.com/debauchee/barrier/commit/bcafdc6783fe7a9c5d5bd0c4ec3297f5c1eb2626) src/lib: Switch to ghc::filesystem in path utilities - [`e7d936b`](https://github.com/debauchee/barrier/commit/e7d936b5d7aada43d6f0a55b620c9573ad31f3e4) lib/common: Replace PathUtilities::concat with barrier::fs equivalent - [`677612d`](https://github.com/debauchee/barrier/commit/677612d3429c8e37deeaea960584c7ac9b326def) lib/common: Replace PathUtilities::basename with barrier::fs equivalent - [`298980f`](https://github.com/debauchee/barrier/commit/298980fa863c0630cfbd4c42f84460fa36595d2f) lib/common: Move DataDirectories to barrier namespace - [`a2ca7e2`](https://github.com/debauchee/barrier/commit/a2ca7e29f5fdfa2e668f028412b7e716816f7517) lib/common: Switch data directories to fs::path - [`220f9e8`](https://github.com/debauchee/barrier/commit/220f9e8274e7dc5aa96ada210f030794fe262392) lib/common: Remove unused file - [`d033ffa`](https://github.com/debauchee/barrier/commit/d033ffa3d8b04fa103b8020c0a2927d5f7d5d16f) lib/net: Use fs::is_regular_file() to check for path existence - [`b76b332`](https://github.com/debauchee/barrier/commit/b76b332f2f40ed46c639ec178965743fc0ef0d03) lib/common: Move SSL certificate path definition to common location ### 📊 Changes **33 files changed** (+196 additions, -314 deletions) <details> <summary>View changed files</summary> 📝 `.gitmodules` (+3 -0) 📝 `CMakeLists.txt` (+2 -0) ➕ `ext/gulrak-filesystem` (+1 -0) 📝 `src/gui/src/MainWindow.cpp` (+4 -4) 📝 `src/gui/src/SslCertificate.cpp` (+16 -35) 📝 `src/gui/src/SslCertificate.h` (+3 -8) 📝 `src/lib/barrier/App.cpp` (+1 -1) 📝 `src/lib/barrier/ArgParser.cpp` (+10 -4) 📝 `src/lib/barrier/ArgParser.h` (+3 -0) 📝 `src/lib/barrier/ArgsBase.cpp` (+1 -1) 📝 `src/lib/barrier/ArgsBase.h` (+3 -2) 📝 `src/lib/barrier/ClientApp.cpp` (+1 -2) 📝 `src/lib/barrier/DropHelper.cpp` (+1 -1) 📝 `src/lib/barrier/ServerApp.cpp` (+18 -15) 📝 `src/lib/barrier/win32/DaemonApp.cpp` (+1 -1) 📝 `src/lib/base/log_outputters.cpp` (+1 -1) 📝 `src/lib/common/DataDirectories.h` (+23 -15) 📝 `src/lib/common/DataDirectories_static.cpp` (+20 -12) ➖ `src/lib/common/MacOSXPrecomp.h` (+0 -23) ➖ `src/lib/common/PathUtilities.cpp` (+0 -75) _...and 13 more files_ </details> ### 📄 Description This PR adds https://github.com/gulrak/filesystem as a dependency for filesystem operations and rewrites most of these to use that library. This way we don't need to invent the bicycle ourselves. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>