[PR #1242] [MERGED] Some ifdef cleanup #1769

New issue

Closed

opened 2026-05-05 08:01:30 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:01:30 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1242
Author: @whot
Created: 8/9/2021
Status: ✅ Merged
Merged: 8/31/2021
Merged by: @p12tic

Base: master ← Head: wip/janitor

📝 Commits (2)

c32ca21 barrier: split the platform-specific argument parsing
dec895e cmake: move two windows #defines to the main cmake file

📊 Changes

4 files changed (+36 additions, -15 deletions)

View changed files

📝 CMakeLists.txt (+2 -0)
📝 src/lib/barrier/ArgParser.cpp (+30 -9)
📝 src/lib/barrier/ArgParser.h (+3 -0)
📝 src/lib/common/common.h (+1 -6)

📄 Description

Two non-functional changes [1] that make the code a tiny bit simpler.

[1] I don't have a windows machine, so I'm mostly hoping it's non-functional on windows ;)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1242 **Author:** [@whot](https://github.com/whot) **Created:** 8/9/2021 **Status:** ✅ Merged **Merged:** 8/31/2021 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `wip/janitor` --- ### 📝 Commits (2) - [`c32ca21`](https://github.com/debauchee/barrier/commit/c32ca2195de7280371f054259f457a34c95eaf23) barrier: split the platform-specific argument parsing - [`dec895e`](https://github.com/debauchee/barrier/commit/dec895e8d3a0838272e694d392416e59c058938c) cmake: move two windows #defines to the main cmake file ### 📊 Changes **4 files changed** (+36 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+2 -0) 📝 `src/lib/barrier/ArgParser.cpp` (+30 -9) 📝 `src/lib/barrier/ArgParser.h` (+3 -0) 📝 `src/lib/common/common.h` (+1 -6) </details> ### 📄 Description Two non-functional changes [1] that make the code a tiny bit simpler. [1] I don't have a windows machine, so I'm mostly hoping it's non-functional on windows ;) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>