[PR #1214] [MERGED] Add JP specific key mappings #1767

New issue

Closed

opened 2026-05-05 08:01:22 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:01:22 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1214
Author: @tom-tan
Created: 6/25/2021
Status: ✅ Merged
Merged: 8/19/2021
Merged by: @p12tic

Base: master ← Head: add-mappings-for-jp

📝 Commits (3)

14b5ceb Fix keycode for Kana in Windows key mapping
eec6769 Add IME on and IME off key entries to Windows
7a4c6a2 Add Henkan, Muhenkan and Zenkaku entries to macOS

📊 Changes

2 files changed (+10 additions, -4 deletions)

View changed files

📝 src/lib/platform/MSWindowsKeyState.cpp (+3 -3)
📝 src/lib/platform/OSXKeyState.cpp (+7 -1)

📄 Description

This request adds key mappings for Japanese keyboards.

Add IME on and IME off key entries to Windows. These keys are recently introduced. Note that these key codes are same as Kana and EisuToggle keys in macOS, respectively.
- I also fixed the code for VK_KANA (0x016 is correct).
Add Henkan, Muhenkan and Zenkaku key entries to macOS. Although these keys are not provided in mac keyboards, they can be sent from Windows barrier servers.
- I declare the key codes for Henkan and Muhenkan by myself because I did not find the declarations of these key codes.
- I found that these keys are sometimes referred as international4 and international5, respectively (e.g., search result in Github).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1214 **Author:** [@tom-tan](https://github.com/tom-tan) **Created:** 6/25/2021 **Status:** ✅ Merged **Merged:** 8/19/2021 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `add-mappings-for-jp` --- ### 📝 Commits (3) - [`14b5ceb`](https://github.com/debauchee/barrier/commit/14b5cebb62881a4a3cd1f8e4850a6b9cdbab069a) Fix keycode for `Kana` in Windows key mapping - [`eec6769`](https://github.com/debauchee/barrier/commit/eec676948c5f84515bf2228743ddfdfe0290bb89) Add `IME on` and `IME off` key entries to Windows - [`7a4c6a2`](https://github.com/debauchee/barrier/commit/7a4c6a25d7305c1772149fd9e20db8594565020b) Add `Henkan`, `Muhenkan` and `Zenkaku` entries to macOS ### 📊 Changes **2 files changed** (+10 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/platform/MSWindowsKeyState.cpp` (+3 -3) 📝 `src/lib/platform/OSXKeyState.cpp` (+7 -1) </details> ### 📄 Description This request adds key mappings for Japanese keyboards. - Add `IME on` and `IME off` key entries to Windows. These keys are recently [introduced](https://docs.microsoft.com/en-US/windows-hardware/design/component-guidelines/keyboard-japan-ime#hid-usage-ps2-scan-code-and-virtual-key-code-for-imeon-key--imeoff-key). Note that these key codes are same as `Kana` and `EisuToggle` keys in macOS, respectively. - I also fixed the code for `VK_KANA` (0x016 is correct). - Add `Henkan`, `Muhenkan` and `Zenkaku` key entries to macOS. Although these keys are not provided in mac keyboards, they can be sent from Windows barrier servers. - I declare the key codes for `Henkan` and `Muhenkan` by myself because I did not find the declarations of these key codes. - I found that these keys are sometimes referred as `international4` and `international5`, respectively (e.g., [search result in Github](https://github.com/search?q=international4+keycode+henkan&type=code)). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>