[PR #1068] [MERGED] Fix unquoted windows service image path #1752

New issue

Closed

opened 2026-05-05 08:01:04 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:01:04 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1068
Author: @tete1030
Created: 2/17/2021
Status: ✅ Merged
Merged: 6/25/2021
Merged by: @p12tic

Base: master ← Head: fix-win-service-imagepath

📝 Commits (2)

0fa91e0 dist: Fix unquoted windows service image path
1fac0e6 doc: Add newsfragment

📊 Changes

2 files changed (+2 additions, -1 deletions)

View changed files

📝 dist/inno/barrier.iss.in (+1 -1)
➕ doc/newsfragments/windows-service-path.bugfix (+1 -0)

📄 Description

Currently, in Windows, if barrier is installed in a path with spaces, the Services Manager may find the wrong bin file.
For example, if installed in C:\Program Files\Barrier\, in the same time there is also a file of pathname C:\Program, Services Manager will try to execute C:\Program.

Reference

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1068 **Author:** [@tete1030](https://github.com/tete1030) **Created:** 2/17/2021 **Status:** ✅ Merged **Merged:** 6/25/2021 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `fix-win-service-imagepath` --- ### 📝 Commits (2) - [`0fa91e0`](https://github.com/debauchee/barrier/commit/0fa91e0fd3e3d291d4df4cdc2d760c2e3e84a749) dist: Fix unquoted windows service image path - [`1fac0e6`](https://github.com/debauchee/barrier/commit/1fac0e66039f07b197f65b57c02c58a1a8b86012) doc: Add newsfragment ### 📊 Changes **2 files changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `dist/inno/barrier.iss.in` (+1 -1) ➕ `doc/newsfragments/windows-service-path.bugfix` (+1 -0) </details> ### 📄 Description Currently, in Windows, if barrier is installed in a path with spaces, the Services Manager may find the wrong bin file. For example, if installed in `C:\Program Files\Barrier\`, in the same time there is also a file of pathname `C:\Program`, Services Manager will try to execute `C:\Program`. Reference - https://stackoverflow.com/questions/8911608/mysql-not-a-valid-win32-application - https://stackoverflow.com/questions/34336982/how-to-create-a-path-with-arguments-to-a-service --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>