[PR #1011] [MERGED] Add tests for Hotkey serialization #1737

New issue

Closed

opened 2026-05-05 08:00:41 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:00:41 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/1011
Author: @p12tic
Created: 1/10/2021
Status: ✅ Merged
Merged: 1/10/2021
Merged by: @p12tic

Base: master ← Head: hotkey-tests

📝 Commits (7)

7f76d3c gui/tests: Use common per-platform libs variable for dependencies
e7da893 gui/test: Extract temporary file creation to a separate file
016393f gui: Remove unnecessary accessor to private member in Hotkey
a691b31 gui: Make access to hotkey actions explicit
0579101 gui: Don't use friends to limit access to Hotkey
68cfb4e gui: Don't use friends to limit access to Action
fb067d4 gui/test: Add tests for Hotkey serialization to QSettings

📊 Changes

10 files changed (+358 additions, -54 deletions)

View changed files

📝 src/gui/CMakeLists.txt (+6 -5)
📝 src/gui/src/Action.cpp (+7 -7)
📝 src/gui/src/Action.h (+16 -13)
📝 src/gui/src/ActionDialog.cpp (+2 -2)
📝 src/gui/src/Hotkey.cpp (+8 -8)
📝 src/gui/src/Hotkey.h (+5 -10)
📝 src/gui/src/ServerConfigDialog.cpp (+6 -4)
➕ src/gui/test/HotkeyTests.cpp (+244 -0)
📝 src/gui/test/KeySequenceTests.cpp (+26 -5)
➕ src/gui/test/Utils.h (+38 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/1011 **Author:** [@p12tic](https://github.com/p12tic) **Created:** 1/10/2021 **Status:** ✅ Merged **Merged:** 1/10/2021 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `hotkey-tests` --- ### 📝 Commits (7) - [`7f76d3c`](https://github.com/debauchee/barrier/commit/7f76d3cdcc112d6bff3b013e23e838d9cccb52e2) gui/tests: Use common per-platform libs variable for dependencies - [`e7da893`](https://github.com/debauchee/barrier/commit/e7da893f5a13d519cbc4db22a4c8d45f7e765b76) gui/test: Extract temporary file creation to a separate file - [`016393f`](https://github.com/debauchee/barrier/commit/016393fb671c533715c93822d07ceb687aea0a8f) gui: Remove unnecessary accessor to private member in Hotkey - [`a691b31`](https://github.com/debauchee/barrier/commit/a691b31b8ea98ab118d27a20a6db5ad2e4a60182) gui: Make access to hotkey actions explicit - [`0579101`](https://github.com/debauchee/barrier/commit/0579101272cea114f1757f8e186d30b2697bf480) gui: Don't use friends to limit access to Hotkey - [`68cfb4e`](https://github.com/debauchee/barrier/commit/68cfb4e58566c8019479e2c3318560cd35c31d89) gui: Don't use friends to limit access to Action - [`fb067d4`](https://github.com/debauchee/barrier/commit/fb067d4001ad8d3b9b4e30edc77671f546a44632) gui/test: Add tests for Hotkey serialization to QSettings ### 📊 Changes **10 files changed** (+358 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `src/gui/CMakeLists.txt` (+6 -5) 📝 `src/gui/src/Action.cpp` (+7 -7) 📝 `src/gui/src/Action.h` (+16 -13) 📝 `src/gui/src/ActionDialog.cpp` (+2 -2) 📝 `src/gui/src/Hotkey.cpp` (+8 -8) 📝 `src/gui/src/Hotkey.h` (+5 -10) 📝 `src/gui/src/ServerConfigDialog.cpp` (+6 -4) ➕ `src/gui/test/HotkeyTests.cpp` (+244 -0) 📝 `src/gui/test/KeySequenceTests.cpp` (+26 -5) ➕ `src/gui/test/Utils.h` (+38 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>